[PATCH 2/2] Documentation: reboot-mode: mention that system.reboot_mode.next is initially set to 'normal'
Signed-off-by: Ulrich Ölmann --- Documentation/user/reboot-mode.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/user/reboot-mode.rst b/Documentation/user/reboot-mode.rst index 24deae78727e..83d4136b8592 100644 --- a/Documentation/user/reboot-mode.rst +++ b/Documentation/user/reboot-mode.rst @@ -31,7 +31,8 @@ Devices registered with the reboot mode API gain two parameters: - ``$dev_of_reboot_mode.prev`` (read-only): The reboot mode that was set previously to barebox startup. - ``$dev_of_reboot_mode.next``: The next reboot mode, for when the - system is reset. + system is reset. Its initial value after startup is 0 which corresponds + to ``normal`` by default. The reboot mode driver core use the alias name if available to name the device. By convention, this should end with ``.reboot_mode``, e.g.:: -- 2.30.2 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH 1/2] Documentation: reboot-mode: fix typos
Signed-off-by: Ulrich Ölmann --- Documentation/user/reboot-mode.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/user/reboot-mode.rst b/Documentation/user/reboot-mode.rst index 681438d94498..24deae78727e 100644 --- a/Documentation/user/reboot-mode.rst +++ b/Documentation/user/reboot-mode.rst @@ -29,9 +29,9 @@ User API Devices registered with the reboot mode API gain two parameters: - ``$dev_of_reboot_mode.prev`` (read-only): The reboot mode that was - set previous to barebox startup + set previously to barebox startup. - ``$dev_of_reboot_mode.next``: The next reboot mode, for when the - system is reset + system is reset. The reboot mode driver core use the alias name if available to name the device. By convention, this should end with ``.reboot_mode``, e.g.:: -- 2.30.2 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] kbuild: dtc: use env to resolve echo
On Thu, Jan 20, 2022 at 09:56:49AM +0100, Sascha Hauer wrote:
> On Thu, Jan 20, 2022 at 08:47:33AM +0100, Rouven Czerwinski wrote:
> > Posix does not mandate to have binaries within a certain path, but
> > rather that the utilities may be available. Use env to resolve and call
> > echo from PATH.
> >
> > Fixes: 2ae7ac7ab2f1 ("kbuild: dtc: Allow adding device tree fragments via
> > config")
> >
> > Signed-off-by: Rouven Czerwinski
> > ---
> > scripts/Makefile.lib | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> > index 13b1789c01..94ca1b771b 100644
> > --- a/scripts/Makefile.lib
> > +++ b/scripts/Makefile.lib
> > @@ -340,7 +340,7 @@ dts-frags = $(subst
> > $(quote),,$(CONFIG_EXTERNAL_DTS_FRAGMENTS))
> > quiet_cmd_dtc = DTC $@
> > # For compatibility between make 4.2 and 4.3
> > H := \#
> > -cmd_dtc = /bin/echo -e '$(H)define $(subst -,_,$(*F))_dts 1\n'$(foreach
> > f,$< $(dts-frags),'$(H)include "$(f)"\n') | \
>
> Why hardcode /bin/echo anyway and not use plain 'echo' instead. I assume
> because echo can be a shell builtin, but are there shells out there
> where the builtin is not enough?
The builtin echo implementations are not very compatible. Better use printf
instead. For example, echo from dash (the default /bin/sh in Debian) does
not support '-e'.
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] commands: wd: add new -x option to inhibit all watchdogs
On Wed, Jan 19, 2022 at 03:08:16PM +0100, Ahmad Fatoum wrote: > When booting after nv.autoboot=abort, barebox will drop to shell and > try to inhibit all watchdogs: If they can be disabled, they will be and > otherwise if autopoll support is compiled in, they will be periodically > fed. This is useful for development. For this to work though, barebox > needs an environment. Make watchdog_inhibit_all more accessible by > making it directly invocable with wd -x. > > Signed-off-by: Ahmad Fatoum > --- > Cc: Michael Olbrich > Cc: Yann Sionneau > Cc: Jules Maselbas > --- > commands/wd.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) Applied, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] kbuild: dtc: use env to resolve echo
On Thu, Jan 20, 2022 at 08:47:33AM +0100, Rouven Czerwinski wrote:
> Posix does not mandate to have binaries within a certain path, but
> rather that the utilities may be available. Use env to resolve and call
> echo from PATH.
>
> Fixes: 2ae7ac7ab2f1 ("kbuild: dtc: Allow adding device tree fragments via
> config")
>
> Signed-off-by: Rouven Czerwinski
> ---
> scripts/Makefile.lib | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 13b1789c01..94ca1b771b 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -340,7 +340,7 @@ dts-frags = $(subst
> $(quote),,$(CONFIG_EXTERNAL_DTS_FRAGMENTS))
> quiet_cmd_dtc = DTC $@
> # For compatibility between make 4.2 and 4.3
> H := \#
> -cmd_dtc = /bin/echo -e '$(H)define $(subst -,_,$(*F))_dts 1\n'$(foreach f,$<
> $(dts-frags),'$(H)include "$(f)"\n') | \
Why hardcode /bin/echo anyway and not use plain 'echo' instead. I assume
because echo can be a shell builtin, but are there shells out there
where the builtin is not enough?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
[PATCH] Kbuild: use printf for as-instr
Instead of hard coding /bin/echo, port the upstream printf formatting. Signed-off-by: Rouven Czerwinski --- scripts/Kbuild.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include index 838ab11e7c..ab092e455c 100644 --- a/scripts/Kbuild.include +++ b/scripts/Kbuild.include @@ -111,7 +111,7 @@ as-option = $(call try-run,\ # Usage: cflags-y += $(call as-instr,instr,option1,option2) as-instr = $(call try-run,\ - /bin/echo -e "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3)) + printf "%b\n" "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3)) # cc-option # Usage: cflags-y += $(call cc-option,-march=winchip-c6,-march=i586) -- 2.34.1 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH v2 1/2] Add the base Ricoh RN5T568 PMIC driver
On Tue, Jan 18, 2022 at 09:21:21AM +0100, Juergen Borleis wrote: > --- > drivers/mfd/Kconfig | 6 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/rn5t568.c | 165 ++ > 3 files changed, 172 insertions(+) > create mode 100644 drivers/mfd/rn5t568.c Applied, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] kbuild: dtc: use env to resolve echo
Hi Trent, On Thu, 2022-01-20 at 00:36 -0800, Trent Piepho wrote: > There's another in scripts/Kbuild.include Yep, I have a patch for that as well. We haven't hit this since as- instr isn't used anywhere within barebox. - rcz ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] power: reset: Kconfig: fix copy-&-paste bug in help text
On Wed, Jan 19, 2022 at 03:45:43PM +0100, Ulrich Ölmann wrote: > Signed-off-by: Ulrich Ölmann > --- > drivers/power/reset/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied, thanks Sascha > > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig > index e4151d8bc608..0a88bcdefa9b 100644 > --- a/drivers/power/reset/Kconfig > +++ b/drivers/power/reset/Kconfig > @@ -12,7 +12,8 @@ config SYSCON_REBOOT_MODE > help > Say y here will enable reboot mode driver. This will > get reboot mode arguments and store it in SYSCON mapped > - register, then the bootloader can read it to take different > + register, then the bootloader can read it and take different > + action according to the mode. > > config NVMEM_REBOOT_MODE > bool "Generic NVMEM reboot mode driver" > -- > 2.30.2 > > > ___ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] kbuild: dtc: use env to resolve echo
There's another in scripts/Kbuild.include
On Thu, Jan 20, 2022 at 12:04 AM Rouven Czerwinski
wrote:
>
> Posix does not mandate to have binaries within a certain path, but
> rather that the utilities may be available. Use env to resolve and call
> echo from PATH.
>
> Fixes: 2ae7ac7ab2f1 ("kbuild: dtc: Allow adding device tree fragments via
> config")
>
> Signed-off-by: Rouven Czerwinski
> ---
> scripts/Makefile.lib | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 13b1789c01..94ca1b771b 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -340,7 +340,7 @@ dts-frags = $(subst
> $(quote),,$(CONFIG_EXTERNAL_DTS_FRAGMENTS))
> quiet_cmd_dtc = DTC $@
> # For compatibility between make 4.2 and 4.3
> H := \#
> -cmd_dtc = /bin/echo -e '$(H)define $(subst -,_,$(*F))_dts 1\n'$(foreach f,$<
> $(dts-frags),'$(H)include "$(f)"\n') | \
> +cmd_dtc = /usr/bin/env echo -e '$(H)define $(subst -,_,$(*F))_dts
> 1\n'$(foreach f,$< $(dts-frags),'$(H)include "$(f)"') | \
> $(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) - ; \
> $(objtree)/scripts/dtc/dtc -O dtb -o $@ -b 0 \
> -i $(srctree)/arch/$(SRCARCH)/dts $(DTC_FLAGS) \
> --
> 2.34.1
>
>
> ___
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] block: efi-block-io: add devinfo callback for media info
On Wed, Jan 19, 2022 at 10:28:27AM +0100, Ahmad Fatoum wrote: > There's some useful info in efi_block_io_media that's only compiled in > at debug log level. While we need not print it always, it would be nice > to have this printed when doing devinfo. Add a custom devinfo callback > that does so and that invokes the normal EFI devinfo afterwards. > > Defining DEBUG in the file will still print it early in probe as before. > > Signed-off-by: Ahmad Fatoum > --- > drivers/block/efi-block-io.c | 42 +++- > 1 file changed, 27 insertions(+), 15 deletions(-) Applied, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] efi: skip devices without driver in efi_pause/continue_devices()
On Tue, Jan 18, 2022 at 02:43:17PM +0100, Philipp Zabel wrote:
> Skip devices on the EFI bus that do not have a driver assigned.
>
> Fixes: f68a547deebd ("efi: add efi_device hook to be called before an image
> is started")
> Signed-off-by: Philipp Zabel
> ---
> drivers/efi/efi-device.c | 14 --
> 1 file changed, 12 insertions(+), 2 deletions(-)
Applied, thanks
I wonder how this could work here, I think there are many devices
without a driver in every EFI barebox.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 6/6] ata: sata_mv: try probing multiple times
On Tue, Jan 18, 2022 at 03:04:53PM +0100, Steffen Trumtrar wrote: > In case of an un-recoverable probe error, try the whole sequence again, > starting with the hard-reset of the core. > > Signed-off-by: Steffen Trumtrar > --- > No need to look at this patch. It is awesome. Better look at this nice > chocolate: > > ___ ___ ___ ___ ___.---. > .'\__\'\__\'\__\'\__\'\__,` . ___ \ > |\/ __\/ __\/ __\/ __\/ _:\ |`. \ \___ \ > \\'\__\'\__\'\__\'\__\'\_`.__|""`. \ \___ \ > \\/ __\/ __\/ __\/ __\/ __:\ >\\'\__\'\__\'\__\ \__\'\_;-` > \\/ \/ \/ \/ \/ : hh| > \|__;| This patch is really great, I know that without even looking at it ;) Applied, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH v2 0/5] Add support for QOI image format
On Tue, Jan 18, 2022 at 12:02:30AM +0100, Jules Maselbas wrote: > changes in v2: > - added SPDX licence identifier > - added comment on modification done on qoiconv.c > - added pr_fmt macro and removed keep_file_data=1 in lib/gui/qoi.c > - reword few commits. > > --- > > Jules Maselbas (5): > filetype: Add QOI format image type > gui: Add qoi image format > scripts: Add qoiconv to convert png to qoi > logo: Enable image format selection for the logo > logo: Add choice for the QOI image format option Applied, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH v2 4/5] logo: Enable image format selection for the logo
On Mon, Jan 17, 2022 at 03:28:17PM -0800, Trent Piepho wrote: > On Mon, Jan 17, 2022 at 3:03 PM Jules Maselbas wrote: > > > > +choice > > + prompt "Logo image encoding format to be used" > > + default BAREBOX_LOGO_PNG > > + > > +config BAREBOX_LOGO_PNG > > + bool "png" > > + select PNG > > + help > > + Encode logo with the PNG image format > > + > > +config BAREBOX_LOGO_BMP > > + bool "bmp" > > + select BMP > > + help > > + Encode logo with the BMP image format > > You might say why one might want one format or ther other. What's the > point of adding bmp support? The point could be that for a small logo a bmp image + renderer is smaller than a better compressed image + a bigger renderer. I don't know if that's actually the case though. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH] kbuild: dtc: use env to resolve echo
Posix does not mandate to have binaries within a certain path, but
rather that the utilities may be available. Use env to resolve and call
echo from PATH.
Fixes: 2ae7ac7ab2f1 ("kbuild: dtc: Allow adding device tree fragments via
config")
Signed-off-by: Rouven Czerwinski
---
scripts/Makefile.lib | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 13b1789c01..94ca1b771b 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -340,7 +340,7 @@ dts-frags = $(subst
$(quote),,$(CONFIG_EXTERNAL_DTS_FRAGMENTS))
quiet_cmd_dtc = DTC $@
# For compatibility between make 4.2 and 4.3
H := \#
-cmd_dtc = /bin/echo -e '$(H)define $(subst -,_,$(*F))_dts 1\n'$(foreach f,$<
$(dts-frags),'$(H)include "$(f)"\n') | \
+cmd_dtc = /usr/bin/env echo -e '$(H)define $(subst -,_,$(*F))_dts
1\n'$(foreach f,$< $(dts-frags),'$(H)include "$(f)"') | \
$(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) - ; \
$(objtree)/scripts/dtc/dtc -O dtb -o $@ -b 0 \
-i $(srctree)/arch/$(SRCARCH)/dts $(DTC_FLAGS) \
--
2.34.1
___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
