Re: [PATCH] commands: led: print actual error code when led_set fails

2019-12-13 Thread Sascha Hauer 
On Thu, Dec 12, 2019 at 08:34:17PM +0100, Ahmad Fatoum wrote:
> If led_set fails, the error code is the return value, not errno.
> Fix this. While at replace the magic value in the command return code.
> 
> Signed-off-by: Ahmad Fatoum 
> ---
>  commands/led.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.   | |
Steuerwalder Str. 21   | http://www.pengutronix.de/  |
31137 Hildesheim, Germany  | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH] commands: led: print actual error code when led_set fails

2019-12-12 Thread Ahmad Fatoum 
If led_set fails, the error code is the return value, not errno.
Fix this. While at replace the magic value in the command return code.

Signed-off-by: Ahmad Fatoum 
---
 commands/led.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/commands/led.c b/commands/led.c
index a53f0df6a200..b608fcfa2cdb 100644
--- a/commands/led.c
+++ b/commands/led.c
@@ -101,8 +101,8 @@ static int do_led(int argc, char *argv[])
 
ret = led_set(led, value);
if (ret < 0) {
-   perror("led");
-   return 1;
+   printf("led: %s\n", strerror(-ret));
+   return COMMAND_ERROR;
}
 
return 0;
-- 
2.24.0


___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox