Re: [PATCH] common: resource: print conflicts as warning

2014-06-24 Thread Sascha Hauer
On Mon, Jun 23, 2014 at 10:00:00AM +0200, Alexander Aring wrote:
 Crazy things happen if there are resource conflicts and a device probe
 runs dev_request_mem_region. The dev_request_mem_region returns a
 start pointer which is zero. The probe function doesn't check on this
 and probing the device on zero base address.
 
 To debug this in debug log level there are many other outputs. This patch
 replace the debug print to a warning printout. A conflict should
 normally never happen. If there is a conflict it's much easier to see it
 with this patch.
 
 Signed-off-by: Alexander Aring alex.ar...@gmail.com

Applied, thanks

Sascha

 ---
  common/resource.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/common/resource.c b/common/resource.c
 index fe4680e..1ea2a75 100644
 --- a/common/resource.c
 +++ b/common/resource.c
 @@ -71,7 +71,7 @@ struct resource *__request_region(struct resource *parent,
   goto ok;
   if (start  r-end)
   continue;
 - debug(%s: 0x%08llx:0x%08llx conflicts with 
 0x%08llx:0x%08llx\n,
 + pr_warn(%s: 0x%08llx:0x%08llx conflicts with 
 0x%08llx:0x%08llx\n,
   __func__,
   (unsigned long long)start,
   (unsigned long long)end,
 -- 
 2.0.0
 
 
 ___
 barebox mailing list
 barebox@lists.infradead.org
 http://lists.infradead.org/mailman/listinfo/barebox
 

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


[PATCH] common: resource: print conflicts as warning

2014-06-23 Thread Alexander Aring
Crazy things happen if there are resource conflicts and a device probe
runs dev_request_mem_region. The dev_request_mem_region returns a
start pointer which is zero. The probe function doesn't check on this
and probing the device on zero base address.

To debug this in debug log level there are many other outputs. This patch
replace the debug print to a warning printout. A conflict should
normally never happen. If there is a conflict it's much easier to see it
with this patch.

Signed-off-by: Alexander Aring alex.ar...@gmail.com
---
 common/resource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/resource.c b/common/resource.c
index fe4680e..1ea2a75 100644
--- a/common/resource.c
+++ b/common/resource.c
@@ -71,7 +71,7 @@ struct resource *__request_region(struct resource *parent,
goto ok;
if (start  r-end)
continue;
-   debug(%s: 0x%08llx:0x%08llx conflicts with 
0x%08llx:0x%08llx\n,
+   pr_warn(%s: 0x%08llx:0x%08llx conflicts with 
0x%08llx:0x%08llx\n,
__func__,
(unsigned long long)start,
(unsigned long long)end,
-- 
2.0.0


___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox