Re: [PATCH 09/10] beautify PHY driver names

[Sascha Hauer]

On Fri, May 30, 2014 at 11:07:35AM +0200, Holger Schurig wrote:
 Some device names where texts like Atheros 8035 ethernet or similar. They
 now got a prefix phy- and just their name and look now much more like the
 other driver names.

The names are the same as in the Linux Kernel. We could change them, but
probably get the Linux names back for new additions of phys. So let's
just keep the Linux Names.

Sascha

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 09/10] beautify PHY driver names

[Holger Schurig]

Some device names where texts like Atheros 8035 ethernet or similar. They
now got a prefix phy- and just their name and look now much more like the
other driver names.

Signed-off-by: Holger Schurig holgerschu...@gmail.com
---
 drivers/net/phy/at803x.c   |6 +++---
 drivers/net/phy/lxt.c  |2 +-
 drivers/net/phy/micrel.c   |   18 +-
 drivers/net/phy/national.c |2 +-
 drivers/net/phy/phy.c  |2 +-
 drivers/net/phy/smsc.c |   10 +-
 6 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index a244c87..a7b3ece 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -88,7 +88,7 @@ static struct phy_driver at803x_driver[] = {
/* ATHEROS 8035 */
.phy_id = 0x004dd072,
.phy_id_mask= 0xffef,
-   .drv.name   = Atheros 8035 ethernet,
+   .drv.name   = phy-ath8035,
.config_init= at803x_config_init,
.features   = PHY_GBIT_FEATURES,
.config_aneg= genphy_config_aneg,
@@ -97,7 +97,7 @@ static struct phy_driver at803x_driver[] = {
/* ATHEROS 8030 */
.phy_id = 0x004dd076,
.phy_id_mask= 0xffef,
-   .drv.name   = Atheros 8030 ethernet,
+   .drv.name   = phy-ath8030,
.config_init= at803x_config_init,
.features   = PHY_GBIT_FEATURES,
.config_aneg= genphy_config_aneg,
@@ -106,7 +106,7 @@ static struct phy_driver at803x_driver[] = {
/* ATHEROS 8031 */
.phy_id = 0x004dd074,
.phy_id_mask= 0xffef,
-   .drv.name   = Atheros 8031 ethernet,
+   .drv.name   = phy-ath8031,
.config_init= at803x_config_init,
.features   = PHY_GBIT_FEATURES,
.config_aneg= genphy_config_aneg,
diff --git a/drivers/net/phy/lxt.c b/drivers/net/phy/lxt.c
index 9e5ddbb..3ec5299 100644
--- a/drivers/net/phy/lxt.c
+++ b/drivers/net/phy/lxt.c
@@ -19,7 +19,7 @@ static struct phy_driver lxt97x_driver[] = {
 {
.phy_id = 0x001378e0,
.phy_id_mask= 0xfff0,
-   .drv.name   = LXT971,
+   .drv.name   = phy-lxt971,
.features   = PHY_BASIC_FEATURES,
 } };
 
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 8aea653..cf4ee77 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -191,7 +191,7 @@ static struct phy_driver ksphy_driver[] = {
 {
.phy_id = PHY_ID_KS8737,
.phy_id_mask= 0x00f0,
-   .drv.name   = Micrel KS8737,
+   .drv.name   = phy-ks8737,
.features   = (PHY_BASIC_FEATURES | SUPPORTED_Pause),
.config_init= kszphy_config_init,
.config_aneg= genphy_config_aneg,
@@ -199,7 +199,7 @@ static struct phy_driver ksphy_driver[] = {
 }, {
.phy_id = PHY_ID_KSZ8021,
.phy_id_mask= 0x00ff,
-   .drv.name   = Micrel KSZ8021,
+   .drv.name   = phy-ksz8021,
.features   = (PHY_BASIC_FEATURES | SUPPORTED_Pause |
   SUPPORTED_Asym_Pause),
.config_init= ksz8021_config_init,
@@ -208,7 +208,7 @@ static struct phy_driver ksphy_driver[] = {
 }, {
.phy_id = PHY_ID_KSZ8031,
.phy_id_mask= 0x00ff,
-   .drv.name   = Micrel KSZ8031,
+   .drv.name   = phy-ksz8031,
.features   = (PHY_BASIC_FEATURES | SUPPORTED_Pause |
   SUPPORTED_Asym_Pause),
.config_init= ksz8021_config_init,
@@ -217,7 +217,7 @@ static struct phy_driver ksphy_driver[] = {
 }, {
.phy_id = PHY_ID_KSZ8041,
.phy_id_mask= 0x00f0,
-   .drv.name   = Micrel KSZ8041,
+   .drv.name   = phy-ksz8041,
.features   = (PHY_BASIC_FEATURES | SUPPORTED_Pause
| SUPPORTED_Asym_Pause),
.config_init= kszphy_config_init,
@@ -226,7 +226,7 @@ static struct phy_driver ksphy_driver[] = {
 }, {
.phy_id = PHY_ID_KSZ8051,
.phy_id_mask= 0x00f0,
-   .drv.name   = Micrel KSZ8051,
+   .drv.name   = phy-ksz8051,
.features   = (PHY_BASIC_FEATURES | SUPPORTED_Pause
| SUPPORTED_Asym_Pause),
.config_init= ks8051_config_init,
@@ -234,7 +234,7 @@ static struct phy_driver ksphy_driver[] = {
.read_status= genphy_read_status,
 }, {
.phy_id = PHY_ID_KSZ8001,
-   .drv.name   = Micrel KSZ8001 or KS8721,
+   .drv.name   = phy-ksz8001-ks8721,
.phy_id_mask= 0x00ff,
.features   = (PHY_BASIC_FEATURES | SUPPORTED_Pause),
.config_init= kszphy_config_init,
@@ -248,7 +248,7 @@ static struct phy_driver ksphy_driver[] = {
 */
.phy_id = PHY_ID_KSZ9021,
.phy_id_mask= 0x000e,
-   

Re: [PATCH 09/10] beautify PHY driver names

[Alexander Aring]

Hi,

On Fri, May 30, 2014 at 11:07:35AM +0200, Holger Schurig wrote:
 Some device names where texts like Atheros 8035 ethernet or similar. They
 now got a prefix phy- and just their name and look now much more like the
 other driver names.


these names are taken from linux kernel code to have a similar name
convention like linux in barebox.

I would leave the names like linux. Maybe you get a name prefix into the
linux kernel, then we should change it in barebox also.

If you want to try that I wish you good luck. :-)

- Alex

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 09/10] beautify PHY driver names

[Holger Schurig]

I changed them because (before my patches) the driver list in
devinfo looked ugly, with my drvinfo command that one looked ugly.
Those driver names sticked out like a sore thumb.

Now, if I do diff linux/driver/net/phy/micrel.c
barebox/driver/net/phy/micrel.c, I can see that those files are a bit
similar ... but only a bit. Diff spits out 569 lines of diff output.
And as micrel.c is only 281 lines long, this means that almost no
identical lines are in those two files anyway ...so, the drivers
are following the Linux model, but they are not Linux drivers anyway.

As this is purely cosmetical, I won't fight over it. Or at least not more :-)

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox