Re: [PATCH 4/4] ARM: tqma53: call SoC lowlevel function early

[Eric Bénard]

Hi Sacha,

Le Wed,  3 Apr 2013 09:09:40 +0200,
Sascha Hauer  a écrit :

> With CONFIG_MMU_EARLY enabled the board does not survive the call
> to imx53_init_lowlevel(). This should not happen, but the reasons
> are currently unknown. This works on other boards like the i.MX53
> QSB.
> This patch moves the call to imx53_init_lowlevel to
> barebox_arm_reset_vector() which is executed with MMU disabled.
> 
FWIW : on the QSB I also met this kind of problem :
- when the board is configured for serial download boot (bootmode 0
  & 1 = 1) : barebox fails to execute if MMU is enabled
- when the board is configured for usual SDCard boot and the SDCard is
  not inserted, the bootrom falls back to serial download mode and
  then barebox runs fine even with MMU enabled.

Best regards,
Eric

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 4/4] ARM: tqma53: call SoC lowlevel function early

[Sascha Hauer]

With CONFIG_MMU_EARLY enabled the board does not survive the call
to imx53_init_lowlevel(). This should not happen, but the reasons
are currently unknown. This works on other boards like the i.MX53
QSB.
This patch moves the call to imx53_init_lowlevel to
barebox_arm_reset_vector() which is executed with MMU disabled.

Signed-off-by: Sascha Hauer 
---
 arch/arm/boards/tqma53/board.c| 1 -
 arch/arm/boards/tqma53/lowlevel.c | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boards/tqma53/board.c b/arch/arm/boards/tqma53/board.c
index 03cb8ea..432f29f 100644
--- a/arch/arm/boards/tqma53/board.c
+++ b/arch/arm/boards/tqma53/board.c
@@ -253,7 +253,6 @@ late_initcall(tqma53_part_init);
 static int tqma53_console_init(void)
 {
mxc_iomux_v3_setup_multiple_pads(tqma53_pads, ARRAY_SIZE(tqma53_pads));
-   imx53_init_lowlevel(800);
imx53_add_uart0();
 
return 0;
diff --git a/arch/arm/boards/tqma53/lowlevel.c 
b/arch/arm/boards/tqma53/lowlevel.c
index 60c28f7..a6eaa46 100644
--- a/arch/arm/boards/tqma53/lowlevel.c
+++ b/arch/arm/boards/tqma53/lowlevel.c
@@ -1,9 +1,11 @@
 #include 
 #include 
 #include 
+#include 
 
 void __naked barebox_arm_reset_vector(void)
 {
arm_cpu_lowlevel_init();
+   imx53_init_lowlevel_early(800);
imx53_barebox_entry(0);
 }
-- 
1.8.2.rc2


___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox