Re: [PATCH v2 2/7] ARM: uemd: add DEBUG_LL support

[Holger Schurig]

Oops, you're of course right!

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH v2 2/7] ARM: uemd: add DEBUG_LL support

[Antony Pavlov]

On Fri, 30 May 2014 08:09:21 +0200
Holger Schurig  wrote:

> 2014-05-22 21:48 GMT+02:00 Antony Pavlov :
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -203,6 +203,7 @@ config ARCH_UEMD
> > select OFDEVICE
> > select OFTREE
> > select CLOCKSOURCE_UEMD
> > +   select HAS_DEBUG_LL
> 
> Why not putting this into the _defconfig?

I suppose you are mixing up HAS_DEBUG_LL with DEBUG_LL.

DEBUG_LL depends on HAS_DEBUG_LL. If HAS_DEBUG_LL=y then DEBUG_LL can be 
enabled or DEBUG_LL can be disabled.
So you have no chance to use DEBUG_LL without HAS_DEBUG_LL=y!

If you want to enable HAS_DEBUG_LL you have to explicitly select it in a 
Kconfig file.
You can't use just _defconfig for HAS_DEBUG_LL enabling.

> (On my device, it's neither in defconfig nor in Kconfig, I only had it
> on in the initial "bring it to live" period. Afterwards I turned it
> off)


-- 
-- 
Best regards,
  Antony Pavlov

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH v2 2/7] ARM: uemd: add DEBUG_LL support

[Holger Schurig]

2014-05-22 21:48 GMT+02:00 Antony Pavlov :
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -203,6 +203,7 @@ config ARCH_UEMD
> select OFDEVICE
> select OFTREE
> select CLOCKSOURCE_UEMD
> +   select HAS_DEBUG_LL

Why not putting this into the _defconfig?

(On my device, it's neither in defconfig nor in Kconfig, I only had it
on in the initial "bring it to live" period. Afterwards I turned it
off)

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH v2 2/7] ARM: uemd: add DEBUG_LL support

[Antony Pavlov]

Signed-off-by: Antony Pavlov 
---
 arch/arm/Kconfig   |  1 +
 arch/arm/mach-uemd/include/mach/debug_ll.h | 42 ++
 2 files changed, 43 insertions(+)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 81ee19b..c236a9e 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -203,6 +203,7 @@ config ARCH_UEMD
select OFDEVICE
select OFTREE
select CLOCKSOURCE_UEMD
+   select HAS_DEBUG_LL
 
 config ARCH_ZYNQ
bool "Xilinx Zynq-based boards"
diff --git a/arch/arm/mach-uemd/include/mach/debug_ll.h 
b/arch/arm/mach-uemd/include/mach/debug_ll.h
new file mode 100644
index 000..ce18244
--- /dev/null
+++ b/arch/arm/mach-uemd/include/mach/debug_ll.h
@@ -0,0 +1,42 @@
+/*
+ * Copyright (C) 2014 Antony Pavlov 
+ *
+ * This file is part of barebox.
+ * See file CREDITS for list of people who contributed to this project.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ */
+
+/** @file
+ *  This File contains declaration for early output support
+ */
+#ifndef __INCLUDE_ARCH_DEBUG_LL_H__
+#define __INCLUDE_ARCH_DEBUG_LL_H__
+
+#include 
+#include 
+
+#define DEBUG_LL_UART_ADDR UEMD_UART0_BASE
+#define DEBUG_LL_UART_RSHFT2
+
+#define rbr(0 << DEBUG_LL_UART_RSHFT)
+#define lsr(5 << DEBUG_LL_UART_RSHFT)
+#define LSR_THRE   0x20/* Xmit holding register empty */
+
+static inline void PUTC_LL(char ch)
+{
+   while (!(__raw_readb(DEBUG_LL_UART_ADDR + lsr) & LSR_THRE))
+   ;
+
+   __raw_writeb(ch, DEBUG_LL_UART_ADDR + rbr);
+}
+
+#endif /* __INCLUDE_ARCH_DEBUG_LL_H__ */
-- 
1.9.2


___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox