Re: [PATCH v2 0/7] RATP i2c and GPIO support
On Wed, Sep 12, 2018 at 03:45:43PM +0200, Aleksander Morgado wrote: > This series of patches implements support for i2c and GPIO operations via > RATP. > > It addresses most of the comments from the first series review, except for > Sascha's suggestion to implement name resolving for the i2c buses and > Andrey's suggestion to prepare a new helper method to initialize the > i2c_client structure. I already have a patch for the latter, but will send it > for review once these have been accepted and merged, as it's really a bit > orthogonal to the whole RATP logic. > > Another different w.r.t. v1 apart from addressing the comments is the review > is that I made the RATP i2c support depend on CONFIG_I2C and the RATP GPIO > support on CONFIG_GENERIC_GPIO. That was missing, and was breaking build if > RATP was selected but no i2c or GPIO support was included in the build. > > Comments welcome! > > Aleksander Morgado (7): > ratp: implement i2c read/write support > bbremote: implement i2c read/write support > ratp: implement support for GPIO commands > bbremote: implement support for GPIO operations > ratp: use __packed instead of the full form > ratp: use pr_ macros to print messages > ratp: fix incorrect whitespaces in method calls Applied, thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH v2 0/7] RATP i2c and GPIO support
This series of patches implements support for i2c and GPIO operations via RATP. It addresses most of the comments from the first series review, except for Sascha's suggestion to implement name resolving for the i2c buses and Andrey's suggestion to prepare a new helper method to initialize the i2c_client structure. I already have a patch for the latter, but will send it for review once these have been accepted and merged, as it's really a bit orthogonal to the whole RATP logic. Another different w.r.t. v1 apart from addressing the comments is the review is that I made the RATP i2c support depend on CONFIG_I2C and the RATP GPIO support on CONFIG_GENERIC_GPIO. That was missing, and was breaking build if RATP was selected but no i2c or GPIO support was included in the build. Comments welcome! Aleksander Morgado (7): ratp: implement i2c read/write support bbremote: implement i2c read/write support ratp: implement support for GPIO commands bbremote: implement support for GPIO operations ratp: use __packed instead of the full form ratp: use pr_ macros to print messages ratp: fix incorrect whitespaces in method calls common/ratp/Kconfig | 15 ++ common/ratp/Makefile | 2 + common/ratp/getenv.c | 12 +- common/ratp/gpio.c | 144 ++ common/ratp/i2c.c| 284 +++ common/ratp/md.c | 24 +-- common/ratp/mw.c | 24 +-- common/ratp/reset.c | 10 +- include/ratp_bb.h| 10 ++ scripts/remote/controller.py | 60 scripts/remote/main.py | 74 + scripts/remote/messages.py | 179 ++ 12 files changed, 806 insertions(+), 32 deletions(-) create mode 100644 common/ratp/gpio.c create mode 100644 common/ratp/i2c.c -- 2.19.0 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
RATP i2c and GPIO support
This patch series implements support for i2c and GPIO operations via RATP. [PATCH 1/4] ratp: implement i2c read/write support [PATCH 2/4] bbremote: implement i2c read/write support [PATCH 3/4] ratp: implement support for GPIO commands [PATCH 4/4] bbremote: implement support for GPIO operations ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
