Re: [PATCH 1/3 for next] AM33xx: Cleanup of lowlevel code
On Fri, 2013-08-23 at 09:00 +0200, Teresa Gámez wrote: > There is a lot of duplicate lowlevel code between the > am33xx boards. Move this code to am33xx_generic and > create structs for sdram settings. > > Signed-off-by: Teresa Gámez Just for comparison, the current u-boot mainline does something similar: http://git.denx.de/?p=u-boot.git;a=blob;f=arch/arm/include/asm/arch-am33xx/ddr_defs.h;hb=HEAD -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 1/3 for next] AM33xx: Cleanup of lowlevel code
Am 26.08.2013 08:49, schrieb Sascha Hauer: Hi Teresa, On Fri, Aug 23, 2013 at 09:00:20AM +0200, Teresa Gámez wrote: There is a lot of duplicate lowlevel code between the am33xx boards. Move this code to am33xx_generic and create structs for sdram settings. I'm mostly fine with this series. I made some small changes to it and rebased my beaglebone black series ontop of it. I'm about to repost the my series which includes your changed patches. It would be good if you could have a look. Beside of the missing inlcude everything looks fine. Thanks. Teresa Sascha ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 1/3 for next] AM33xx: Cleanup of lowlevel code
Hi Teresa, On Fri, Aug 23, 2013 at 09:00:20AM +0200, Teresa Gámez wrote: > There is a lot of duplicate lowlevel code between the > am33xx boards. Move this code to am33xx_generic and > create structs for sdram settings. I'm mostly fine with this series. I made some small changes to it and rebased my beaglebone black series ontop of it. I'm about to repost the my series which includes your changed patches. It would be good if you could have a look. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
