Re: org-bbdb-anniversaries gives error 'bad sexp'

2011-05-16 Thread Matt Lundin
Roland Winkler wink...@gnu.org writes:

 On Sun May 15 2011 Matt Lundin wrote:
 I'd be happy to take this on. AFAICT, there are three functions in
 org-bbdb that no longer exist in bbdb v3.
 
 bbdb-name
 bbdb-company
 bbdb-record-getprop
 
 The first two can easily be defaliased to bbdb-search-organization and
 bbdb-search-name. (For a while, we should probably support bbdb v2 and
 v3 simultaneously.)

 Things might be a bit more subtle. The new organization field is
 a list, not a single string.

Thanks. That's good to know. AFAICT, bbdb-search-organization already
accommodates for this fact. That is, if you give it a regexp, it will
return all records matching the regexp in the organization field. Since
org-bbdb calls bbdb-company with a string as an argument, wouldn't a
defalias be sufficient for the time being?

 The other major change that breaks compatibility is the order of the
 parameters in bbdb-split. It has been reversed in the new bbdb: i.e.,
 one used to call (bbdb-split string separator), whereas now one must
 call (bbdb-split separator string). Is there a compelling reason to
 change this order in the new bbdb?

 The change is not only with respect to the order of arguments that
 could be reverted in BBDB v3. More importantly, I tried to get rid
 of hard-coded separators. Most often the separator arg is now the
 name of the field that is split. Then the actual separator is looked
 up in bbdb-separator-alist. While I do not know yet a good strategy
 for the upgrade of org-mode's BBDB interface, I'd find it
 unfortunate if such a feature was lost in org-mode to preserve
 backward compatibility.

Thanks for the explanation. For the time being, I'll add a workaround to
accommodate both versions.

Best,
Matt

--
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: org-bbdb-anniversaries gives error 'bad sexp'

2011-05-16 Thread Matt Lundin
Leo sdl@gmail.com writes:

 On 2011-05-16 00:58 +0800, Matt Lundin wrote:
 I'd be happy to take this on. AFAICT, there are three functions in
 org-bbdb that no longer exist in bbdb v3.

 If you want you can build on top of my version. The anniversaries is
 still broken since I don't use BBDB-anniv.el. The rest works well for
 the past few weeks.

Thanks Leo! This is very helpful.

I have anniversaries working in my own setup, so between the two sets of
modifications, I should be able to provide a full set of fixes. More
soon...

Best,
Matt

--
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


conditionally compile VM

2011-05-16 Thread Sam Steingold

2011-05-16  Sam Steingold  s...@gnu.org

* Makefile (all): depend on vm only if VMDIR exists

iff --git a/lisp/Makefile b/lisp/Makefile
index 5829cf3..b383f1d 100644
--- a/lisp/Makefile
+++ b/lisp/Makefile
@@ -61,7 +59,13 @@ DEPBINS= ${DEPSRCS:.el=.elc}
 SRCS=  bbdb.el  $(DEPSRCS)
 BINS=  bbdb.elc $(DEPBINS)
 
-all: Makefile bbdb autoloadsc vm
+ALL = Makefile bbdb autoloadsc
+
+ifneq ($(wildcard $(VMDIR)),)
+ALL = $(ALL) vm
+endif
+
+all: $(ALL)
 
 # Makefile: Makefile.in
 #  @echo Makefile.in has changed, rerun configure!

-- 
Sam Steingold (http://sds.podval.org/) on CentOS release 5.6 (Final) X 
11.0.60900031
http://palestinefacts.org http://iris.org.il http://mideasttruth.com
http://camera.org http://dhimmi.com http://thereligionofpeace.com
Warning! Dates in calendar are closer than they appear!


--
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: conditionally compile VM

2011-05-16 Thread Antoine Levitt
16/05/11 16:12, Sam Steingold
 2011-05-16  Sam Steingold  s...@gnu.org

   * Makefile (all): depend on vm only if VMDIR exists

 iff --git a/lisp/Makefile b/lisp/Makefile
 index 5829cf3..b383f1d 100644
 --- a/lisp/Makefile
 +++ b/lisp/Makefile
 @@ -61,7 +59,13 @@ DEPBINS=   ${DEPSRCS:.el=.elc}
  SRCS=bbdb.el  $(DEPSRCS)
  BINS=bbdb.elc $(DEPBINS)
  
 -all: Makefile bbdb autoloadsc vm
 +ALL = Makefile bbdb autoloadsc
 +
 +ifneq ($(wildcard $(VMDIR)),)
 +ALL = $(ALL) vm
 +endif
 +
 +all: $(ALL)
  
  # Makefile: Makefile.in
  #@echo Makefile.in has changed, rerun configure!

That seems useful, so people who don't use VM don't have to change the
rule manually. Might also be a good idea to remove the default value for
VMDIR (the way it is now, it's unlikely to be of much use to anyone, and
people who don't use VM have to remove the line manually), or to figure
out a way to get it automatically.

Also, while on the subject of makefiles, could somebody add an install
rule? (I'm not sure what the standard directory for .el/.elc files is, I
put mine in /usr/local/share/emacs/site-lisp/)


--
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/