Re: typos
On Fri Sep 23 2011 Reiner Steib wrote: > On Thu, Sep 22 2011, Roland Winkler wrote: > > > 2011-09-22 Leo > > * lisp/bbdb.el (bbdb-pop-up-window): Remove Gnus-specific code > > GNUS > > > which is not required anymore by recent versions of Gnus. > > The original version written by Masanobu UMEDA was called "GNUS" (all > uppercase), see (info "(gnus)History"). I can well imagine that the relevant code in BBDB stems from very old days. Nonetheless, BBDB v2.35 (my limit of looking into the history of BBDB, its file bbdb.el has as most recent copyright statement "1994") claimed it wanted to make "gnus" happy with this fragment of code. Software historians should feel free to dig further in the past. -- I am glad this piece of code is gone. Roland -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2dcopy2 ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: typos
On Thu, Sep 22 2011, Roland Winkler wrote: > 2011-09-22 Leo > * lisp/bbdb.el (bbdb-pop-up-window): Remove Gnus-specific code GNUS > which is not required anymore by recent versions of Gnus. The original version written by Masanobu UMEDA was called "GNUS" (all uppercase), see (info "(gnus)History"). ,[ (info "(gnus)History") ] | 10.2 History | | | GNUS was written by Masanobu UMEDA. When autumn crept up in '94, Lars | Magne Ingebrigtsen grew bored and decided to rewrite Gnus. ` Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2dcopy2 ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: typos
On Thu Sep 22 2011 Leo wrote: > I propose this patch: Done. 2011-09-22 Leo * lisp/bbdb.el (bbdb-pop-up-window): Remove Gnus-specific code which is not required anymore by recent versions of Gnus. -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: typos
On 2011-09-22 17:02 +0800, Roland Winkler wrote: [snipped 5 lines] > I am sorry, you have confused me. Which patch are you ultimately > proposing? > > As I mentioned before on this list, I do not know very much about > Gnus internals. So up to now I haven't done much to clean up / > update BBDB's Gnus interface. If anyone more knowledgeable than > myself could look into this, that would be great. > > Roland BTW, I guess gnus-Group-mode gnus-Subject-mode gnus-Article-mode were names used in the original GNUS i.e. before Lars rewrote it. They are no longer used. I propose this patch: commit ea095835e8970811f71eb617147206ba14916ab6 Date: Thu Sep 22 08:53:25 2011 +0800 Remove erroneous and useless gnus code in bbdb-pop-up-window --- lisp/bbdb.el |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) Modified lisp/bbdb.el diff --git a/lisp/bbdb.el b/lisp/bbdb.el index afc102e9..087c9191 100644 --- a/lisp/bbdb.el +++ b/lisp/bbdb.el @@ -2608,9 +2608,6 @@ (defun bbdb-pop-up-window (&optional select horiz-p) (max window-min-height bbdb-pop-up-window-size)) (round (* bbdb-pop-up-window-size (window-height tallest-window) - (if (memq major-mode - '(gnus-Group-mode gnus-Subject-mode gnus-Article-mode)) - (goto-char (point-min))) ; make gnus happy... (select-window (next-window)) ; goto the bottom of the two... (let (pop-up-windows) ; make it display *BBDB*... (switch-to-buffer (get-buffer-create bbdb-buffer-name -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: typos
On Thu Sep 22 2011 Leo wrote: > But having looked at this some more, I think instead of fixing the > typos, the form should be deleted. It causes annoying point movement > from my experience. Any idea in what way it makes Gnus happy?? I am sorry, you have confused me. Which patch are you ultimately proposing? As I mentioned before on this list, I do not know very much about Gnus internals. So up to now I haven't done much to clean up / update BBDB's Gnus interface. If anyone more knowledgeable than myself could look into this, that would be great. Roland -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: Typos in docs for bbdb/vm-set-auto-folder-alist
On , June 11, 2002 at 19:37:49, Thomas Reuben wrote: > I've reported these typos before; one other which I reported at the > same time was fixed, but as of 2.34, not the others: > > fist -> first > parsed -> passed > "do his own tweaks" What does this mean? > > The paragraph in which these three mistakes occur needs a blank line > before it, too. The current version is like this, is it o.k. for you? (defun bbdb/vm-set-auto-folder-alist () "Create a `vm-auto-folder-alist' according to the records in the bbdb. For each record that has a 'vm-folder' attribute, add an \(email-regexp . folder) element to the `vm-auto-folder-alist'. The element gets added to the 'element-name' sublist of the `vm-auto-folder-alist'. The car of the element consists of all the email addresses for the bbdb record concatenated with OR; the cdr is the value of the vm-folder attribute. If the first character of vm-folders value is a quote (') it will be parsed as lisp expression and is evaluated to return a folder name." ___ Sponsored by: ThinkGeek at http://www.ThinkGeek.com/ ___ [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/