[PATCH] b43legacy: Fix potential return of uninitialized variable
Using the Coverity checker, Adrian Bunk found that routine b43legacy_start could return an unitialized variable. This patch fixes the problem. Signed-off-by: Larry Finger <[EMAIL PROTECTED]> --- John, This patch is intended for the everything branch of wireless-2.6. Larry --- drivers/net/wireless/b43legacy/main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: wireless-2.6/drivers/net/wireless/b43legacy/main.c === --- wireless-2.6.orig/drivers/net/wireless/b43legacy/main.c +++ wireless-2.6/drivers/net/wireless/b43legacy/main.c @@ -3237,7 +3237,7 @@ static int b43legacy_start(struct ieee80 struct b43legacy_wl *wl = hw_to_b43legacy_wl(hw); struct b43legacy_wldev *dev = wl->current_dev; int did_init = 0; - int err; + int err = 0; mutex_lock(&wl->mutex); ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: b43: regression on bcm4318
On Sat, 2007-10-13 at 18:14 +0400, Vitaly Bordug wrote:
> Another question: is this driver known to work okay in ad-hoc or master mode?
> I gave it a try and there is no
> driver-side whine, but it does not seem to work either. I see couple of
> packages turnaround, sometimes even
> dhcp server is able to feed IP via wlan (host is acting as kinda AP), but
> nothing after that.
b43 works in master mode with all my hostapd enablement patches
(johannes.sipsolutions.net/patches/{hostap,kernel}
johannes
signature.asc
Description: This is a digitally signed message part
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: b43 with upstream-davem stacktrace
On Sat, 2007-10-13 at 17:26 +0200, Michael Buesch wrote: > I also saw this sometimes, but I have absolutely no idea how that happens. > Someone any idea? Nope, but adding more CCs :) I briefly looked at the code and couldn't track it. Got a powerpc oops with disassembly? > > b43-phy0 debug: Loading firmware version 351.126 (2006-07-29 05:54:02) > > Registered led device: b43-phy0:tx > > Registered led device: b43-phy0:rx > > general protection fault: [1] SMP > > CPU 0 > > Modules linked in: eeprom ircomm_tty ircomm af_packet snd_pcm_oss > > snd_mixer_oss snd_seq snd_seq_device radeon drm cpufreq_conservative > > cpufreq_userspace cpufreq _powersave powernow_k8 pcmcia snd_atiixp_modem > > arc4 snd_atiixp ecb blkcipher rc8 0211_simple snd_ac97_codec yenta_socket > > ac97_bus snd_pcm rsrc_nonstatic snd_time r snd pcmcia_core b43 > > firmware_class parport_pc ohci1394 ide_cd ssb rfkill mac80 211 rtc_cmos > > irda crc_ccitt rtc_core k8temp rtc_lib cfg80211 led_class tifm_7xx1 output > > battery ac parport ieee1394 button cdrom tifm_core container soundcore s > > nd_page_alloc tg3 hwmon joydev input_polldev i2c_piix4 serio_raw ide_disk > > ehci_h cd ohci_hcd usbcore radeonfb fb_ddc i2c_algo_bit i2c_core edd ext3 > > mbcache jbd f an atiixp ide_core thermal processor > > Pid: 2295, comm: NetworkManager Not tainted 2.6.23-rc9-default #1 > > RIP: 0010:[] [] strcmp+0x0/0x1a > > RSP: 0018:810078fe5740 EFLAGS: 00010283 > > RAX: 81007d1f5f70 RBX: 81007d1f5f40 RCX: 80418988 > > RDX: 881ed3d0 RSI: 8048498b RDI: 66355f306e616c77 > > RBP: 81007da723a8 R08: R09: > > R10: 881ed3a0 R11: 803921b5 R12: 81007da72000 > > R13: 0001 R14: R15: 66355f306e616c77 > > FS: 40800950(0063) GS:804fc000() > > knlGS: CS: 0010 DS: ES: CR0: 80050033 > > CR2: 00616278 CR3: 79556000 CR4: 06e0 > > DR0: DR1: DR2: > > DR3: DR6: 0ff0 DR7: 0400 > > Process NetworkManager (pid: 2295, threadinfo 810078fe4000, task > > 810079f be040) > > Stack: 803861f8 81007da723a8 81007da723a8 > > 881ec218 81007da72000 81007da7240a 81007da723a0 > > 882da4ba 810078fe57f8 81007d5802e0 > > Call Trace: > > [] led_trigger_set_default+0x3a/0x77 > > [] :led_class:led_classdev_register+0xb9/0x10d > > [] :b43:b43_register_led+0x83/0xb6 > > [] :b43:b43_leds_init+0x263/0x293 > > [] :ssb:ssb_pci_switch_core+0x40/0x4b > > [] :b43:b43_chip_init+0x56c/0x8d6 > > [] :b43:b43_wireless_core_init+0x284/0x766 > > [] :b43:b43_start+0x2e/0x6d > > [] :mac80211:ieee80211_open+0x1b6/0x39d > > [] dev_open+0x2f/0x67 > > [] dev_change_flags+0xaa/0x161 > > [] do_setlink+0x279/0x34b > > [] rtnetlink_rcv_msg+0x0/0x1dc > > [] rtnl_setlink+0xf5/0x116 > > [] netlink_run_queue+0x68/0xf7 > > [] rtnetlink_rcv+0x28/0x43 > > [] netlink_data_ready+0x12/0x50 > > [] netlink_sendskb+0x23/0x3c > > [] netlink_sendmsg+0x2ac/0x2bf > > [] memcpy_fromiovec+0x36/0x66 > > [] sock_sendmsg+0xea/0x107 > > [] autoremove_wake_function+0x0/0x2e > > [] autoremove_wake_function+0x0/0x2e > > [] autoremove_wake_function+0x0/0x2e > > [] sys_sendmsg+0x217/0x28a > > [] netlink_insert+0x13c/0x14b > > [] sys_getsockname+0x9c/0xb2 > > [] system_call+0x7e/0x83 > > > > > > Code: 8a 17 88 d0 2a 06 48 ff c6 84 c0 75 09 84 d2 74 05 48 ff c7 > > RIP [] strcmp+0x0/0x1a > > RSP > > (none):~ # > signature.asc Description: This is a digitally signed message part ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] ssb: Fix regression in 2.6.23-git3 due to change in calling add_uevent_var
On Sunday 14 October 2007 06:46:47 Larry Finger wrote:
> In commit 7eff2e7a8b65c25920207324e56611150eb1cd9a, the calling sequence
> for add_uevent_var was changed, but the ssb driver was not modified, which
> leads to a "Unable to handle kernel paging request" oops. This patch fixes
> the problem.
>
> Signed-off-by: Larry Finger <[EMAIL PROTECTED]>
Acked-by: Michael Buesch <[EMAIL PROTECTED]>
> ---
>
> drivers/ssb/main.c | 11 +++
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> Index: linux-2.6/drivers/ssb/main.c
> ===
> --- linux-2.6.orig/drivers/ssb/main.c
> +++ linux-2.6/drivers/ssb/main.c
> @@ -320,22 +320,17 @@ static int ssb_bus_match(struct device *
> return 0;
> }
>
> -static int ssb_device_uevent(struct device *dev, char **envp, int num_envp,
> - char *buffer, int buffer_size)
> +static int ssb_device_uevent(struct device *dev, struct kobj_uevent_env *env)
> {
> struct ssb_device *ssb_dev = dev_to_ssb_dev(dev);
> - int ret, i = 0, length = 0;
> + int ret;
>
> if (!dev)
> return -ENODEV;
>
> - ret = add_uevent_var(envp, num_envp, &i,
> - buffer, buffer_size, &length,
> - "MODALIAS=ssb:v%04Xid%04Xrev%02X",
> + ret = add_uevent_var(env, "MODALIAS=ssb:v%04Xid%04Xrev%02X",
>ssb_dev->id.vendor, ssb_dev->id.coreid,
>ssb_dev->id.revision);
> - envp[i] = NULL;
> -
> return ret;
> }
>
>
>
--
Greetings Michael.
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
