Re: Change error message for failed rc module
Michael Buesch wrote: > On Saturday 27 October 2007 23:56:39 evan foss wrote: > >> ssb: Core 0 found: ChipCommon (cc 0x800, rev 0x11, vendor 0x4243) >> ssb: Core 1 found: IEEE 802.11 (cc 0x812, rev 0x0A, vendor 0x4243) >> ssb: Core 2 found: USB 1.1 Host (cc 0x817, rev 0x03, vendor 0x4243) >> ssb: Core 3 found: PCI-E (cc 0x820, rev 0x01, vendor 0x4243) >> ssb: Sonics Silicon Backplane found on PCI device :01:00.0 >> b43-phy1: Broadcom 4311 WLAN found >> b43-phy1 debug: Found PHY: Analog 4, Type 2, Revision 8 >> b43-phy1 debug: Found Radio: Manuf 0x17F, Version 0x2050, Revision 2 >> phy1: Failed to select rate control algorithm >> phy1: Failed to initialize rate control algorithm >> b43: probe of ssb0:0 failed with error -2 > > That's not a ssb or b43 bug. > Please compile and load rc80211_simple. > > I think we should change this error message, as obviously people don't > understand that the issue is a failed module request for the rc module. > Maybe add another message like "Please install a mac80211 rate control module, > such as rc80211_simple" if the error code is -ENOENT (-2) > Another suggestion? Your suggestion looks good to me. Larry ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Change error message for failed rc module (was: possible bug in ssb/b43)
On Saturday 27 October 2007 23:56:39 evan foss wrote: > ssb: Core 0 found: ChipCommon (cc 0x800, rev 0x11, vendor 0x4243) > ssb: Core 1 found: IEEE 802.11 (cc 0x812, rev 0x0A, vendor 0x4243) > ssb: Core 2 found: USB 1.1 Host (cc 0x817, rev 0x03, vendor 0x4243) > ssb: Core 3 found: PCI-E (cc 0x820, rev 0x01, vendor 0x4243) > ssb: Sonics Silicon Backplane found on PCI device :01:00.0 > b43-phy1: Broadcom 4311 WLAN found > b43-phy1 debug: Found PHY: Analog 4, Type 2, Revision 8 > b43-phy1 debug: Found Radio: Manuf 0x17F, Version 0x2050, Revision 2 > phy1: Failed to select rate control algorithm > phy1: Failed to initialize rate control algorithm > b43: probe of ssb0:0 failed with error -2 That's not a ssb or b43 bug. Please compile and load rc80211_simple. I think we should change this error message, as obviously people don't understand that the issue is a failed module request for the rc module. Maybe add another message like "Please install a mac80211 rate control module, such as rc80211_simple" if the error code is -ENOENT (-2) Another suggestion? -- Greetings Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
possible bug in ssb/b43
Hello all, After using bcm43xx for a long time (courtesy of Larry) on my compaq v3019us I though I would test the b43 so I go it from git last night. I used the current v4 firmware and the b43 driver seemed to load fine until it hit an error relating to ssb. I am using mac80211 not softmac and I tried the b43legacy with mac80211 as well all to the same effect. I tried the ssb initcall ordering patch that was just released with b43 again to no effect. My machine is a laptop with the bcm4311 version 1 the cpu is an amd turion 64 and it is running smp. Is there a 64 bit firmware I should be using? I configured the kernel exactly the same as I have in the past only with the new mac80211, b43, and rfkill switch supported as modules. Is this an SSB problem or an error in b43 and can someone please help me? I turned verbose on but it didn't help much. Below is a snippet of my dmesg output. ssb: Core 0 found: ChipCommon (cc 0x800, rev 0x11, vendor 0x4243) ssb: Core 1 found: IEEE 802.11 (cc 0x812, rev 0x0A, vendor 0x4243) ssb: Core 2 found: USB 1.1 Host (cc 0x817, rev 0x03, vendor 0x4243) ssb: Core 3 found: PCI-E (cc 0x820, rev 0x01, vendor 0x4243) ssb: Sonics Silicon Backplane found on PCI device :01:00.0 b43-phy1: Broadcom 4311 WLAN found b43-phy1 debug: Found PHY: Analog 4, Type 2, Revision 8 b43-phy1 debug: Found Radio: Manuf 0x17F, Version 0x2050, Revision 2 phy1: Failed to select rate control algorithm phy1: Failed to initialize rate control algorithm b43: probe of ssb0:0 failed with error -2 ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
[PATCH] ssb: Fix initcall ordering
ssb must init after PCI but before the ssb drivers.
Signed-off-by: Michael Buesch <[EMAIL PROTECTED]>
Cc: Christian Casteyde <[EMAIL PROTECTED]>
Fixes-bug: #9219
Index: wireless-2.6/drivers/ssb/main.c
===
--- wireless-2.6.orig/drivers/ssb/main.c2007-10-27 14:54:40.0
+0200
+++ wireless-2.6/drivers/ssb/main.c 2007-10-27 14:57:15.0 +0200
@@ -1147,7 +1147,10 @@ static int __init ssb_modinit(void)
return err;
}
-subsys_initcall(ssb_modinit);
+/* ssb must be initialized after PCI but before the ssb drivers.
+ * That means we must use some initcall between subsys_initcall
+ * and device_initcall. */
+fs_initcall(ssb_modinit);
static void __exit ssb_modexit(void)
{
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
[PATCH] ssb: Fix initcall ordering
ssb must init after PCI but before the ssb drivers.
Signed-off-by: Michael Buesch <[EMAIL PROTECTED]>
Cc: Christian Casteyde <[EMAIL PROTECTED]>
Fixes-bug: #9219
Index: wireless-2.6/drivers/ssb/main.c
===
--- wireless-2.6.orig/drivers/ssb/main.c2007-10-27 14:54:40.0
+0200
+++ wireless-2.6/drivers/ssb/main.c 2007-10-27 14:57:15.0 +0200
@@ -1147,7 +1147,10 @@ static int __init ssb_modinit(void)
return err;
}
-subsys_initcall(ssb_modinit);
+/* ssb must be initialized after PCI but before the ssb drivers.
+ * That means we must use some initcall between subsys_initcall
+ * and device_initcall. */
+fs_initcall(ssb_modinit);
static void __exit ssb_modexit(void)
{
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
[PATCH] b43: Fix Kconfig for built-in
This fixes the Kconfig for a built-in b43. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> --- Somebody please port this to b43legacy. Let's see if somebody starts to do the job. :) Index: wireless-2.6/drivers/net/wireless/b43/Kconfig === --- wireless-2.6.orig/drivers/net/wireless/b43/Kconfig 2007-10-27 13:28:16.0 +0200 +++ wireless-2.6/drivers/net/wireless/b43/Kconfig 2007-10-27 14:29:28.0 +0200 @@ -61,16 +61,18 @@ config B43_PCMCIA If unsure, say N. -# LED support +# This config option automatically enables b43 LEDS support, +# if it's possible. config B43_LEDS bool - depends on B43 && MAC80211_LEDS + depends on B43 && MAC80211_LEDS && (LEDS_CLASS = y || LEDS_CLASS = B43) default y -# RFKILL support +# This config option automatically enables b43 RFKILL support, +# if it's possible. config B43_RFKILL bool - depends on B43 && RFKILL && RFKILL_INPUT && INPUT_POLLDEV + depends on B43 && (RFKILL = y || RFKILL = B43) && RFKILL_INPUT && (INPUT_POLLDEV = y || INPUT_POLLDEV = B43) default y config B43_DEBUG ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
