[PATCH] b43: include FCS in frames handed to mac80211
From: Johannes Berg <[EMAIL PROTECTED]>
Sometimes it can be useful to see the FCS, especially when
bad-FCS frames are shown. Pass the FCS to mac80211 and let
it worry about snipping it off when required.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
Signed-off-by: Michael Buesch <[EMAIL PROTECTED]>
---
drivers/net/wireless/b43/main.c |3 ++-
drivers/net/wireless/b43/xmit.c |1 -
2 files changed, 2 insertions(+), 2 deletions(-)
--- everything.orig/drivers/net/wireless/b43/main.c 2007-11-22
23:35:41.208716199 +0100
+++ everything/drivers/net/wireless/b43/main.c 2007-11-22 23:36:03.138677951
+0100
@@ -4158,7 +4158,8 @@ static int b43_wireless_init(struct ssb_
}
/* fill hw info */
- hw->flags = IEEE80211_HW_HOST_GEN_BEACON_TEMPLATE;
+ hw->flags = IEEE80211_HW_HOST_GEN_BEACON_TEMPLATE |
+ IEEE80211_HW_RX_INCLUDES_FCS;
hw->max_signal = 100;
hw->max_rssi = -110;
hw->max_noise = -110;
--- everything.orig/drivers/net/wireless/b43/xmit.c 2007-11-22
23:36:05.668676810 +0100
+++ everything/drivers/net/wireless/b43/xmit.c 2007-11-22 23:36:22.668677190
+0100
@@ -489,7 +489,6 @@ void b43_rx(struct b43_wldev *dev, struc
}
wlhdr = (struct ieee80211_hdr *)(skb->data);
fctl = le16_to_cpu(wlhdr->frame_control);
- skb_trim(skb, skb->len - FCS_LEN);
if (macstat & B43_RX_MAC_DEC) {
unsigned int keyidx;
---
--
Greetings Michael.
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: timeout problems with certain APs and b43
> On Saturday, 24 of November 2007, Johannes Berg wrote: > > > > Yeah, but keep in mind we reverse engineered all the calibration code. Ah, I assume thats why the signal strength numbers etc are not really correct at all, ie even when my laptop is a metre from the AP its only showing 47% or so signal strength, whereas with XP/ndiswrapper its 100% up to many metres away. I had wondered about that. Mark This email has been scanned for all known viruses by the MessageLabs SkyScan service. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: timeout problems with certain APs and b43
On Saturday, 24 of November 2007, Johannes Berg wrote: > > > > > It seems that I can reproduce something similar on demand with an SMC > > > > wireless > > > > router by moving my box sufficiently far away from it. :-) > > > > > > Well, yeah, that's expected though, you lose signal at some point. Not > > > expected is that it happens without moving anything. Unless the > > > calibration code is wrong which wouldn't really surprise me either. > > > > In my case, everything works just fine when the box is 6 meters away from > > the > > AP (including a thick wall in between), but when I move it another 5-6 > > meters > > away from the AP, things break down ... > > > > I'd expect it to work at longer distances, but well. :-) > > Yeah, but keep in mind we reverse engineered all the calibration code. Sure. :-) For me it's not a problem (everywhere I use the wireless, there are APs close enough ;-)), but it seems related to what's been reported in this thread. Greetings, Rafael ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: timeout problems with certain APs and b43
> > > It seems that I can reproduce something similar on demand with an SMC > > > wireless > > > router by moving my box sufficiently far away from it. :-) > > > > Well, yeah, that's expected though, you lose signal at some point. Not > > expected is that it happens without moving anything. Unless the > > calibration code is wrong which wouldn't really surprise me either. > > In my case, everything works just fine when the box is 6 meters away from the > AP (including a thick wall in between), but when I move it another 5-6 meters > away from the AP, things break down ... > > I'd expect it to work at longer distances, but well. :-) Yeah, but keep in mind we reverse engineered all the calibration code. johannes signature.asc Description: This is a digitally signed message part ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
