[PATCH] b43: Fix phy_g.c compiler warning

[Michael Buesch]

Fix compile warning for non-debug builds:

drivers/net/wireless/b43/phy_g.c: In function ‘b43_gphy_op_recalc_txpower’:
drivers/net/wireless/b43/phy_g.c:3195: warning: unused variable ‘dbm’

Signed-off-by: Michael Buesch m...@bu3sch.de

---

Index: wireless-testing/drivers/net/wireless/b43/phy_g.c
===
--- wireless-testing.orig/drivers/net/wireless/b43/phy_g.c  2009-01-23 
19:18:42.0 +0100
+++ wireless-testing/drivers/net/wireless/b43/phy_g.c   2009-01-24 
22:33:44.0 +0100
@@ -3188,20 +3188,23 @@ static enum b43_txpwr_result b43_gphy_op
/* Lower attenuation = Bigger power output. Negate it. */
bbatt_delta = -bbatt_delta;
/* RF att affects power level 4 times as much as
 * Baseband attennuation. Subtract it. */
bbatt_delta -= 4 * rfatt_delta;
 
+#if B43_DEBUG
if (b43_debug(dev, B43_DBG_XMITPOWER)) {
int dbm = pwr_adjust  0 ? -pwr_adjust : pwr_adjust;
b43dbg(dev-wl,
   [TX power deltas]  %s Q52_FMT  dBm   =   
   bbatt-delta = %d,  rfatt-delta = %d\n,
   (pwr_adjust  0 ? - : ), Q52_ARG(dbm),
   bbatt_delta, rfatt_delta);
}
+#endif /* DEBUG */
+
/* So do we finally need to adjust something in hardware? */
if ((rfatt_delta == 0)  (bbatt_delta == 0))
goto no_adjustment_needed;
 
/* Save the deltas for later when we adjust the power. */
gphy-bbatt_delta = bbatt_delta;


-- 
Greetings, Michael.
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Re: integration of opensource firmware with b43 kernel driver

[Francesco Gringoli]

On Jan 23, 2009, at 8:45 PM, Larry Finger wrote:

 Francesco Gringoli wrote:
 Damn... that would be a very hard writing We do not have any  
 4311/2
 board: at first glance there are more condition registers whose  
 meaning
 we do not know. Very different hardware, didn't know. Thank you for  
 the
 feedback.

 By the way: is that device inside an AP? If yes what? if not which  
 brand
 has the board on? I can look around.

 Mine is on a mini-PCIe card in a laptop. The part has an HP Part
 #441090-001, but I expect there are Dell equivalents that are cheaper.
 I don't know about an AP.

 Larry
Larry,

could you please be so kind to try the opensource firmware on that  
4311/2 card by renaming it ucode13 and report what happens? I suggest  
to try monitor mode without associating first.

Thanks a lot.
-FG

___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Re: integration of opensource firmware with b43 kernel driver

[Larry Finger]

Francesco Gringoli wrote:
 
 could you please be so kind to try the opensource firmware on that
 4311/2 card by renaming it ucode13 and report what happens? I suggest to
 try monitor mode without associating first.

I had already tried it in managed mode. The logged data are

Jan 23 13:37:09 larrylap kernel: b43-phy0: Loading OpenSource firmware
version 351.11970
Jan 23 13:37:09 larrylap kernel: b43-phy0 warning: You are using an
old firmware image. Support for old firmware will be removed soon
(official deadline was July 2008).
Jan 23 13:37:09 larrylap kernel: b43-phy0 warning: You must go to
http://wireless.kernel.org/en/users/Drivers/b43#devicefirmware and
download the correct firmware for this driver version. Please
carefully read all instructions on this website.
Jan 23 13:37:09 larrylap kernel: b43-phy0 debug: Chip initialized
Jan 23 13:37:09 larrylap kernel: b43-phy0 debug: 64-bit DMA initialized
Jan 23 13:37:09 larrylap kernel: Registered led device: b43-phy0::tx
Jan 23 13:37:09 larrylap kernel: Registered led device: b43-phy0::rx
Jan 23 13:37:09 larrylap kernel: Registered led device: b43-phy0::radio
Jan 23 13:37:09 larrylap kernel: b43-phy0 debug: Wireless interface
started
Jan 23 13:37:09 larrylap kernel: b43-phy0: Controller restarted
Jan 23 13:37:25 larrylap kernel: b43-phy0 ERROR: MAC suspend failed
Jan 23 13:37:29 larrylap kernel: b43-phy0 ERROR: MAC suspend failed
Jan 23 13:37:30 larrylap kernel: b43-phy0 ERROR: MAC suspend failed
Jan 23 13:37:30 larrylap kernel: b43-phy0 ERROR: MAC suspend failed
Jan 23 13:37:30 larrylap kernel: b43-phy0 ERROR: MAC suspend failed
Jan 23 13:37:31 larrylap kernel: b43-phy0 ERROR: MAC suspend failed
Jan 23 13:37:31 larrylap kernel: b43-phy0 ERROR: MAC suspend failed
Jan 23 13:37:31 larrylap kernel: b43-phy0 ERROR: MAC suspend failed
Jan 23 13:37:32 larrylap kernel: b43-phy0 ERROR: MAC suspend failed
Jan 23 13:37:32 larrylap kernel: b43-phy0 ERROR: MAC suspend failed
Jan 23 13:37:40 larrylap kernel: b43-phy0 ERROR: Firmware watchdog:
The firmware died!
Jan 23 13:37:40 larrylap kernel: b43-phy0: Controller RESET (Firmware
watchdog) ...
Jan 23 13:37:41 larrylap kernel: b43-phy0 ERROR: MAC suspend failed
Jan 23 13:37:41 larrylap kernel: b43-phy0 debug: Wireless interface
stopped
Jan 23 13:37:41 larrylap kernel: b43-phy0 debug: DMA-64 rx_ring: Used
slots 0/64, Failed frames 0/0 = 0.0%, Average tries 0.00
Jan 23 13:37:41 larrylap kernel: b43-phy0 debug: DMA-64 tx_ring_AC_BK:
Used slots 0/128, Failed frames 0/0 = 0.0%, Average tries 0.00
Jan 23 13:37:41 larrylap kernel: b43-phy0 debug: DMA-64 tx_ring_AC_BE:
Used slots 0/128, Failed frames 0/0 = 0.0%, Average tries 0.00
Jan 23 13:37:41 larrylap kernel: b43-phy0 debug: DMA-64 tx_ring_AC_VI:
Used slots 0/128, Failed frames 0/0 = 0.0%, Average tries 0.00
Jan 23 13:37:41 larrylap kernel: b43-phy0 debug: DMA-64 tx_ring_AC_VO:
Used slots 22/128, Failed frames 0/0 = 0.0%, Average tries 0.00
Jan 23 13:37:41 larrylap kernel: b43-phy0 debug: DMA-64 tx_ring_mcast:
Used slots 0/128, Failed frames 0/0 = 0.0%, Average tries 0.00

I haven't gotten to monitor mode yet, but if the firmware cannot
suspend the MAC, I'm not optimistic.

Larry

___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev