Re: [PATCH] b43: Mask PHY TX error interrupt, if not debugging
On Saturday 04 April 2009 10:54:01 Elimar Riesebieter wrote: > * Michael Buesch [090319 19:27 +0100] > [...] > > !!! DISTRIBUTIONS !!! > > Disable CONFIG_B43_DEBUG! > > There is absolutely _no_ reason to enable it on a release kernel. > > There were valid reasons in the past, but there are none left anymore. > > So please _disable_ this option now, if you didn't do this already, > > because with CONFIG_B43_DEBUG enabled the PHY TX errors will still show. > > I tried that at 2.6.29.1 and got: > drivers/net/wireless/b43/main.c: In function 'setup_struct_wldev_for_init': > drivers/net/wireless/b43/main.c:3904: error: 'b43_modparam_verbose' > undeclared (first use in this function) > drivers/net/wireless/b43/main.c:3904: error: (Each undeclared identifier is > reported only once > drivers/net/wireless/b43/main.c:3904: error: for each function it appears in.) > drivers/net/wireless/b43/main.c:3904: error: 'B43_VERBOSITY_DEBUG' undeclared > (first use in this function) > > Elimar > You're not supposed to apply this patch to 2.6.29 -- Greetings, Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] b43: Mask PHY TX error interrupt, if not debugging
* Michael Buesch [090319 19:27 +0100] [...] > !!! DISTRIBUTIONS !!! > Disable CONFIG_B43_DEBUG! > There is absolutely _no_ reason to enable it on a release kernel. > There were valid reasons in the past, but there are none left anymore. > So please _disable_ this option now, if you didn't do this already, > because with CONFIG_B43_DEBUG enabled the PHY TX errors will still show. I tried that at 2.6.29.1 and got: drivers/net/wireless/b43/main.c: In function 'setup_struct_wldev_for_init': drivers/net/wireless/b43/main.c:3904: error: 'b43_modparam_verbose' undeclared (first use in this function) drivers/net/wireless/b43/main.c:3904: error: (Each undeclared identifier is reported only once drivers/net/wireless/b43/main.c:3904: error: for each function it appears in.) drivers/net/wireless/b43/main.c:3904: error: 'B43_VERBOSITY_DEBUG' undeclared (first use in this function) Elimar -- "Talking much about oneself can also be a means to conceal oneself." -Friedrich Nietzsche ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
