Re: [PATCH 5/5 V2] b43: N-PHY: silence warnings, add missing call
On Mon, Jan 18, 2010 at 12:21:49AM +0100, Rafał Miłecki wrote: Signed-off-by: Rafał Miłecki zaj...@gmail.com --- New patch I didn't include earlier. Rafał, I just applied this 5-patch series and the preceding 7-patch series, and I had to fixup every single one manually due to the apparently busted mailer you are using. User-Agent: Opera Mail/10.10 (Linux) The only reason I went to this trouble is because a) I want the N-phy stuff and b) you sent small, manageable patches. But don't misunderstand -- I have no intention of continuing to fix these manually. Learn to use git send-email or find some other mailer to send your patches -- I recommend Mutt. In any case, do not expect your patches to get merged unless in the future unless you can rectify this situation at your end. I just don't have the bandwidth for dealing with crap like this. Thanks, John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH 5/5 V2] b43: N-PHY: silence warnings, add missing call
2010/1/19 John W. Linville linvi...@tuxdriver.com: On Mon, Jan 18, 2010 at 12:21:49AM +0100, Rafał Miłecki wrote: Signed-off-by: Rafał Miłecki zaj...@gmail.com --- New patch I didn't include earlier. Rafał, I just applied this 5-patch series and the preceding 7-patch series, and I had to fixup every single one manually due to the apparently busted mailer you are using. User-Agent: Opera Mail/10.10 (Linux) The only reason I went to this trouble is because a) I want the N-phy stuff and b) you sent small, manageable patches. But don't misunderstand -- I have no intention of continuing to fix these manually. Learn to use git send-email or find some other mailer to send your patches -- I recommend Mutt. In any case, do not expect your patches to get merged unless in the future unless you can rectify this situation at your end. I just don't have the bandwidth for dealing with crap like this. In case this helps: http://wireless.kernel.org/en/developers/Documentation/git-guide#Sending_patches Luis ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH 5/5 V2] b43: N-PHY: silence warnings, add missing call
W dniu 19 stycznia 2010 22:55 użytkownik John W. Linville linvi...@tuxdriver.com napisał: On Mon, Jan 18, 2010 at 12:21:49AM +0100, Rafał Miłecki wrote: Signed-off-by: Rafał Miłecki zaj...@gmail.com --- New patch I didn't include earlier. Rafał, I just applied this 5-patch series and the preceding 7-patch series, and I had to fixup every single one manually due to the apparently busted mailer you are using. User-Agent: Opera Mail/10.10 (Linux) The only reason I went to this trouble is because a) I want the N-phy stuff and b) you sent small, manageable patches. But don't misunderstand -- I have no intention of continuing to fix these manually. Learn to use git send-email or find some other mailer to send your patches -- I recommend Mutt. In any case, do not expect your patches to get merged unless in the future unless you can rectify this situation at your end. I just don't have the bandwidth for dealing with crap like this. John, I strongly believe you know I'm new to whole kernel-related stuff. That just implies I make mistakes and ask simple questions but definitely I don't try to make your work harder on purpose. I already resend some of my first patches and after that no one hit issue you got with applying my patches. I have all patches here locally, you could just ask me to resend them using other method. Didn't have to bother that effort you did and become angry. -- Rafał ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH 5/5 V2] b43: N-PHY: silence warnings, add missing call
W dniu 19 stycznia 2010 22:55 użytkownik John W. Linville linvi...@tuxdriver.com napisał: On Mon, Jan 18, 2010 at 12:21:49AM +0100, Rafał Miłecki wrote: Signed-off-by: Rafał Miłecki zaj...@gmail.com --- New patch I didn't include earlier. Rafał, I just applied this 5-patch series and the preceding 7-patch series, and I had to fixup every single one manually due to the apparently busted mailer you are using. User-Agent: Opera Mail/10.10 (Linux) The only reason I went to this trouble is because a) I want the N-phy stuff and b) you sent small, manageable patches. But don't misunderstand -- I have no intention of continuing to fix these manually. Learn to use git send-email or find some other mailer to send your patches -- I recommend Mutt. In any case, do not expect your patches to get merged unless in the future unless you can rectify this situation at your end. I just don't have the bandwidth for dealing with crap like this. Out of curiosity, could someone tell what Opera does incorrectly when sending patches? -- Rafał ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
[RFC] How to store HT (40MHz) support
In N-PHY code we have to make some decisions based on fact if band is 40MHz.
AFAIU when registering device, driver reports to mac80211 HT capability and
this is not implemented yet. For that we will need to modify:
static struct ieee80211_supported_band b43_band_5GHz_nphy = { ... }
Then mac80211 can request switching to 40MHz usage using ieee80211_ops.config
(which we handle in b43_op_config).
Is that correct? If so, is attached patch fine for storing 40MHz usage? We
don't report HT support to mac80211 so it should not request 40MHz usage for
now.
diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index 9c5c7c9..641c7de 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -3571,6 +3571,9 @@ static int b43_op_config(struct ieee80211_hw *hw, u32
changed)
dev = wl-current_dev;
phy = dev-phy;
+ if (phy-supports_40mhz)
+ phy-use_40mhz = conf_is_ht(conf);
+
b43_mac_suspend(dev);
if (changed IEEE80211_CONF_CHANGE_RETRY_LIMITS)
diff --git a/drivers/net/wireless/b43/phy_common.h
b/drivers/net/wireless/b43/phy_common.h
index 9edd4e8..62c7028 100644
--- a/drivers/net/wireless/b43/phy_common.h
+++ b/drivers/net/wireless/b43/phy_common.h
@@ -212,6 +212,10 @@ struct b43_phy {
bool supports_2ghz;
bool supports_5ghz;
+ /* Band width support and usage */
+ bool supports_40mhz;
+ bool use_40mhz;
+
/* GMODE bit enabled? */
bool gmode;
diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c
index e77f1f2..ed8f372 100644
--- a/drivers/net/wireless/b43/phy_n.c
+++ b/drivers/net/wireless/b43/phy_n.c
@@ -1787,7 +1787,7 @@ static int b43_nphy_cal_tx_iq_lo(struct b43_wldev *dev,
b43_phy_write(dev, B43_NPHY_IQLOCAL_CMDGCTL, 0x8AA9);
- if (1 /* FIXME: the band width is 20 MHz */)
+ if (!dev-phy.use_40mhz)
freq = 2500;
else
freq = 5000;
--
Rafał
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
