Re: DMA queue overflow
On Thursday 30 July 2009 04:10:32 Larry Finger wrote: Francesco Gringoli wrote: is this stuff related in some way to the error triggered by the opensource firmware? What happens with your patch? Using the same test with tcpperf running on one console and a flood ping on a second, the system lasted 7 minutes before meta-skb was NULL. The data are: b43: meta data: skb (null) dmaaddr 4fa820bc is_last_fragment 1 b43: ring data: nr_slots 256 used_slots 205 current_slot 105 index 1 tx 1 max_used_slots 256 Notice that the DMA queue is not even close to full - there are about 50 slots left or enough space for 25 more packets. Yeah but it _was_ full earlier (max_used_slots 256). I don't say that this is triggering the issue, however. skb=NULL somehow smells like a double-free caused by a double-report or something like that. This error was generated with the DMA queue full patch applied. -- Greetings, Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: DMA queue overflow
On Jul 30, 2009, at 9:02 PM, Larry Finger wrote: Francesco, skb=NULL somehow smells like a double-free caused by a double-report or something like that. Based on what Michael said about a double-free, I changed from meta-skb = NULL to meta-skb = 0x0606060606060606, and changed to testing section apropriately. Now I got two messages, then the interface hung, probably due to a bogus skb that was not NULL: b43: meta data: skb 0606060606060606 dmaaddr 20a320bc is_last_fragment 1 b43: ring data: nr_slots 256 used_slots 241 current_slot 87 index 1 tx 1 max_used_slots 256 b43: cookie: 0x2062 slot: 99 b43: meta data: skb 0606060606060606 dmaaddr 279220bc is_last_fragment 1 b43: ring data: nr_slots 256 used_slots 252 current_slot 147 index 1 tx 1 max_used_slots 256 b43: cookie: 0x2044 slot: 69 It certainly looks as if txstatus is called more than once with the same cookie. Larry Hi Larry, many thanks. I will surely look into that direction as soon as I get the boards. By the way: I never worked with mini-pci-e and I don't even have a desktop PC with that bus, so I plan to get some newer desktop around in my department and use a pci-e to mini-pci-e adapter. Do you know if such adapter can trigger some incompatibility with b43? Or is it completely transparent? Cheers, -Francesco INFORMATIVA SUL TRATTAMENTO DEI DATI PERSONALI I dati utilizzati per l'invio del presente messaggio sono trattati dall' Universita' degli studi di Brescia esclusivamente per finalita' istituzionali. Informazioni piu' dettagliate anche in ordine ai diritti dell'interessato sono riposte nell'informativa generale e nelle notizie pubblicate sul sito web dell'Ateneo nella sezione privacy. Il contenuto di questo messaggio e' rivolto unicamente alle persone cui e' indirizzato e puo' contenere informazioni la cui riservatezza e' tutelata legalmente. Ne sono vietati la riproduzione, la diffusione e l'uso in mancanza di autorizzazione del destinatario. Qualora il messaggio fosse pervenuto per errore, preghiamo di eliminarlo. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: DMA queue overflow
On Thursday 30 July 2009 23:54:17 Francesco Gringoli wrote: many thanks. I will surely look into that direction as soon as I get the boards. By the way: I never worked with mini-pci-e and I don't even have a desktop PC with that bus, so I plan to get some newer desktop around in my department and use a pci-e to mini-pci-e adapter. Do you know if such adapter can trigger some incompatibility with b43? Or is it completely transparent? I think it's just a mechanical adapter. -- Greetings, Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: DMA queue overflow
On Jul 30, 2009, at 11:55 PM, Michael Buesch wrote: On Thursday 30 July 2009 23:54:17 Francesco Gringoli wrote: many thanks. I will surely look into that direction as soon as I get the boards. By the way: I never worked with mini-pci-e and I don't even have a desktop PC with that bus, so I plan to get some newer desktop around in my department and use a pci-e to mini-pci-e adapter. Do you know if such adapter can trigger some incompatibility with b43? Or is it completely transparent? I think it's just a mechanical adapter. Thanks, I will get one immediately. Cheers, -Francesco INFORMATIVA SUL TRATTAMENTO DEI DATI PERSONALI I dati utilizzati per l'invio del presente messaggio sono trattati dall' Universita' degli studi di Brescia esclusivamente per finalita' istituzionali. Informazioni piu' dettagliate anche in ordine ai diritti dell'interessato sono riposte nell'informativa generale e nelle notizie pubblicate sul sito web dell'Ateneo nella sezione privacy. Il contenuto di questo messaggio e' rivolto unicamente alle persone cui e' indirizzato e puo' contenere informazioni la cui riservatezza e' tutelata legalmente. Ne sono vietati la riproduzione, la diffusione e l'uso in mancanza di autorizzazione del destinatario. Qualora il messaggio fosse pervenuto per errore, preghiamo di eliminarlo. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: DMA queue overflow
On Jul 26, 2009, at 7:01 PM, Larry Finger wrote: Michael Buesch wrote: On Sunday 26 July 2009 17:37:10 Larry Finger wrote: The revised printk shows b43-phy0 warning: DMA queue overflow with free_slots = 0 Ok, it's a mac80211 bug then. Perhaps not. I also got the ring-stopped WARN_ON. Is it possible that a second transmission was held at the spin_lock_irqsave() when the queues were stopped. If that were the case, the following patch should fix the problem. [cut] I do have one question. Should the DMA queue overflow message ever be printed? It seems to me that we have a 'no harm - no foul' situation. Larry Larry, is this stuff related in some way to the error triggered by the opensource firmware? What happens with your patch? I still have not received the boards so I have not started working on it, I'm waiting them from Hong Kong. Cheers, -Francesco INFORMATIVA SUL TRATTAMENTO DEI DATI PERSONALI I dati utilizzati per l'invio del presente messaggio sono trattati dall' Universita' degli studi di Brescia esclusivamente per finalita' istituzionali. Informazioni piu' dettagliate anche in ordine ai diritti dell'interessato sono riposte nell'informativa generale e nelle notizie pubblicate sul sito web dell'Ateneo nella sezione privacy. Il contenuto di questo messaggio e' rivolto unicamente alle persone cui e' indirizzato e puo' contenere informazioni la cui riservatezza e' tutelata legalmente. Ne sono vietati la riproduzione, la diffusione e l'uso in mancanza di autorizzazione del destinatario. Qualora il messaggio fosse pervenuto per errore, preghiamo di eliminarlo. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: DMA queue overflow
Francesco Gringoli wrote: is this stuff related in some way to the error triggered by the opensource firmware? What happens with your patch? Using the same test with tcpperf running on one console and a flood ping on a second, the system lasted 7 minutes before meta-skb was NULL. The data are: b43: meta data: skb (null) dmaaddr 4fa820bc is_last_fragment 1 b43: ring data: nr_slots 256 used_slots 205 current_slot 105 index 1 tx 1 max_used_slots 256 Notice that the DMA queue is not even close to full - there are about 50 slots left or enough space for 25 more packets. This error was generated with the DMA queue full patch applied. Larry ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
