[Beignet] [PATCH 1/3] do not touch src1 when setting instruction header

2016-11-27 Thread Guo, Yejun
Signed-off-by: Guo, Yejun 
---
 backend/src/backend/gen9_encoder.cpp | 1 +
 backend/src/backend/gen_encoder.cpp  | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/backend/src/backend/gen9_encoder.cpp 
b/backend/src/backend/gen9_encoder.cpp
index 80df50d..e66ae08 100644
--- a/backend/src/backend/gen9_encoder.cpp
+++ b/backend/src/backend/gen9_encoder.cpp
@@ -60,6 +60,7 @@ namespace gbe
  this->setHeader(insn);
  this->setDst(insn, dest);
  this->setSrc0(insn, msg);
+ this->setSrc1(insn, GenRegister::immud(0));
  setSamplerMessage(insn, bti, sampler, msg_type,
response_length, msg_length,
header_present,
diff --git a/backend/src/backend/gen_encoder.cpp 
b/backend/src/backend/gen_encoder.cpp
index a69adc7..060d65f 100644
--- a/backend/src/backend/gen_encoder.cpp
+++ b/backend/src/backend/gen_encoder.cpp
@@ -203,7 +203,6 @@ namespace gbe
 unsigned msg_length, unsigned 
response_length,
 bool header_present, bool 
end_of_thread)
   {
- setSrc1(inst, GenRegister::immud(0));
  inst->bits3.generic_gen5.header_present = header_present;
  inst->bits3.generic_gen5.response_length = response_length;
  inst->bits3.generic_gen5.msg_length = msg_length;
@@ -1178,6 +1177,7 @@ namespace gbe
  this->setHeader(insn);
  this->setDst(insn, dest);
  this->setSrc0(insn, msg);
+ this->setSrc1(insn, GenRegister::immud(0));
  setSamplerMessage(insn, bti, sampler, msg_type,
response_length, msg_length,
header_present,
-- 
1.9.1

___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet


[Beignet] [PATCH 1/3] do not touch src1 when setting instruction header

2016-11-28 Thread Guo, Yejun
Signed-off-by: Guo, Yejun 
---
 backend/src/backend/gen9_encoder.cpp | 1 +
 backend/src/backend/gen_encoder.cpp  | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/backend/src/backend/gen9_encoder.cpp 
b/backend/src/backend/gen9_encoder.cpp
index 80df50d..e66ae08 100644
--- a/backend/src/backend/gen9_encoder.cpp
+++ b/backend/src/backend/gen9_encoder.cpp
@@ -60,6 +60,7 @@ namespace gbe
  this->setHeader(insn);
  this->setDst(insn, dest);
  this->setSrc0(insn, msg);
+ this->setSrc1(insn, GenRegister::immud(0));
  setSamplerMessage(insn, bti, sampler, msg_type,
response_length, msg_length,
header_present,
diff --git a/backend/src/backend/gen_encoder.cpp 
b/backend/src/backend/gen_encoder.cpp
index a69adc7..060d65f 100644
--- a/backend/src/backend/gen_encoder.cpp
+++ b/backend/src/backend/gen_encoder.cpp
@@ -203,7 +203,6 @@ namespace gbe
 unsigned msg_length, unsigned 
response_length,
 bool header_present, bool 
end_of_thread)
   {
- setSrc1(inst, GenRegister::immud(0));
  inst->bits3.generic_gen5.header_present = header_present;
  inst->bits3.generic_gen5.response_length = response_length;
  inst->bits3.generic_gen5.msg_length = msg_length;
@@ -1178,6 +1177,7 @@ namespace gbe
  this->setHeader(insn);
  this->setDst(insn, dest);
  this->setSrc0(insn, msg);
+ this->setSrc1(insn, GenRegister::immud(0));
  setSamplerMessage(insn, bti, sampler, msg_type,
response_length, msg_length,
header_present,
-- 
1.9.1

___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet


Re: [Beignet] [PATCH 1/3] do not touch src1 when setting instruction header

2016-11-28 Thread Song, Ruiling
The patchset LGTM.

___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet


Re: [Beignet] [PATCH 1/3] do not touch src1 when setting instruction header

2016-11-30 Thread Yang, Rong R
IVB crash because of don't setSrc1, add it by manual and pushed, thanks.

> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> Song, Ruiling
> Sent: Tuesday, November 29, 2016 13:21
> To: Guo, Yejun ; beignet@lists.freedesktop.org
> Cc: Guo, Yejun 
> Subject: Re: [Beignet] [PATCH 1/3] do not touch src1 when setting instruction
> header
> 
> The patchset LGTM.
> 
> ___
> Beignet mailing list
> Beignet@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/beignet
___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet