Re: [Beignet] [PATCH 2/2] Ensure paths to beignet.bc and beignet.pch include a / before the filename

2016-05-24 Thread Yang, Rong R
Pushed.

> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> Guo, Yejun
> Sent: Wednesday, May 25, 2016 8:59
> To: Burton, Ross ; beignet@lists.freedesktop.org
> Subject: Re: [Beignet] [PATCH 2/2] Ensure paths to beignet.bc and
> beignet.pch include a / before the filename
> 
> this patch set looks good, thanks.
> 
> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> Ross Burton
> Sent: Tuesday, May 24, 2016 11:14 PM
> To: beignet@lists.freedesktop.org
> Subject: [Beignet] [PATCH 2/2] Ensure paths to beignet.bc and beignet.pch
> include a / before the filename
> 
> Otherwise it's possible for the paths to be something like
> /usr/lib/beignetbeignet.bc.
> 
> Signed-off-by: Ross Burton 
> ---
>  backend/src/CMakeLists.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/backend/src/CMakeLists.txt b/backend/src/CMakeLists.txt index
> a4e909a..a21ca75 100644
> --- a/backend/src/CMakeLists.txt
> +++ b/backend/src/CMakeLists.txt
> @@ -1,6 +1,6 @@
> -set (OCL_BITCODE_BIN "${BEIGNET_INSTALL_DIR}beignet.bc")
> +set (OCL_BITCODE_BIN "${BEIGNET_INSTALL_DIR}/beignet.bc")
>  set (OCL_HEADER_DIR "${BEIGNET_INSTALL_DIR}/include") -set
> (OCL_PCH_OBJECT "${BEIGNET_INSTALL_DIR}beignet.pch")
> +set (OCL_PCH_OBJECT "${BEIGNET_INSTALL_DIR}/beignet.pch")
>  set (GBE_OBJECT_DIR "${BEIGNET_INSTALL_DIR}/libgbe.so")
>  set (INTERP_OBJECT_DIR "${BEIGNET_INSTALL_DIR}/libgbeinterp.so")
> 
> --
> 2.8.0.rc3
> 
> ___
> Beignet mailing list
> Beignet@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/beignet
> ___
> Beignet mailing list
> Beignet@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/beignet
___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet


Re: [Beignet] [PATCH 2/2] Ensure paths to beignet.bc and beignet.pch include a / before the filename

2016-05-24 Thread Guo, Yejun
this patch set looks good, thanks.

-Original Message-
From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Ross 
Burton
Sent: Tuesday, May 24, 2016 11:14 PM
To: beignet@lists.freedesktop.org
Subject: [Beignet] [PATCH 2/2] Ensure paths to beignet.bc and beignet.pch 
include a / before the filename

Otherwise it's possible for the paths to be something like
/usr/lib/beignetbeignet.bc.

Signed-off-by: Ross Burton 
---
 backend/src/CMakeLists.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/backend/src/CMakeLists.txt b/backend/src/CMakeLists.txt
index a4e909a..a21ca75 100644
--- a/backend/src/CMakeLists.txt
+++ b/backend/src/CMakeLists.txt
@@ -1,6 +1,6 @@
-set (OCL_BITCODE_BIN "${BEIGNET_INSTALL_DIR}beignet.bc")
+set (OCL_BITCODE_BIN "${BEIGNET_INSTALL_DIR}/beignet.bc")
 set (OCL_HEADER_DIR "${BEIGNET_INSTALL_DIR}/include")
-set (OCL_PCH_OBJECT "${BEIGNET_INSTALL_DIR}beignet.pch")
+set (OCL_PCH_OBJECT "${BEIGNET_INSTALL_DIR}/beignet.pch")
 set (GBE_OBJECT_DIR "${BEIGNET_INSTALL_DIR}/libgbe.so")
 set (INTERP_OBJECT_DIR "${BEIGNET_INSTALL_DIR}/libgbeinterp.so")
 
-- 
2.8.0.rc3

___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet
___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet


[Beignet] [PATCH 2/2] Ensure paths to beignet.bc and beignet.pch include a / before the filename

2016-05-24 Thread Ross Burton
Otherwise it's possible for the paths to be something like
/usr/lib/beignetbeignet.bc.

Signed-off-by: Ross Burton 
---
 backend/src/CMakeLists.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/backend/src/CMakeLists.txt b/backend/src/CMakeLists.txt
index a4e909a..a21ca75 100644
--- a/backend/src/CMakeLists.txt
+++ b/backend/src/CMakeLists.txt
@@ -1,6 +1,6 @@
-set (OCL_BITCODE_BIN "${BEIGNET_INSTALL_DIR}beignet.bc")
+set (OCL_BITCODE_BIN "${BEIGNET_INSTALL_DIR}/beignet.bc")
 set (OCL_HEADER_DIR "${BEIGNET_INSTALL_DIR}/include")
-set (OCL_PCH_OBJECT "${BEIGNET_INSTALL_DIR}beignet.pch")
+set (OCL_PCH_OBJECT "${BEIGNET_INSTALL_DIR}/beignet.pch")
 set (GBE_OBJECT_DIR "${BEIGNET_INSTALL_DIR}/libgbe.so")
 set (INTERP_OBJECT_DIR "${BEIGNET_INSTALL_DIR}/libgbeinterp.so")
 
-- 
2.8.0.rc3

___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet