Re: [Beignet] [PATCH 3/4] Fix a event leak in create context

[Zhigang Gong]

Nice catch, this patch LGTM.

On Thu, Sep 24, 2015 at 05:13:26PM +0800, Pan Xiuli wrote:
> We get an event out of NDRangeKernel, and we don't release it.
> As an gpgpu event it can also make drm buffer leak, to avoid
> potenial error we just release it.w
> 
> Signed-off-by: Pan Xiuli 
> ---
>  src/cl_device_id.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/cl_device_id.c b/src/cl_device_id.c
> index 78d2cf4..a3d3fc4 100644
> --- a/src/cl_device_id.c
> +++ b/src/cl_device_id.c
> @@ -622,6 +622,7 @@ cl_self_test(cl_device_id device, cl_self_test_res 
> atomic_in_l3_flag)
>// Atomic fail need to test SLM again with atomic in L3 
> feature disabled.
>tested = 0;
>  }
> +clReleaseEvent(kernel_finished);
>}
>  }
>  clReleaseMemObject(buffer);
> -- 
> 2.1.4
> 
> ___
> Beignet mailing list
> Beignet@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet
___
Beignet mailing list
Beignet@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/beignet

[Beignet] [PATCH 3/4] Fix a event leak in create context

[Pan Xiuli]

We get an event out of NDRangeKernel, and we don't release it.
As an gpgpu event it can also make drm buffer leak, to avoid
potenial error we just release it.w

Signed-off-by: Pan Xiuli 
---
 src/cl_device_id.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/cl_device_id.c b/src/cl_device_id.c
index 78d2cf4..a3d3fc4 100644
--- a/src/cl_device_id.c
+++ b/src/cl_device_id.c
@@ -622,6 +622,7 @@ cl_self_test(cl_device_id device, cl_self_test_res 
atomic_in_l3_flag)
   // Atomic fail need to test SLM again with atomic in L3 
feature disabled.
   tested = 0;
 }
+clReleaseEvent(kernel_finished);
   }
 }
 clReleaseMemObject(buffer);
-- 
2.1.4

___
Beignet mailing list
Beignet@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/beignet