Re: [Beignet] [PATCH V2] output more detail of GEN IR for workgroup op

2016-12-28 Thread Yang, Rong R 
Pushed, thanks.

> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> Pan, Xiuli
> Sent: Wednesday, December 28, 2016 15:00
> To: Guo, Yejun <yejun@intel.com>; beignet@lists.freedesktop.org
> Cc: Guo, Yejun <yejun@intel.com>
> Subject: Re: [Beignet] [PATCH V2] output more detail of GEN IR for
> workgroup op
> 
> LGTM!
> 
> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> Guo, Yejun
> Sent: Wednesday, December 21, 2016 6:33 PM
> To: beignet@lists.freedesktop.org
> Cc: Guo, Yejun <yejun@intel.com>
> Subject: [Beignet] [PATCH V2] output more detail of GEN IR for workgroup
> op
> 
> v2: the src number changes for different ops
> Signed-off-by: Guo, Yejun <yejun@intel.com>
> ---
>  backend/src/ir/instruction.cpp | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/backend/src/ir/instruction.cpp b/backend/src/ir/instruction.cpp
> index 0687dbf..f0c3957 100644
> --- a/backend/src/ir/instruction.cpp
> +++ b/backend/src/ir/instruction.cpp
> @@ -1917,7 +1917,8 @@ namespace ir {
>}
> 
>out << " %" << this->getDst(fn, 0);
> -  out << " %" << this->getSrc(fn, 0);
> +  for (uint32_t i = 0; i < this->getSrcNum(); ++i)
> +out << " %" << this->getSrc(fn, i);
> 
>if (this->workGroupOp == WORKGROUP_OP_BROADCAST) {
>  do {
> @@ -1942,7 +1943,7 @@ namespace ir {
>  } while(0);
>}
> 
> -  out << "TheadID Map at SLM: " << this->slmAddr;
> +  out << " (TheadID Map at SLM: " << this->slmAddr << ")";
>  }
> 
>  INLINE void SubGroupInstruction::out(std::ostream , const Function
> ) const {
> --
> 1.9.1
> 
> ___
> Beignet mailing list
> Beignet@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/beignet
> ___
> Beignet mailing list
> Beignet@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/beignet
___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet

Re: [Beignet] [PATCH V2] output more detail of GEN IR for workgroup op

2016-12-27 Thread Pan, Xiuli 
LGTM!  

-Original Message-
From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Guo, 
Yejun
Sent: Wednesday, December 21, 2016 6:33 PM
To: beignet@lists.freedesktop.org
Cc: Guo, Yejun <yejun@intel.com>
Subject: [Beignet] [PATCH V2] output more detail of GEN IR for workgroup op

v2: the src number changes for different ops
Signed-off-by: Guo, Yejun <yejun@intel.com>
---
 backend/src/ir/instruction.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/backend/src/ir/instruction.cpp b/backend/src/ir/instruction.cpp 
index 0687dbf..f0c3957 100644
--- a/backend/src/ir/instruction.cpp
+++ b/backend/src/ir/instruction.cpp
@@ -1917,7 +1917,8 @@ namespace ir {
   }
 
   out << " %" << this->getDst(fn, 0);
-  out << " %" << this->getSrc(fn, 0);
+  for (uint32_t i = 0; i < this->getSrcNum(); ++i)
+out << " %" << this->getSrc(fn, i);
 
   if (this->workGroupOp == WORKGROUP_OP_BROADCAST) {
 do {
@@ -1942,7 +1943,7 @@ namespace ir {
 } while(0);
   }
 
-  out << "TheadID Map at SLM: " << this->slmAddr;
+  out << " (TheadID Map at SLM: " << this->slmAddr << ")";
 }
 
 INLINE void SubGroupInstruction::out(std::ostream , const Function 
) const {
--
1.9.1

___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet
___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet

[Beignet] [PATCH V2] output more detail of GEN IR for workgroup op

2016-12-21 Thread Guo, Yejun 
v2: the src number changes for different ops
Signed-off-by: Guo, Yejun 
---
 backend/src/ir/instruction.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/backend/src/ir/instruction.cpp b/backend/src/ir/instruction.cpp
index 0687dbf..f0c3957 100644
--- a/backend/src/ir/instruction.cpp
+++ b/backend/src/ir/instruction.cpp
@@ -1917,7 +1917,8 @@ namespace ir {
   }
 
   out << " %" << this->getDst(fn, 0);
-  out << " %" << this->getSrc(fn, 0);
+  for (uint32_t i = 0; i < this->getSrcNum(); ++i)
+out << " %" << this->getSrc(fn, i);
 
   if (this->workGroupOp == WORKGROUP_OP_BROADCAST) {
 do {
@@ -1942,7 +1943,7 @@ namespace ir {
 } while(0);
   }
 
-  out << "TheadID Map at SLM: " << this->slmAddr;
+  out << " (TheadID Map at SLM: " << this->slmAddr << ")";
 }
 
 INLINE void SubGroupInstruction::out(std::ostream , const Function 
) const {
-- 
1.9.1

___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet