Re: [SlimDevices: Beta] LMS 8.3 and Various Artists
Yes, I think they're all related. What I'm unsure of is if the intended result was to force everyone to have to manually tag all their cuesheets if they wanted them to be recognized as compilations. That seems like a really big change in fundamental behavior for the scanner and I'm surprised that it hasn't been commented upon. gharris999's Profile: http://forums.slimdevices.com/member.php?userid=115 View this thread: http://forums.slimdevices.com/showthread.php?t=115184 ___ beta mailing list beta@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/beta
Re: [SlimDevices: Beta] LMS 8.3 and Various Artists
gharris999 wrote: > Am I understanding this commit: > > https://github.com/Logitech/slimserver/commit/68ec4e69d55e9746c8d4dee4fa1c74617a5464e9 > > ..correctly? That it's asking that I go back, extract embedded > cuesheets from about 8,000 flacs in my library, identify which ones are > compilations and then manually add: > > REM COMPILATION > > ..to each one and then re-embed the cuesheets? > > If that's the case, why???The same person submitted 3 changes on the same > day. Are they all related? https://github.com/Logitech/slimserver/commits?author=jbylsma Sent from my Pixel 3a using Tapatalk slartibartfast's Profile: http://forums.slimdevices.com/member.php?userid=35609 View this thread: http://forums.slimdevices.com/showthread.php?t=115184 ___ beta mailing list beta@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/beta
Re: [SlimDevices: Beta] LMS 8.3 and Various Artists
Am I understanding this commit: https://github.com/Logitech/slimserver/commit/68ec4e69d55e9746c8d4dee4fa1c74617a5464e9 ..correctly? That it's asking that I go back, extract embedded cuesheets from about 8,000 flacs in my library, identify which ones are compilations and then manually add: REM COMPILATION ..to each one and then re-embed the cuesheets? If that's the case, why??? gharris999's Profile: http://forums.slimdevices.com/member.php?userid=115 View this thread: http://forums.slimdevices.com/showthread.php?t=115184 ___ beta mailing list beta@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/beta
Re: [SlimDevices: Beta] LMS 8.3 and Various Artists
OK, just to be clear, the "Various Artists" compilation behavior is broken in 8.2 & 8.3 for me for whole-album-flacs with embedded cuesheets. I've identified the commits that break the behavior: Code: OK: Logitech Media Server Version: 8.2.0 - git-e5255b339 @ 2021-03-15 17:52:57 +0100e5255b339884491508e8979152e4a9c019779de3 --breaking point-- BAD:Logitech Media Server Version: 8.1.2 - git-35a5df3cd @ 2021-03-21 22:56:46 -0400 35a5df3cd5d16b76fe139837f5d7acaab6bb6853 https://github.com/Logitech/slimserver/commit/35a5df3cd5d16b76fe139837f5d7acaab6bb6853 BAD:Logitech Media Server Version: 8.2.0 - git-68ec4e69d @ 2021-03-23 06:15:51 +0100 68ec4e69d55e9746c8d4dee4fa1c74617a5464e9 The breaking commit comment: > Remove cuesheet functionality forcing releases with multiple artists as > compilations > > If a release has not explicitly set compilation status, the status is > computed in Slim::Schema->_createOrUpdateAlbum. Cuesheets, however, > preemptively compute compilation status if the release has an album > artist that does not match the track artist. Additionally, this > computation happens after retrieving an explicit compilation value, > preventing a user from overriding the status. What was the reasoning behind this commit? Was the purpose to speed up scanning by not having to do album artist vs track artist comparisons to "compute" whether an album is a compilation? If that was the case, how does one flag an embedded cuesheet as a compilation? I'm not seeing a definition for a "compilation" command in the cuesheet spec at https://wiki.hydrogenaud.io/index.php?title=Cue_sheet Or am I not understanding what the intent of this commit was? gharris999's Profile: http://forums.slimdevices.com/member.php?userid=115 View this thread: http://forums.slimdevices.com/showthread.php?t=115184 ___ beta mailing list beta@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/beta
Re: [SlimDevices: Beta] LMS 8.3 and Various Artists
gharris999 wrote: > I'm late to the party in terms of using 8.3. I've just cloned the repo > this evening and scanned my music library. I can't seem to get my > compilation albums to show up under: > > Genres->Genre Name->Various Artists > > ..i.e. there's no "Various Artists" in the list of artists for any > genre. > > In the "My Music" settings, I've enabled: > > Use single, configurable list of artists > > ..and.. > > Group compilation albums together. > > Am I doing something wrong here, or is this a bug? Various Artists appears at the top of the Artists list for any genre for me and I have the same settings in "My Music". I didn't install by cloning the repo. Sent from my Pixel 3a using Tapatalk slartibartfast's Profile: http://forums.slimdevices.com/member.php?userid=35609 View this thread: http://forums.slimdevices.com/showthread.php?t=115184 ___ beta mailing list beta@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/beta