Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [46643] trunk/blender/source/blender/ makesrna/intern/rna_sequencer_api.c: SequenceElements.pop() -- added 'index ' argument inste
This should really use 1-2 memcpy calls rather then looping over
elements and calling strcpy.
The original width and height are currently not copied - and if any
new elements are added we'd have to remember to add them here too.
On Mon, May 14, 2012 at 11:32 PM, Dan Eicher dan.eic...@gmail.com wrote:
Revision: 46643
http://projects.blender.org/scm/viewvc.php?view=revroot=bf-blenderrevision=46643
Author: dna
Date: 2012-05-14 21:32:35 + (Mon, 14 May 2012)
Log Message:
---
SequenceElements.pop() -- added 'index' argument instead of just chopping off
the last element
Modified Paths:
--
trunk/blender/source/blender/makesrna/intern/rna_sequencer_api.c
Modified: trunk/blender/source/blender/makesrna/intern/rna_sequencer_api.c
===
--- trunk/blender/source/blender/makesrna/intern/rna_sequencer_api.c
2012-05-14 20:59:08 UTC (rev 46642)
+++ trunk/blender/source/blender/makesrna/intern/rna_sequencer_api.c
2012-05-14 21:32:35 UTC (rev 46643)
@@ -316,19 +316,34 @@
return se;
}
-static void rna_SequenceElements_pop(ID *id, Sequence *seq, ReportList
*reports)
+static void rna_SequenceElements_pop(ID *id, Sequence *seq, ReportList
*reports, int index)
{
+ int i;
Scene *scene = (Scene *)id;
+ StripElem *new_seq, *se;
if (seq-len == 1) {
BKE_report(reports, RPT_ERROR, SequenceElements.pop: can not
pop the last element);
return;
}
- /* just chop off the end ...what could possibly go wrong? */
- seq-strip-stripdata = MEM_reallocN(seq-strip-stripdata,
sizeof(StripElem) * (seq-len - 1));
+ if (seq-len = index) {
+ BKE_report(reports, RPT_ERROR, SequenceElements.pop: index
out of range);
+ return;
+ }
+
+ new_seq = MEM_callocN(sizeof(StripElem) * (seq-len - 1),
SequenceElements_pop);
seq-len--;
+ for (i = 0, se = seq-strip-stripdata; i seq-len; i++, se++) {
+ if (i == index)
+ se++;
+ BLI_strncpy(new_seq[i].name, se-name, sizeof(se-name));
+ }
+
+ MEM_freeN(seq-strip-stripdata);
+ seq-strip-stripdata = new_seq;
+
calc_sequence_disp(scene, seq);
WM_main_add_notifier(NC_SCENE | ND_SEQUENCER, scene);
@@ -379,6 +394,8 @@
func = RNA_def_function(srna, pop, rna_SequenceElements_pop);
RNA_def_function_flag(func, FUNC_USE_REPORTS | FUNC_USE_SELF_ID);
RNA_def_function_ui_description(func, Pop an image off the
collection);
+ parm = RNA_def_int(func, index, 0, 0, INT_MAX, , Index of image
to remove, 0, INT_MAX);
+ RNA_def_property_flag(parm, PROP_REQUIRED);
}
void RNA_api_sequences(BlenderRNA *brna, PropertyRNA *cprop)
___
Bf-blender-cvs mailing list
bf-blender-...@blender.org
http://lists.blender.org/mailman/listinfo/bf-blender-cvs
--
- Campbell
___
Bf-committers mailing list
Bf-committers@blender.org
http://lists.blender.org/mailman/listinfo/bf-committers
[Bf-committers] Translators aid
Hi all, I think that many translators are having the same problem: English language is contextual and it has countless number of terms that are having completely different meaning in different contexts. Because of that, It's very hard to translate many Blender terms to my language (Croatian) if one doesn't know exact context (where that line actually appears in the blender UI). And that context isn't visible in .po file. It would be very useful if we could right click on a label, a button or a drop box item an select Translate this don't you think? I've talked with Campbell about that problem some time ago and he suggested that I should post a suggestion/request to this list (bf-translators) but I'm sending to bf-commiters to. Implementation of that function shouldn't be too hard since we already have stuff like Online Python Reference. Would it be possible to create some addon that could load predefined .po file in blender's text editor at referenced line (like Edit Source does with python files)? Best regards, Damir ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [46643] trunk/blender/source/blender/ makesrna/intern/rna_sequencer_api.c: SequenceElements.pop() -- added 'index ' argument inste
IIRC I just took the code from the copy operator and used that. It'll be a few days before I can get around to this since I'm on the road helping my sister move so not much time. Dan ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [46569] trunk/blender/source/blender/ makesrna/intern/rna_tracking.c: reworded tooltip for Tripod Motion button; fixing spelling a
It's not actually more clear now and messes up some things. Like solver does not do track, it does solve or reconstruct. I'd prefer to stick to strict terminology usage, otherwise terms are becoming to overheaded. Also tripod solver does nothing with camera position -- it's arbitrary. Only relative camera movement is being solved. On Sat, May 12, 2012 at 10:31 AM, Ed Halley e...@halley.cc wrote: Revision: 46569 http://projects.blender.org/scm/viewvc.php?view=revroot=bf-blenderrevision=46569 Author: halley Date: 2012-05-12 04:31:03 + (Sat, 12 May 2012) Log Message: --- reworded tooltip for Tripod Motion button; fixing spelling and making more clear Modified Paths: -- trunk/blender/source/blender/makesrna/intern/rna_tracking.c Modified: trunk/blender/source/blender/makesrna/intern/rna_tracking.c === --- trunk/blender/source/blender/makesrna/intern/rna_tracking.c 2012-05-12 03:50:44 UTC (rev 46568) +++ trunk/blender/source/blender/makesrna/intern/rna_tracking.c 2012-05-12 04:31:03 UTC (rev 46569) @@ -611,7 +611,7 @@ prop = RNA_def_property(srna, use_tripod_solver, PROP_BOOLEAN, PROP_NONE); RNA_def_property_clear_flag(prop, PROP_ANIMATABLE); RNA_def_property_boolean_sdna(prop, NULL, motion_flag, TRACKING_MOTION_TRIPOD); - RNA_def_property_ui_text(prop, Tripod Motion, Tracking footage is shooted by tripod camera and should use special sovler for this); + RNA_def_property_ui_text(prop, Tripod Motion, Use special solver to track a stable camera position, such as a tripod); /* limit frames */ prop = RNA_def_property(srna, default_frames_limit, PROP_INT, PROP_NONE); ___ Bf-blender-cvs mailing list bf-blender-...@blender.org http://lists.blender.org/mailman/listinfo/bf-blender-cvs -- With best regards, Sergey Sharybin ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Change of MinGW64 compiler
Hi, this error message says that, in fact, there is almost no library present in your system. Did you change the name or path of your lib folder somehow? Did you change python version or bitness? Blender works fine here with default arguments and the builder looks like it's working too. ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Change of MinGW64 compiler
hi i found the problem, i had the mingw32 in my env. path with the mingw64 provided also. thanks for helping, sorry for bothering :) Regards Yousef Harfoush ba...@msn.com Date: Wed, 6 Jun 2012 14:10:21 +0300 From: kal...@gmail.com To: bf-committers@blender.org Subject: Re: [Bf-committers] Change of MinGW64 compiler Hi, this error message says that, in fact, there is almost no library present in your system. Did you change the name or path of your lib folder somehow? Did you change python version or bitness? Blender works fine here with default arguments and the builder looks like it's working too. ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
