Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [56475] trunk/blender/source/blender/ makesrna/intern/rna_wm.c: Fix #35157: export key configuration did not export text input eve
Ah ok, it seems the idea was to make text input a proper event for operators. I agree that would be nice to solve once, but for key configuration I think this simple fix is fine. Brecht. On Fri, May 3, 2013 at 5:56 AM, IRIE Shinsuke irieshins...@yahoo.co.jp wrote: Hi Brecht, I'd already sent the similar patch to Campbell to ask him if the fix is appropriate, but he discussed with Ton and Ton wanted to investigate further if there is a better way to manage these cases. Can you discuss this issue with Campbell and Ton? IRIE Shinsuke 13/05/03, Brecht Van Lommel wrote: Revision: 56475 http://projects.blender.org/scm/viewvc.php?view=revroot=bf-blenderrevision=56475 Author: blendix Date: 2013-05-02 19:43:52 + (Thu, 02 May 2013) Log Message: --- Fix #35157: export key configuration did not export text input events correctly. Modified Paths: -- trunk/blender/source/blender/makesrna/intern/rna_wm.c Modified: trunk/blender/source/blender/makesrna/intern/rna_wm.c === --- trunk/blender/source/blender/makesrna/intern/rna_wm.c 2013-05-02 17:55:17 UTC (rev 56474) +++ trunk/blender/source/blender/makesrna/intern/rna_wm.c 2013-05-02 19:43:52 UTC (rev 56475) @@ -124,6 +124,11 @@ {0, NULL, 0, NULL, NULL} }; +EnumPropertyItem event_textinput_type_items[] = { + {KM_TEXTINPUT, TEXTINPUT, 0, Text Input, }, + {0, NULL, 0, NULL, NULL} +}; + EnumPropertyItem event_ndof_type_items[] = { {NDOF_MOTION, NDOF_MOTION, 0, Motion, }, /* buttons on all 3dconnexion devices */ @@ -319,6 +324,8 @@ {MEDIAFIRST, MEDIA_FIRST, 0, Media First, }, {MEDIALAST, MEDIA_LAST, 0, Media Last, }, {0, , 0, NULL, NULL}, + {KM_TEXTINPUT, TEXTINPUT, 0, Text Input, }, + {0, , 0, NULL, NULL}, {WINDEACTIVATE, WINDOW_DEACTIVATE, 0, Window Deactivate, }, {TIMER, TIMER, 0, Timer, }, {TIMER0, TIMER0, 0, Timer 0, }, @@ -664,6 +671,7 @@ if (map_type == KMI_TYPE_TWEAK) return event_tweak_type_items; if (map_type == KMI_TYPE_TIMER) return event_timer_type_items; if (map_type == KMI_TYPE_NDOF) return event_ndof_type_items; + if (map_type == KMI_TYPE_TEXTINPUT) return event_textinput_type_items; else return event_type_items; } ___ Bf-blender-cvs mailing list bf-blender-...@blender.org http://lists.blender.org/mailman/listinfo/bf-blender-cvs ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [56475] trunk/blender/source/blender/ makesrna/intern/rna_wm.c: Fix #35157: export key configuration did not export text input eve
Hi Brecht, I'd already sent the similar patch to Campbell to ask him if the fix is appropriate, but he discussed with Ton and Ton wanted to investigate further if there is a better way to manage these cases. Can you discuss this issue with Campbell and Ton? IRIE Shinsuke 13/05/03, Brecht Van Lommel wrote: Revision: 56475 http://projects.blender.org/scm/viewvc.php?view=revroot=bf-blenderrevision=56475 Author: blendix Date: 2013-05-02 19:43:52 + (Thu, 02 May 2013) Log Message: --- Fix #35157: export key configuration did not export text input events correctly. Modified Paths: -- trunk/blender/source/blender/makesrna/intern/rna_wm.c Modified: trunk/blender/source/blender/makesrna/intern/rna_wm.c === --- trunk/blender/source/blender/makesrna/intern/rna_wm.c 2013-05-02 17:55:17 UTC (rev 56474) +++ trunk/blender/source/blender/makesrna/intern/rna_wm.c 2013-05-02 19:43:52 UTC (rev 56475) @@ -124,6 +124,11 @@ {0, NULL, 0, NULL, NULL} }; +EnumPropertyItem event_textinput_type_items[] = { + {KM_TEXTINPUT, TEXTINPUT, 0, Text Input, }, + {0, NULL, 0, NULL, NULL} +}; + EnumPropertyItem event_ndof_type_items[] = { {NDOF_MOTION, NDOF_MOTION, 0, Motion, }, /* buttons on all 3dconnexion devices */ @@ -319,6 +324,8 @@ {MEDIAFIRST, MEDIA_FIRST, 0, Media First, }, {MEDIALAST, MEDIA_LAST, 0, Media Last, }, {0, , 0, NULL, NULL}, + {KM_TEXTINPUT, TEXTINPUT, 0, Text Input, }, + {0, , 0, NULL, NULL}, {WINDEACTIVATE, WINDOW_DEACTIVATE, 0, Window Deactivate, }, {TIMER, TIMER, 0, Timer, }, {TIMER0, TIMER0, 0, Timer 0, }, @@ -664,6 +671,7 @@ if (map_type == KMI_TYPE_TWEAK) return event_tweak_type_items; if (map_type == KMI_TYPE_TIMER) return event_timer_type_items; if (map_type == KMI_TYPE_NDOF) return event_ndof_type_items; + if (map_type == KMI_TYPE_TEXTINPUT) return event_textinput_type_items; else return event_type_items; } ___ Bf-blender-cvs mailing list bf-blender-...@blender.org http://lists.blender.org/mailman/listinfo/bf-blender-cvs ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers