Re: Bind 9.7.0-P2 Bus Error - Solaris 9

2010-06-15 Thread b19141
At Mon, 14 Jun 2010 09:06:50 -0500 (CDT),
b19...@anl.gov wrote:

 This morning on a Solaris 9 system, I issued these comands:

JINMEI Tatuya /  jin...@isc.org replied:

 I believe I found the cause of the bug.  Please try the patch copied
 below.

I tested the patch on Solaris 9 and 10, and no core files were
produced.  I tested only this one command:

 dig cnnet.upr.edu +trace

--
Barry S. Finkel
Computing and Information Systems Division
Argonne National Laboratory  Phone:+1 (630) 252-7277
9700 South Cass Avenue   Facsimile:+1 (630) 252-4601
Building 240, Room 5.B.8 Internet: bsfin...@anl.gov
Argonne, IL   60439-4828 IBMMAIL:  I1004994
___
bind-users mailing list
bind-users@lists.isc.org
https://lists.isc.org/mailman/listinfo/bind-users


Re: Bind 9.7.0-P2 Bus Error - Solaris 9

2010-06-14 Thread Gregory Hicks

 From: b19...@anl.gov
 To: bind-users@lists.isc.org
 Subject: Re: Bind 9.7.0-P2 Bus Error - Solaris 9
 Date: Mon, 14 Jun 2010 13:53:13 -0500 (CDT)
 
 b19141 This morning on a Solaris 9 system, I issued these comands:
 b19141 titania% dig cnnet.upr.edu
 b19141 ;  DiG 9.7.0-P1  cnnet.upr.edu
 [...]
 b19141 Bus Error (core dumped)
 
 ebers...@isc.org (Paul Ebersman) replied:
 
 Tried to repro on ubuntu and mac os with this bind version. Unless I try
 to control-C out, I can't repro this. If left to run, dig just times out
 (all three NS are unreachable for that zone, at least from my machines).
 
 Did you try to abort the +trace before it timed out?
 
 I tried again a few minutes ago, and I got the same
 
  Bus Error (core dumped)
 
 I did not hit control-c.

Well, I don't get a core-dump but I DO get connection timed out...

metis% cd incoming/bind/bind-9.7*1
/home/ghicks/incoming/bind/bind-9.7.0-P1
metis% cd bin/dig
/home/ghicks/incoming/bind/bind-9.7.0-P1/bin/dig
metis% ./dig cnnet.upr.edu

;  DiG 9.7.0-P1  cnnet.upr.edu
;; global options: +cmd
;; connection timed out; no servers could be reached

metis% ./dig cnnet.upr.edu +trace

;  DiG 9.7.0-P1  cnnet.upr.edu +trace
;; global options: +cmd
.   283923  IN  NS  f.root-servers.net.
.   283923  IN  NS  d.root-servers.net.
.   283923  IN  NS  h.root-servers.net.
.   283923  IN  NS  b.root-servers.net.
.   283923  IN  NS  e.root-servers.net.
.   283923  IN  NS  m.root-servers.net.
.   283923  IN  NS  c.root-servers.net.
.   283923  IN  NS  j.root-servers.net.
.   283923  IN  NS  k.root-servers.net.
.   283923  IN  NS  l.root-servers.net.
.   283923  IN  NS  a.root-servers.net.
.   283923  IN  NS  i.root-servers.net.
.   283923  IN  NS  g.root-servers.net.
;; Received 336 bytes from 127.0.0.1#53(127.0.0.1) in 10 ms

edu.172800  IN  NS  e.gtld-servers.net.
edu.172800  IN  NS  a.gtld-servers.net.
edu.172800  IN  NS  d.gtld-servers.net.
edu.172800  IN  NS  f.gtld-servers.net.
edu.172800  IN  NS  c.gtld-servers.net.
edu.172800  IN  NS  l.gtld-servers.net.
edu.172800  IN  NS  g.gtld-servers.net.
;; Received 299 bytes from 192.228.79.201#53(b.root-servers.net) in 27 ms

upr.edu.172800  IN  NS  dns1.uprm.edu.
upr.edu.172800  IN  NS  dns2.uprm.edu.
upr.edu.172800  IN  NS  ns1.upr.edu.
upr.edu.172800  IN  NS  upr1.upr.clu.edu.
;; Received 183 bytes from 192.35.51.30#53(f.gtld-servers.net) in 19 ms

cnnet.upr.edu.  28800   IN  NS  NS1.cnnet.upr.edu.
cnnet.upr.edu.  28800   IN  NS  GOLIATH.cnnet.upr.edu.
cnnet.upr.edu.  28800   IN  NS  NS3.cnnet.upr.edu.
;; Received 137 bytes from 136.145.5.66#53(ns1.upr.edu) in 118 ms

;; connection timed out; no servers could be reached
metis% 
-
Gregory Hicks   | Principal Systems Engineer
| Direct:   408.569.7928

People sleep peaceably in their beds at night only because rough men
stand ready to do violence on their behalf -- George Orwell

The price of freedom is eternal vigilance.  -- Thomas Jefferson

The best we can hope for concerning the people at large is that they
be properly armed. --Alexander Hamilton

___
bind-users mailing list
bind-users@lists.isc.org
https://lists.isc.org/mailman/listinfo/bind-users


Re: Bind 9.7.0-P2 Bus Error - Solaris 9

2010-06-14 Thread JINMEI Tatuya / 神明達哉
At Mon, 14 Jun 2010 09:06:50 -0500 (CDT),
b19...@anl.gov wrote:

 Do I need to file an official bug report?

Yes, please.

---
JINMEI, Tatuya
Internet Systems Consortium, Inc.
___
bind-users mailing list
bind-users@lists.isc.org
https://lists.isc.org/mailman/listinfo/bind-users


Re: Bind 9.7.0-P2 Bus Error - Solaris 9

2010-06-14 Thread JINMEI Tatuya / 神明達哉
At Mon, 14 Jun 2010 09:06:50 -0500 (CDT),
b19...@anl.gov wrote:

 This morning on a Solaris 9 system, I issued these comands:

I believe I found the cause of the bug.  Please try the patch copied
below.

---
JINMEI, Tatuya
Internet Systems Consortium, Inc.

Index: dighost.c
===
RCS file: /proj/cvs/prod/bind9/bin/dig/dighost.c,v
retrieving revision 1.330
diff -u -r1.330 dighost.c
--- dighost.c   18 May 2010 02:38:10 -  1.330
+++ dighost.c   15 Jun 2010 00:49:24 -
@@ -2401,6 +2401,15 @@
  isc_result_totext(ISC_R_NOMEMORY));
}
isc_task_send(global_task, event);
+
+   /*
+* The timer may have expired if, for example, get_address() takes
+* long time and the timer was running on a different thread.
+* We need to cancel the possible timeout event not to confuse
+* ourselves due to the duplicate events.
+*/
+   if (l-timer != NULL)
+   isc_timer_detach(l-timer);
 }
 
 
@@ -2424,7 +2433,7 @@
query-waiting_connect = ISC_TRUE;
query-lookup-current_query = query;
result = get_address(query-servname, port, query-sockaddr);
-   if (result == ISC_R_NOTFOUND) {
+   if (result != ISC_R_SUCCESS) {
/*
 * This servname doesn't have an address.  Try the next server
 * by triggering an immediate 'timeout' (we lie, but the effect
@@ -2506,7 +2515,7 @@
/* XXX Check the sense of this, need assertion? */
query-waiting_connect = ISC_FALSE;
result = get_address(query-servname, port, query-sockaddr);
-   if (result == ISC_R_NOTFOUND) {
+   if (result != ISC_R_SUCCESS) {
/* This servname doesn't have an address. */
force_timeout(l, query);
return;
___
bind-users mailing list
bind-users@lists.isc.org
https://lists.isc.org/mailman/listinfo/bind-users