Re: Follow up question on "next hop self"

2020-01-06 Thread Ondrej Zajicek
On Mon, Jan 06, 2020 at 06:25:30PM +, Neil Jerram wrote:
> On Sun, Dec 22, 2019 at 3:03 PM Ondrej Zajicek 
> wrote:
> 
> > On Sat, Dec 21, 2019 at 12:39:43AM +0100, Nico Schottelius wrote:
> > > I have had a look at OSPF, but for our relatively simple network it
> > > looks like an overkill. Do you have any other recommendations for
> > > what to run the IGP with instead?
> > >
> > > The main reason I so far tried to stay on iBGP only is to reduce
> > > complexity.
> >
> > Well, you can run just IBGP, if you use direct + 'next hop self' options,
> > which should be OK in your simple topology.
> >
> 
> According to my understanding of the BIRD code, 'next hop self' is only
> relevant when exporting a locally originated route to a BGP peer.  So,
> assuming the original question was about what happens on R1 and R2, I would
> not expect it to be relevant at all.   Is that right?

Option 'next hop self' is relevant in both exporting locally originated
route to a BGP (i.e. a route without existing bgp_next_hop attribute) and
exporting route from BGP to another BGP (i.e. a route with existing
bgp_next_hop attribute).

See bgp_use_next_hop() and bgp_use_gateway() functions and their usage.

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."


Re: Problem with if statements containing && or || expressions

2020-01-06 Thread Ondrej Zajicek
On Mon, Jan 06, 2020 at 11:49:15AM +0100, mikma.b...@lists.m7n.se wrote:
> On 2020-01-06 04:26, Ondrej Zajicek wrote:
> > On Sat, Jan 04, 2020 at 09:46:52PM +0100, mikma.b...@lists.m7n.se wrote:
> > > Hello,
> > > 
> > > I'm having problems with if statements containing &&, or ||. Why do the
> > > config file below cause the following error?
> > 
> > Hello
> > 
> > Works for me in current devel branch. In which version do you experience
> > the error? 2.0.7 or older?
> 
> I used the current devel branch (commit cc75b3e1). And I have built it on
> three systems (all x86_64), Ubuntu 18.04, 19.10, and CentOS 7.7, all with
> the same error when running the test case.

Thanks, fixed:

https://gitlab.labs.nic.cz/labs/bird/commit/ef8c45749c82e246d477ea4d7f749668a9c7e9ee

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."


Re: Follow up question on "next hop self"

2020-01-06 Thread Neil Jerram
On Sun, Dec 22, 2019 at 3:03 PM Ondrej Zajicek 
wrote:

> On Sat, Dec 21, 2019 at 12:39:43AM +0100, Nico Schottelius wrote:
> > I have had a look at OSPF, but for our relatively simple network it
> > looks like an overkill. Do you have any other recommendations for
> > what to run the IGP with instead?
> >
> > The main reason I so far tried to stay on iBGP only is to reduce
> > complexity.
>
> Well, you can run just IBGP, if you use direct + 'next hop self' options,
> which should be OK in your simple topology.
>

According to my understanding of the BIRD code, 'next hop self' is only
relevant when exporting a locally originated route to a BGP peer.  So,
assuming the original question was about what happens on R1 and R2, I would
not expect it to be relevant at all.   Is that right?


Re: Problem with if statements containing && or || expressions

2020-01-06 Thread Ondrej Zajicek
On Mon, Jan 06, 2020 at 11:49:15AM +0100, mikma.b...@lists.m7n.se wrote:
> On 2020-01-06 04:26, Ondrej Zajicek wrote:
> > On Sat, Jan 04, 2020 at 09:46:52PM +0100, mikma.b...@lists.m7n.se wrote:
> > > Hello,
> > > 
> > > I'm having problems with if statements containing &&, or ||. Why do the
> > > config file below cause the following error?
> > 
> > Hello
> > 
> > Works for me in current devel branch. In which version do you experience
> > the error? 2.0.7 or older?
> 
> 
> I used the current devel branch (commit cc75b3e1). And I have built it on
> three systems (all x86_64), Ubuntu 18.04, 19.10, and CentOS 7.7, all with
> the same error when running the test case.

Thanks, can replicate it. Expect it to be parse-time error but it is
actuall runtime error.

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."


Re: Problem with if statements containing && or || expressions

2020-01-06 Thread mikma . bird

On 2020-01-06 04:26, Ondrej Zajicek wrote:

On Sat, Jan 04, 2020 at 09:46:52PM +0100, mikma.b...@lists.m7n.se wrote:

Hello,

I'm having problems with if statements containing &&, or ||. Why do the
config file below cause the following error?


Hello

Works for me in current devel branch. In which version do you experience
the error? 2.0.7 or older?



I used the current devel branch (commit cc75b3e1). And I have built it 
on three systems (all x86_64), Ubuntu 18.04, 19.10, and CentOS 7.7, all 
with the same error when running the test case.


I have made a "git bisect" now and found 10c4cd96 is the first bad 
commit using the same test case. After reverting commit 10c4cd96 I get 
"Success" on the test case.


Result from git bisect:

10c4cd9677555e88a4ac8c95784aa281655e3326 is the first bad commit
commit 10c4cd9677555e88a4ac8c95784aa281655e3326
Author: Ondrej Zajicek (work) 
Date:   Tue Nov 5 15:14:57 2019 +0100

Filter: Add type info for more instructions

:04 04 6447441306f4d6300986d78eac3efeb92bde656c 
2bbef7a1e0d4c6e3d7b61e2f0700fba04a3917ba M	filter


/Mikael