Re: [PATCH] IPv4 over IPv6 nexthop support on FreeBSD
> On 15 Jun 2023, at 15:33, Ondrej Zajicek wrote: > > On Wed, Jun 14, 2023 at 02:54:49PM +0200, Luiz Amaral wrote: >> Hello, >>> I did not find any other patch (for Netlink) in that thread, but i could >>> try to hack it myself. >> >> Here is the patch as an attachment. > > Merged. It breaks build for some very old Linux systems (e.g. Debian 8, > CentOS 7), as HAVE_MPLS_KERNEL also checks for struct rtvia existence, > but these systems have obsolete/unsupported kernel versions anyways. > > There is a question how handle feature divergence (primarily divergence > in which structures and enum values are defined for compile-time) in > Netlink between Linux and FreeBSD. I would prefer to not have autoconf > test for each such feature. For example we could probably remove > HAVE_MPLS_KERNEL altogether just for Linux (as the check is unnecessary > for non-obsolete kernels, but i am not sure about FreeBSD headers). I understand the pain. To add to this, the feature existence doesn’t always mean the full feature parity. For example, current nexthop/nexthop group implementation doesn’t have the support for adding resilient nexthop groups. The only solution I could think of is adding a bit of ugliness to the headers and have the defines for each enum item (for commands) and a separate define for the structures / small enums. Then the features could be defined in the sysdep//netlink-sys.h . What do you think? > > -- > Elen sila lumenn' omentielvo > > Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org) > OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) > "To err is human -- to blame it on a computer is even more so."
Re: [PATCH] IPv4 over IPv6 nexthop support on FreeBSD
> On 14 Jun 2023, at 13:41, Ondrej Zajicek wrote: > > On Wed, Jun 14, 2023 at 11:14:55AM +0100, Alexander Chernikov wrote: >> Hi Ondrej, >> >> Could you please consider merging IPv4 over IPv6 support for FreeBSD Netlink >> as well? >> It seems like the patch slipped through the cracks :-( > > Hi > > I did not find any other patch (for Netlink) in that thread, but i could > try to hack it myself. Posted as https://people.freebsd.org/~melifaro/bird_rfc5549_netlink.diff Please note that the authorship should go to "Luiz Amaralhttp://luiz.eng.br/>>" > > > > -- > Elen sila lumenn' omentielvo > > Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org) > OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) > "To err is human -- to blame it on a computer is even more so."
RE: [PATCH] IPv4 over IPv6 nexthop support on FreeBSD
Hi Ondrej, Could you please consider merging IPv4 over IPv6 support for FreeBSD Netlink as well? It seems like the patch slipped through the cracks :-( Sorry for not replying to the thread, it got purged by my email client. The original message: https://bird.network.cz/pipermail/bird-users/2023-April/016857.html /Alexander
Re: https://github.com/CZ-NIC/bird repo sync
> On 21 Feb 2023, at 11:16, Ondrej Zajicek wrote: > > On Tue, Feb 21, 2023 at 10:39:15AM +, Alexander Chernikov wrote: >> Dear bird team, >> >> The GitHub cz-nic/bird repository mirror looks stale - the last commit there >> is from October 5, 2020? >> Is this intentional? > > Hello > > Well, i was not even aware of such mirror. At least it seems it is an > official CZ.NIC mirror. I will ask colleagues who is responsible for it. Thank you! > >> If not, would it be possible to make it track the current bird git repo? >> One of the big benefits of GitHub (for me) is an easy standard >> mechanism of tracking the changes - everyone with GitHub account can >> subscribe for the commits notification with a single click. > > Could that be done with our official git repo on our Gitlab instance: > https://gitlab.nic.cz/labs/bird ? Yes, it’s also possible (and thanks to Gitlab, one can do it with github account). > > -- > Elen sila lumenn' omentielvo > > Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org) > OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) > "To err is human -- to blame it on a computer is even more so."
https://github.com/CZ-NIC/bird repo sync
Dear bird team, The GitHub cz-nic/bird repository mirror looks stale - the last commit there is from October 5, 2020? Is this intentional? If not, would it be possible to make it track the current bird git repo? One of the big benefits of GitHub (for me) is an easy standard mechanism of tracking the changes - everyone with GitHub account can subscribe for the commits notification with a single click. /Alexander
