Re: [blfs-book] r19353 - in trunk/BOOK: . introduction/welcome x/lib
Wayne Blaszczyk via blfs-book wrote: On Sun, 2017-10-22 at 13:02 -0500, DJ Lucas via blfs-book wrote: On 10/22/2017 12:32 PM, Armin K. via blfs-book wrote: On Sun, 2017-10-22 at 12:18 -0500, Bruce Dubbs wrote: DJ Lucas via blfs-book wrote: On 10/22/2017 04:05 AM, Armin K. via blfs-book wrote: -make +meson --prefix /usr $PWD build && +cd build && +ninja Make these two into "ninja -C build", same for install cmd. Will do, thanks. Actually, I'd rather not. It only removes one line at the expense of making two lines slightly more complex. What we have now is similar to cmake. If we want to make things more consistent, we would be better off with: mkdir build cdbuild meson .. ninja ninja install -- Bruce Actually, I like this one more. It's what I use on my end. I would not say it's slightly complex, after all it's just 9 extra chars (including whitespaces)! Actually, it's one less character and I like it better aesthetically as well, but just discussed with Bruce in PM. After said discussion, I'm leaning toward Bruce's thinking. Consistency with other parts of the book and simplicity vs the slightly shorter command line. Look at it this way: meson $PWD build && ninja -C build && ninja -C build install vs. mkdir build && cd build && meson .. && ninja && ninja install Now, it is three commands vs five, but muscle memory has the advantage with Bruce's syntax. We are really picking nits here, though. -- DJ I'll just put my two cents worth. The first option does not require a $PWD. The following should work just as fine: meson build && ninja -C build && ninja -C build install I've been personally doing the following: meson build && cd build && ninja && ninja install The other question should be meson --prefix /usr vs meson --prefix=/usr Personally, I've been doing the later as it is more consistent with theother build systems. I noticed that currently in the book, you have no equals for systemd andan equals for fuse3. A couple of comments... We have been using the space and not = for meson because that is what --help indicates the syntax is, but using the = is still valid and would be more consistent with autotools and cmake. I think that I like this idea. There is no need for $PWD if you are already in build. Most users use copy/paste, so the difference in the command sequences there is not significant in that respect. What is significant is how the reader interprets the command sequence. IMO using 'mkdir;cd;meson ..' is similar to cmake and sometimes autotools and provides consistency. -- Bruce -- http://lists.linuxfromscratch.org/listinfo/blfs-book FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-book] r19353 - in trunk/BOOK: . introduction/welcome x/lib
On Sun, 2017-10-22 at 13:02 -0500, DJ Lucas via blfs-book wrote: > > On 10/22/2017 12:32 PM, Armin K. via blfs-book wrote: > > On Sun, 2017-10-22 at 12:18 -0500, Bruce Dubbs wrote: > > > DJ Lucas via blfs-book wrote: > > > > > > > > > > > > On 10/22/2017 04:05 AM, Armin K. via blfs-book wrote: > > > > > > > > > > -make > > > > > > +meson --prefix /usr $PWD build && > > > > > > +cd build && > > > > > > +ninja > > > > > > > > > > > > > > > > Make these two into "ninja -C build", same for install cmd. > > > > > > > > Will do, thanks. > > > > > > Actually, I'd rather not. It only removes one line at the expense > > > of > > > making two lines slightly more complex. What we have now is similar > > > to cmake. > > > > > > If we want to make things more consistent, we would be better off > > > with: > > > > > > mkdir build > > > cdbuild > > > meson .. > > > ninja > > > ninja install > > > > > >-- Bruce > > > > > > > Actually, I like this one more. It's what I use on my end. I would not > > say it's slightly complex, after all it's just 9 extra chars (including > > whitespaces)! > > > > Actually, it's one less character and I like it better aesthetically as > well, but just discussed with Bruce in PM. After said discussion, I'm > leaning toward Bruce's thinking. Consistency with other parts of the > book and simplicity vs the slightly shorter command line. Look at it > this way: > > meson $PWD build && ninja -C build && ninja -C build install > vs. > mkdir build && cd build && meson .. && ninja && ninja install > > Now, it is three commands vs five, but muscle memory has the advantage > with Bruce's syntax. We are really picking nits here, though. > > -- DJ > I'll just put my two cents worth. The first option does not require a $PWD. The following should work just as fine: meson build && ninja -C build && ninja -C build install I've been personally doing the following: meson build && cd build && ninja && ninja install The other question should be meson --prefix /usr vs meson --prefix=/usr Personally, I've been doing the later as it is more consistent with the other build systems. I noticed that currently in the book, you have no equals for systemd and an equals for fuse3. Regards, Wayne. -- http://lists.linuxfromscratch.org/listinfo/blfs-book FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-book] r19353 - in trunk/BOOK: . introduction/welcome x/lib
On Sun, 2017-10-22 at 13:02 -0500, DJ Lucas wrote: > We are really picking nits here, though. > > -- DJ > Ah, the joys of working on group projects ... -- http://lists.linuxfromscratch.org/listinfo/blfs-book FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-book] r19353 - in trunk/BOOK: . introduction/welcome x/lib
On 10/22/2017 12:32 PM, Armin K. via blfs-book wrote: On Sun, 2017-10-22 at 12:18 -0500, Bruce Dubbs wrote: DJ Lucas via blfs-book wrote: On 10/22/2017 04:05 AM, Armin K. via blfs-book wrote: -make +meson --prefix /usr $PWD build && +cd build && +ninja Make these two into "ninja -C build", same for install cmd. Will do, thanks. Actually, I'd rather not. It only removes one line at the expense of making two lines slightly more complex. What we have now is similar to cmake. If we want to make things more consistent, we would be better off with: mkdir build cdbuild meson .. ninja ninja install -- Bruce Actually, I like this one more. It's what I use on my end. I would not say it's slightly complex, after all it's just 9 extra chars (including whitespaces)! Actually, it's one less character and I like it better aesthetically as well, but just discussed with Bruce in PM. After said discussion, I'm leaning toward Bruce's thinking. Consistency with other parts of the book and simplicity vs the slightly shorter command line. Look at it this way: meson $PWD build && ninja -C build && ninja -C build install vs. mkdir build && cd build && meson .. && ninja && ninja install Now, it is three commands vs five, but muscle memory has the advantage with Bruce's syntax. We are really picking nits here, though. -- DJ -- http://lists.linuxfromscratch.org/listinfo/blfs-book FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-book] r19353 - in trunk/BOOK: . introduction/welcome x/lib
On Sun, 2017-10-22 at 12:18 -0500, Bruce Dubbs wrote: > DJ Lucas via blfs-book wrote: > > > > > > On 10/22/2017 04:05 AM, Armin K. via blfs-book wrote: > > > > > > -make > > > > +meson --prefix /usr $PWD build && > > > > +cd build && > > > > +ninja > > > > > > > > > > Make these two into "ninja -C build", same for install cmd. > > > > Will do, thanks. > > Actually, I'd rather not. It only removes one line at the expense > of > making two lines slightly more complex. What we have now is similar > to cmake. > > If we want to make things more consistent, we would be better off > with: > > mkdir build > cdbuild > meson .. > ninja > ninja install > >-- Bruce > Actually, I like this one more. It's what I use on my end. I would not say it's slightly complex, after all it's just 9 extra chars (including whitespaces)! -- http://lists.linuxfromscratch.org/listinfo/blfs-book FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-book] r19353 - in trunk/BOOK: . introduction/welcome x/lib
DJ Lucas via blfs-book wrote: On 10/22/2017 04:05 AM, Armin K. via blfs-book wrote: -make +meson --prefix /usr $PWD build && +cd build && +ninja Make these two into "ninja -C build", same for install cmd. Will do, thanks. Actually, I'd rather not. It only removes one line at the expense of making two lines slightly more complex. What we have now is similar to cmake. If we want to make things more consistent, we would be better off with: mkdir build cdbuild meson .. ninja ninja install -- Bruce -- http://lists.linuxfromscratch.org/listinfo/blfs-book FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-book] r19353 - in trunk/BOOK: . introduction/welcome x/lib
On 10/22/2017 04:05 AM, Armin K. via blfs-book wrote: -make +meson --prefix /usr $PWD build && +cd build && +ninja Make these two into "ninja -C build", same for install cmd. Will do, thanks. --DJ -- http://lists.linuxfromscratch.org/listinfo/blfs-book FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-book] r19353 - in trunk/BOOK: . introduction/welcome x/lib
On 22.10.2017 10:38, via blfs-book wrote: Author: dj Date: Sun Oct 22 01:38:28 2017 New Revision: 19353 Log: Update to atk-2.26.1 and move to meson build. Fixes #9912. Modified: trunk/BOOK/introduction/welcome/changelog.xml trunk/BOOK/packages.ent trunk/BOOK/x/lib/atk.xml Modified: trunk/BOOK/introduction/welcome/changelog.xml == --- trunk/BOOK/introduction/welcome/changelog.xml Sun Oct 22 01:08:20 2017(r19352) +++ trunk/BOOK/introduction/welcome/changelog.xml Sun Oct 22 01:38:28 2017(r19353) @@ -46,6 +46,10 @@ October 22nd, 2017 + [dj] - Update to atk-2.26.1 and switch to meson build. Fixes + #9912. + + [dj] - Use Python3 by default in gobject-introspection. Modified: trunk/BOOK/packages.ent == --- trunk/BOOK/packages.ent Sun Oct 22 01:08:20 2017(r19352) +++ trunk/BOOK/packages.ent Sun Oct 22 01:38:28 2017(r19353) @@ -533,7 +533,7 @@ - + Modified: trunk/BOOK/x/lib/atk.xml == --- trunk/BOOK/x/lib/atk.xmlSun Oct 22 01:08:20 2017(r19352) +++ trunk/BOOK/x/lib/atk.xmlSun Oct 22 01:38:28 2017(r19353) @@ -6,10 +6,10 @@ - - - - + + + + ]> @@ -102,8 +102,9 @@ the following commands: -./configure --prefix=/usr && -make +meson --prefix /usr $PWD build && +cd build && +ninja Make these two into "ninja -C build", same for install cmd. This package does not come with a testsuite. @@ -113,7 +114,7 @@ Now, as the root user: -make install +ninja install -- http://lists.linuxfromscratch.org/listinfo/blfs-book FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
[blfs-book] r19353 - in trunk/BOOK: . introduction/welcome x/lib
Author: dj Date: Sun Oct 22 01:38:28 2017 New Revision: 19353 Log: Update to atk-2.26.1 and move to meson build. Fixes #9912. Modified: trunk/BOOK/introduction/welcome/changelog.xml trunk/BOOK/packages.ent trunk/BOOK/x/lib/atk.xml Modified: trunk/BOOK/introduction/welcome/changelog.xml == --- trunk/BOOK/introduction/welcome/changelog.xml Sun Oct 22 01:08:20 2017(r19352) +++ trunk/BOOK/introduction/welcome/changelog.xml Sun Oct 22 01:38:28 2017(r19353) @@ -46,6 +46,10 @@ October 22nd, 2017 + [dj] - Update to atk-2.26.1 and switch to meson build. Fixes + #9912. + + [dj] - Use Python3 by default in gobject-introspection. Modified: trunk/BOOK/packages.ent == --- trunk/BOOK/packages.ent Sun Oct 22 01:08:20 2017(r19352) +++ trunk/BOOK/packages.ent Sun Oct 22 01:38:28 2017(r19353) @@ -533,7 +533,7 @@ - + Modified: trunk/BOOK/x/lib/atk.xml == --- trunk/BOOK/x/lib/atk.xmlSun Oct 22 01:08:20 2017(r19352) +++ trunk/BOOK/x/lib/atk.xmlSun Oct 22 01:38:28 2017(r19353) @@ -6,10 +6,10 @@ - - - - + + + + ]> @@ -102,8 +102,9 @@ the following commands: -./configure --prefix=/usr && -make +meson --prefix /usr $PWD build && +cd build && +ninja This package does not come with a testsuite. @@ -113,7 +114,7 @@ Now, as the root user: -make install +ninja install -- http://lists.linuxfromscratch.org/listinfo/blfs-book FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
