Re: [blfs-dev] [blfs-book] r10104 - trunk/BOOK/general/graphlib

2012-05-07 Thread Andrew Benton
On Tue, 08 May 2012 01:18:48 +0100
"Armin K."  wrote:

> On 05/07/2012 06:48 PM, a...@linuxfromscratch.org wrote:
> > Author: andy
> > Date: 2012-05-07 10:48:52 -0600 (Mon, 07 May 2012)
> > New Revision: 10104
> >
> > -  and
> > +  or  and
> 
> This is not "or" ... GTK+3 is required for rsvg-view-3 and GTK+2 for the 
> engine. Also, cairo, gdk-pixbuf, glib, libcroco, libxml and pango are 
> really required for this one. I choose GTK+3 as required, but it can be 
> well set optional as GTK+2 was.
> 
> See http://git.gnome.org/browse/librsvg/tree/configure.in for the deps.

I have installed librsvg-2.36.1 on a system without Gtk 3. The build
failed without any Gtk installed but it succeeded without Gtk 3.
You need to learn to test the dependencies more thoroughly. Your work
cannot be trusted.

Andy
-- 
http://linuxfromscratch.org/mailman/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page


Re: [blfs-dev] [blfs-book] r10104 - trunk/BOOK/general/graphlib

2012-05-07 Thread Armin K.
On 05/08/2012 03:40 AM, Andrew Benton wrote:
> On Tue, 08 May 2012 01:18:48 +0100
> "Armin K."  wrote:
>
>> On 05/07/2012 06:48 PM, a...@linuxfromscratch.org wrote:
>>> Author: andy
>>> Date: 2012-05-07 10:48:52 -0600 (Mon, 07 May 2012)
>>> New Revision: 10104
>>>
>>> -   and
>>> +   or   and
>>
>> This is not "or" ... GTK+3 is required for rsvg-view-3 and GTK+2 for the
>> engine. Also, cairo, gdk-pixbuf, glib, libcroco, libxml and pango are
>> really required for this one. I choose GTK+3 as required, but it can be
>> well set optional as GTK+2 was.
>>
>> See http://git.gnome.org/browse/librsvg/tree/configure.in for the deps.
>
> I have installed librsvg-2.36.1 on a system without Gtk 3. The build
> failed without any Gtk installed but it succeeded without Gtk 3.
> You need to learn to test the dependencies more thoroughly. Your work
> cannot be trusted.
>
> Andy

As I said, GTK+3 is only required for rsvg-view-3, but it's still not 
"gtk3 or gtk2". I'll check it later. If you don't like my work, do it 
yourself - but make sure everything works before changing deps.
-- 
http://linuxfromscratch.org/mailman/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page


Re: [blfs-dev] [blfs-book] r10104 - trunk/BOOK/general/graphlib

2012-05-07 Thread Bruce Dubbs
Andrew Benton wrote:
> On Tue, 08 May 2012 01:18:48 +0100
> "Armin K."  wrote:
> 
>> On 05/07/2012 06:48 PM, a...@linuxfromscratch.org wrote:
>>> Author: andy
>>> Date: 2012-05-07 10:48:52 -0600 (Mon, 07 May 2012)
>>> New Revision: 10104
>>>
>>> -  and
>>> +  or  and
>> This is not "or" ... GTK+3 is required for rsvg-view-3 and GTK+2 for the 
>> engine. Also, cairo, gdk-pixbuf, glib, libcroco, libxml and pango are 
>> really required for this one. I choose GTK+3 as required, but it can be 
>> well set optional as GTK+2 was.
>>
>> See http://git.gnome.org/browse/librsvg/tree/configure.in for the deps.
> 
> I have installed librsvg-2.36.1 on a system without Gtk 3. The build
> failed without any Gtk installed but it succeeded without Gtk 3.
> You need to learn to test the dependencies more thoroughly. Your work
> cannot be trusted.

This comment is not called for.  Everyone makes mistakes in a complex 
environment like BLFS.  Armin has been putting in a tremendous effort.  You 
can't blow it off like that.  Lets work together with helpful comments to make 
everyone's work better.

   -- Bruce
-- 
http://linuxfromscratch.org/mailman/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page