[blfs-dev] EOG and librsvg
Hi, There is a weird error when building EOG if librsvg has not been installed. Configure detects correctly that librsvg is not there and does not set HAVE_RSVG. But then, in main.c, there is the line #if defined (HAVE_RSVG) && !LIB_RSVG_CHECK(2,35,1) which generates an error. It looks like the second statement is executed although the first one should be false, and since LIB_RSVG_CHECK is not defined, it expands to !(2,35,1), which triggers the error. According to the gcc/cpp doc, this should not happen. (well, I am not very comfortable with all that, since I destroyed the log when rebuilding, sorry). One possible workaround is to build librsvg first. So librsvg could be a required dep. Actually, IMHO, having EOG being able to read svg images should at least be recommended. Regards Pierre -- http://linuxfromscratch.org/mailman/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] EOG and librsvg
On 05/07/2012 02:58 PM, Pierre Labastie wrote: > Hi, > There is a weird error when building EOG if librsvg has not been installed. > Configure detects correctly that librsvg is not there and does not set > HAVE_RSVG. > > But then, in main.c, there is the line > #if defined (HAVE_RSVG)&& !LIB_RSVG_CHECK(2,35,1) > which generates an error. > > It looks like the second statement is executed although > the first one should be false, and since LIB_RSVG_CHECK is not > defined, it expands to !(2,35,1), which triggers > the error. According to the gcc/cpp doc, this should not happen. > (well, I am not very comfortable with all that, since > I destroyed the log when rebuilding, sorry). > > One possible workaround is to build librsvg first. So > librsvg could be a required dep. > > Actually, IMHO, having EOG being able to read svg > images should at least be recommended. > > Regards > Pierre I set it as recommended because some would argue that "it's not required dependency" ... -- http://linuxfromscratch.org/mailman/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] EOG and librsvg
On Tue, 08 May 2012 03:52:07 +0100 "Armin K." wrote: > I set it as recommended because some would argue that "it's not required > dependency" ... If Eog will not build without librsvg then it's a required dep. Andy -- http://linuxfromscratch.org/mailman/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] EOG and librsvg
On 05/08/2012 10:46 AM, Andrew Benton wrote: > On Tue, 08 May 2012 03:52:07 +0100 > "Armin K." wrote: > >> I set it as recommended because some would argue that "it's not required >> dependency" ... > > If Eog will not build without librsvg then it's a required dep. > > Andy Meh, still not required as I see http://git.gnome.org/browse/eog/tree/configure.ac?h=gnome-3-4 See line 269. If the problem persists, it should be reported to upstream. -- http://linuxfromscratch.org/mailman/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] EOG and librsvg
On Tue, 08 May 2012 10:38:38 +0100 "Armin K." wrote: > On 05/08/2012 10:46 AM, Andrew Benton wrote: > > On Tue, 08 May 2012 03:52:07 +0100 > > "Armin K." wrote: > > > >> I set it as recommended because some would argue that "it's not required > >> dependency" ... > > > > If Eog will not build without librsvg then it's a required dep. > > > > Andy > > Meh, still not required as I see > > http://git.gnome.org/browse/eog/tree/configure.ac?h=gnome-3-4 > > See line 269. > > If the problem persists, it should be reported to upstream. If Eog will not build without librsvg then it's a required dep. It's not a matter of opinion. Andy -- http://linuxfromscratch.org/mailman/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] EOG and librsvg
On 05/08/2012 12:53 PM, Andrew Benton wrote: > On Tue, 08 May 2012 10:38:38 +0100 > "Armin K." wrote: > >> On 05/08/2012 10:46 AM, Andrew Benton wrote: >>> On Tue, 08 May 2012 03:52:07 +0100 >>> "Armin K." wrote: >>> I set it as recommended because some would argue that "it's not required dependency" ... >>> >>> If Eog will not build without librsvg then it's a required dep. >>> >>> Andy >> >> Meh, still not required as I see >> >> http://git.gnome.org/browse/eog/tree/configure.ac?h=gnome-3-4 >> >> See line 269. >> >> If the problem persists, it should be reported to upstream. > > If Eog will not build without librsvg then it's a required dep. It's > not a matter of opinion. > > Andy I'll check it myself later. -- http://linuxfromscratch.org/mailman/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
