Re: unzip: make check modification
Tushar Teredesai wrote: Currently for testing unzip, the book includes the following commands: /sbin/ldconfig $PWD && make check This is wrong. We are modifying the linker cache to include libraries in unzip's build dir. I propose to change the instructions to the following: LD_LIBRARY_PATH=$PWD make check Comments? Why are we building libunzip.so at all? Nothing uses it AFAIK, and we need the -dont_make-noise patch because of this library. -- Alexander E. Patrakov -- http://linuxfromscratch.org/mailman/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: unzip: make check modification
Alexander E. Patrakov wrote: Tushar Teredesai wrote: I propose to change the instructions to the following: LD_LIBRARY_PATH=$PWD make check That is probably the right thing, but. Why are we building libunzip.so at all? Nothing uses it AFAIK, and we need the -dont_make-noise patch because of this library. This does seem the case, all google hits are to 'blfs' except one open BSD. The whole thing seem to complex, this seems all that is required for static. sed -i 's:^LN = ln:& -sf:' unix/Makefile && make prefix=/usr LOCAL_UNZIP=-DUSE_UNSHRINK \ linux -funix/Makefile make prefix=/usr LOCAL_UNZIP=-DUSE_UNSHRINK install The sed changes the hardlink zipinfo->unzip to symbolic. The first make creates a Makefile->unix/Makefile symlink, so it is not needed for the install. -- David Jensen -- http://linuxfromscratch.org/mailman/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: unzip: make check modification
David Jensen wrote: The whole thing seems too complex, this seems all that is required for static. sed -i 's:^LN = ln:& -sf:' unix/Makefile && make prefix=/usr LOCAL_UNZIP=-DUSE_UNSHRINK \ linux -funix/Makefile make prefix=/usr LOCAL_UNZIP=-DUSE_UNSHRINK install The sed changes the hardlink zipinfo->unzip to symbolic. The first make creates a Makefile->unix/Makefile symlink, so it is not needed for the install. It didn't use zlib that way. sed -i 's:^LN = ln:& -sf:' unix/Makefile && make prefix=/usr LOCAL_UNZIP=-DUSE_UNSHRINK \ generic_zlib -funix/Makefile make prefix=/usr LOCAL_UNZIP=-DUSE_UNSHRINK install Changed the target to generic_zlib. No patches needed! -- David Jensen -- http://linuxfromscratch.org/mailman/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: unzip: make check modification
On 7/10/05, Alexander E. Patrakov <[EMAIL PROTECTED]> wrote: > > Why are we building libunzip.so at all? Useful if multiple files are being unzipped, only one lib will be loaded. -- Tushar Teredesai mailto:[EMAIL PROTECTED] http://www.linuxfromscratch.org/~tushar/ -- http://linuxfromscratch.org/mailman/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: unzip: make check modification
David Jensen wrote: No patches needed! Feeling foolish! the last was un-optimized and didn't build unzipfx. Final static version! sed -i 's:^LN = ln:& -sf:' unix/Makefile && sed -i 's:p funzip CF="$(CF):ps CF="$(CF) -O3:' \ unix/Makefile && make prefix=/usr LOCAL_UNZIP=-DUSE_UNSHRINK \ generic_zlib -funix/Makefile make prefix=/usr install -- David Jensen -- http://linuxfromscratch.org/mailman/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: unzip: make check modification
On 7/10/05, David Jensen <[EMAIL PROTECTED]> wrote: > David Jensen wrote: > > > No patches needed! > > > Feeling foolish! the last was un-optimized and didn't build unzipfx. > Final static version! > > sed -i 's:^LN = ln:& -sf:' unix/Makefile && > sed -i 's:p funzip CF="$(CF):ps CF="$(CF) -O3:' \ > unix/Makefile && > make prefix=/usr LOCAL_UNZIP=-DUSE_UNSHRINK \ > generic_zlib -funix/Makefile > make prefix=/usr install > I am committing the LD_LIBRARY_PATH change for now since the current instructions are wrong. -- Tushar Teredesai mailto:[EMAIL PROTECTED] http://www.linuxfromscratch.org/~tushar/ -- http://linuxfromscratch.org/mailman/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
