Re: [blfs-dev] More breakage from ICU-65.1 U16_NEXT requiring semilong

[Pierre Labastie via blfs-dev]

Le 03/12/2019 à 13:02, Ken Moffat via blfs-dev a écrit :
> After happening upon the problem in libfreehand (for libreoffice)
> where one line in the file had a U16_NEXT( ... )
> without a terminating semicolon I've hit the same thing in the
> chromium part of qtwebengine-5.13.2.
> 
> The initial error messages point to the _next_ line, in this case
> ./../../../../src/3rdparty/chromium/third_party/blink/renderer/core/dom/document.cc:5714:5:
>  error: expected ';' before 'if'
>  5714 | if (c == ':') {
>   | ^~
> 
> and line 5713 again uses U16_NEXT.  Fortunately, this time we have
> the source when we start to build.  Normally I dislike seds which
> address a line number by it's number, but in this case I think it's
> appropriate:
> 
> sed -i '5713s/.*/&;/' \
>   src/3rdparty/chromium/third_party/blink/renderer/core/dom/document.cc
> 
> Will address it in a mo.
> 

I've hit this in webkitgtk-2.26.2. There are four places with a missing 
semicolon,
and a lot of other places with a semicolon... Furthermore they have
an internal copy of icu. I could get it to build with the following:

grep -rl --exclude-dir icu 'U16_NEXT.*[^;]$' |
  xargs sed -i 's/U16_NEXT.*[^;]$/&;/'

Pierre
-- 
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

[blfs-dev] More breakage from ICU-65.1 U16_NEXT requiring semilong

[Ken Moffat via blfs-dev]

After happening upon the problem in libfreehand (for libreoffice)
where one line in the file had a U16_NEXT( ... )
without a terminating semicolon I've hit the same thing in the
chromium part of qtwebengine-5.13.2.

The initial error messages point to the _next_ line, in this case
./../../../../src/3rdparty/chromium/third_party/blink/renderer/core/dom/document.cc:5714:5:
 error: expected ';' before 'if'
 5714 | if (c == ':') {
  | ^~

and line 5713 again uses U16_NEXT.  Fortunately, this time we have
the source when we start to build.  Normally I dislike seds which
address a line number by it's number, but in this case I think it's
appropriate:

sed -i '5713s/.*/&;/' \
  src/3rdparty/chromium/third_party/blink/renderer/core/dom/document.cc

Will address it in a mo.

ĸen
-- 
Whilst all mushrooms are edible, the trick is to eat only those which
will prove to be edible more than once. The Celebrated Discworld Almanak
recommends you play safe and eat beans on toast.
-- 
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page