Re: [blink-dev] Intent to Ship: CSS cap and rcap font units

['TAMURA, Kent' via blink-dev]

LGTM3.


On Wed, Aug 9, 2023 at 11:30 PM Daniel Bratell  wrote:

> LGTM2
>
> /Daniel
> On 2023-08-04 16:38, Mike Taylor wrote:
>
> LGTM1
> On 8/4/23 6:41 AM, Daniil Sakhapov wrote:
>
> Contact emails sakha...@chromium.org
>
> Explainer Two font units related to the cap-height of the font. They are
> the last two to fully cover CSS Values font related units.
>
> Specification https://www.w3.org/TR/css-values-4/#cap
>
> Summary
>
> 'cap' is equal to the used cap-height of the first available font. 'rcap'
> is equal to the value of the cap unit on the root element.
>
>
> Blink component Blink>CSS
> 
>
> TAG review None
>
> TAG review status Not applicable
>
> Risks
>
>
> Interoperability and Compatibility
>
> None
>
>
> *Gecko*: Shipped/Shipping
>
> *WebKit*: Positive (
> https://github.com/WebKit/standards-positions/issues/112)
>
> *Web developers*: Asked offline at the conference.
>
> WebView application risks
>
> Does this intent deprecate or change behavior of existing APIs, such that
> it has potentially high risk for Android WebView-based applications?
>
> None
>
> Will this feature be supported on all six Blink platforms (Windows, Mac,
> Linux, Chrome OS, Android, and Android WebView)? Yes
>
> Is this feature fully tested by web-platform-tests
> 
> ? Yes
> https://wpt.fyi/css/css-values/cap-invalidation.html
>
> https://wpt.fyi/css/css-contain/container-queries/font-relative-units-dynamic.html
> https://wpt.fyi/css/css-values/cap-unit-001.html
>
> Flag name on chrome://flags CSSCapFontUnits
>
> Requires code in //chrome? False
>
> Estimated milestones
> Shipping on desktop 117
> DevTrial on desktop 116
> Shipping on Android 117
> DevTrial on Android 116
> Shipping on WebView 117
>
> Anticipated spec changes
>
> Open questions about a feature may be a source of future web compat or
> interop issues. Please list open issues (e.g. links to known github issues
> in the project for the feature specification) whose resolution may
> introduce web compat/interop risk (e.g., changing to naming or structure of
> the API in a non-backward-compatible way).
> None
>
> Link to entry on the Chrome Platform Status
> https://chromestatus.com/feature/5137204166262784
>
> This intent message was generated by Chrome Platform Status
> .
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAH3Z92-t_kPVjxEB5xLYFY7vaxxyVqpF8Cf7DNsfnipRFJjZ2w%40mail.gmail.com
> 
> .
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/fa72f7af-b242-28f5-aa69-1a50c3adacbd%40chromium.org
> 
> .
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ec37c192-6afe-d123-9aaa-fd7faf2acf61%40gmail.com
> 
> .
>


-- 
TAMURA, Kent
Software Engineer, Google

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqF1nDurx%3DWYDOOY9Rni__7ydmAgOGn59x2Xqsk7xCANbg%40mail.gmail.com.

Re: [blink-dev] Intent to Implement and Ship: Make URL parser to not decode percent-encoded ASCII character in URL's path

['TAMURA, Kent' via blink-dev]

LGTM1.  It seems to have very low risk.


On Fri, Aug 4, 2023 at 4:53 PM Hayato Ito  wrote:

> Contact emailshay...@chromium.org
>
> Specificationhttps://url.spec.whatwg.org/
>
> Summary
>
> Make URL parser to not decode percent-encoded ASCII characters in URL's
> path, such as "%41" ('A'). Before this change: > const url = new URL("
> http://example.com/%41";); > url.href "http://example.com/A"; After this
> change: > const url = new URL("http://example.com/%41";); > url.href "
> http://example.com/%41";
>
>
> Blink componentBlink>Network
> 
>
> TAG reviewNone
>
> TAG review statusNot applicable
>
> Risks
>
> Interoperability and Compatibility
> *Gecko*: Shipped/Shipping
>
> *WebKit*: Shipped/Shipping
>
>
> There are risks. Please see the WIP CL's description for details (
> https://crrev.com/c/4607744).
> I'd like to collect feedback about possible risks widely through this
> thread.
>
> The usage (Canary): 0.000106% (URL.Path.UnescapeEscapedChar
> 
> ).
> This usage is not specific to any particular use case and can be
> considered a theoretical upper bound. The actual breakage is likely much
> lower than this number.
>
> Will this feature be supported on all six Blink platforms (Windows, Mac,
> Linux, Chrome OS, Android, and Android WebView)?Yes
>
> Is this feature fully tested by web-platform-tests
> 
> ?Yes
>
>
> Tracking bughttps://crbug.com/1252531
>
> Link to entry on the Chrome Platform Status
> https://chromestatus.com/feature/6389236793606144
>
> --
> Hayato
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFpjS_2-4PAY47VbDdd%2BHS%2BchmNUc9dW3BsRtW33LDr1QOeLGw%40mail.gmail.com
> 
> .
>


-- 
TAMURA, Kent
Software Engineer, Google

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqHcCModrUAQ%3DGJx-oiLcEmBwi%2BjU0ONCpnNWh%3Dp_THRdg%40mail.gmail.com.

Re: [blink-dev] Re: Intent to Ship: CSS logical flow relative values

['TAMURA, Kent' via blink-dev]

LGTM3.


On Thu, Aug 10, 2023 at 12:46 AM Daniel Bratell  wrote:

> LGTM2
>
> /Daniel
> On 2023-08-09 00:37, PhistucK wrote:
>
> They chose "open issues in our Github repo for each point of feedback" as
> the result of the review and the mentioned issue was filed, with a
> resolution to compute the keywords to themselves, rather than to the
> physical values.
>
> ☆*PhistucK*
>
>
> On Tue, Aug 8, 2023 at 9:06 PM Mike Taylor  wrote:
>
>> LGTM1
>> On 8/8/23 7:11 AM, obr...@igalia.com wrote:
>>
>> I got an email saying that new features will be announced in blog posts
>> and enterprise release notes about 1 week before a milestone reaches beta.
>> We are close to that point and still no LGTM, so I guess it's better to
>> delay this and try to target 118 instead.
>>
>> El dia dimecres, 2 d’agost de 2023 a les 21:57:58 UTC+2,
>> obr...@igalia.com va escriure:
>>
>>> Contact emails obr...@igalia.com
>>>
>>> Explainer
>>> https://www.smashingmagazine.com/2018/03/understanding-logical-properties-values/
>>>
>>> Specification https://drafts.csswg.org/css-logical/#directional-keywords
>>> https://drafts.csswg.org/css-ui/#resize
>>> 
>>>
>>> Design docs
>>>
>>> https://developer.mozilla.org/docs/Web/CSS/CSS_logical_properties_and_values
>>>
>>> Summary
>>>
>>> Add these new values to existing CSS properties: - float: inline-start -
>>> float: inline-end - clear: inline-start - clear: inline-end - resize: block
>>> - resize: inline
>>>
>>>
>>> Blink component Blink>CSS
>>> 
>>>
>>> Search tags css-logical
>>> 
>>>
>>> TAG review https://github.com/w3ctag/design-reviews/issues/286
>>> The only issue relevant to logical values was
>>> https://github.com/w3c/csswg-drafts/issues/2821, which was addressed in
>>> the spec, and Blink obeys the resolution.
>>>
>> It's not clear what the resolution is/was - I just see a few linked
>> issues and it being closed without any comment (maybe the TAG had a
>> different operating model back in 2018...).
>>
>>
>>> TAG review status Issues addressed
>>>
>>> Risks
>>>
>>>
>>> Interoperability and Compatibility
>>>
>>> Gecko and WebKit already shipped. Gecko doesn't follow the spec.
>>>
>>>
>>> *Gecko*: Shipped/Shipping 
>>> (https://bugzilla.mozilla.org/show_bug.cgi?id=1253919,
>>> https://bugzilla.mozilla.org/show_bug.cgi?id=1464786
>>> 
>>> )
>>> The implementation is wrong, see
>>> https://bugzilla.mozilla.org/show_bug.cgi?id=1661548
>>>
>>> *WebKit*: Shipped/Shipping (https://bugs.webkit.org/show_bug.cgi?id=218087,
>>> https://bugs.webkit.org/show_bug.cgi?id=218088
>>> 
>>> )
>>>
>>> *Web developers*: Positive (
>>> https://bugs.chromium.org/p/chromium/issues/detail?id=850004#c8)
>>>
>>> *Other signals*:
>>>
>>> WebView application risks
>>>
>>> Does this intent deprecate or change behavior of existing APIs, such
>>> that it has potentially high risk for Android WebView-based applications?
>>>
>>> None
>>>
>>>
>>> Debuggability
>>>
>>> The DevTools Styles panel’s autocomplete functionality is already aware
>>> of these new values.
>>>
>>>
>>> Will this feature be supported on all six Blink platforms (Windows, Mac,
>>> Linux, Chrome OS, Android, and Android WebView)? Yes
>>>
>>> Is this feature fully tested by web-platform-tests
>>> 
>>> ? Yes
>>>
>>> Flag name on chrome://flags None
>>>
>>> Finch feature name CSSLogical
>>> (This is the feature name in runtime_enabled_features.json5, which
>>> seemingly I'm supposed to provide here, but it's not actually using Finch)
>>>
>>> Requires code in //chrome? False
>>>
>>> Tracking bug https://crbug.com/850004
>>>
>>> Estimated milestones
>>> Shipping on desktop 117
>>> DevTrial on desktop 70
>>> Shipping on Android 117
>>> DevTrial on Android 70
>>> Shipping on WebView 117
>>>
>>> Anticipated spec changes
>>>
>>> Open questions about a feature may be a source of future web compat or
>>> interop issues. Please list open issues (e.g. links to known github issues
>>> in the project for the feature specification) whose resolution may
>>> introduce web compat/interop risk (e.g., changing to naming or structure of
>>> the API in a non-backward-compatible way).
>>> None
>>>
>>> Link to entry on the Chrome Platform Status
>>> https://chromestatus.com/feature/6237096230518784
>>>
>>> Links to previous Intent discussions Intent to prototype:
>>> https://groups.google.com/a/chromium.org/d/msg/blink-dev/48OwfwZrbvI/A1XZFGkzAwAJ
>>>
>>> This intent message was generated by Chrome Platform Status
>>> .
>>>
>> --
>> Yo

Re: [blink-dev] Intent to Ship: Baselines in New TextMetrics API in Canvas

['TAMURA, Kent' via blink-dev]

LGTM3.


On Tue, Aug 22, 2023 at 5:11 AM Chris Harrelson 
wrote:

> LGTM2
>
> On Mon, Aug 21, 2023 at 1:01 PM Mike Taylor 
> wrote:
>
>> LGTM1
>> On 8/21/23 1:52 PM, Yi Xu wrote:
>>
>> Hi Yoav,
>>
>> In first attempt link
>> ,
>> we tried to ship all the attributes under TextMetrics API (in 2018). Some
>> definitions were not clear so we was not able to do it.
>> In second attempt
>> , we
>> shipped actualBoundingBoxLeft, actualBoundingBoxRight, fontBoundingBoxAscent,
>> fontBoundingBoxDescent, actualBoundingBoxAscent, actualBoundingBoxDescent,
>> emHeightAscent and emHeightDescent.
>> In third attempt
>> ,
>> we shipped fontBoundingBoxAscent, fontBoundingBoxDescent
>> In this attempt, we are trying to ship alphabeticBaseline,
>> hangingBaseline and ideographicBaseline. Note that both Safari and firefox
>> have shipped it, so we will like to catch up on this.
>>
>> Thank you,
>>
>> Yi Xu
>>
>> On Sun, Aug 20, 2023 at 10:40 PM Yoav Weiss 
>> wrote:
>>
>>>
>>>
>>> On Fri, Aug 18, 2023 at 8:25 PM Yi Xu  wrote:
>>>
 Contact emails yi...@chromium.org, aaro...@chromium.org,
 fs...@chromium.org

 Explainer
 https://learn.microsoft.com/en-us/typography/opentype/spec/baselinetags

 Specification
 https://html.spec.whatwg.org/multipage/canvas.html#textmetrics
 we are launching the following attributes in TextMetrics:
 alphabeticBaseline, hangingBaseline and ideographicBaseline

 *Tag Review*
 https://github.com/w3ctag/design-reviews/issues/302

 Summary

 This is the 4th installment in extending the TextMetrics API (first
 attempt link
 
 , second attempt
 , third
 attempt)
 
 .The current canvas TextMetrics API exposes the actualBoundingBox and
 the fontBoundingBox readings. The definition of baseline is more clear now.
 Both Firefox and Safari have already shipped this *extension to
 TextMetrics*.

>>>
>>> Thanks for pushing through this!! Any details on why the past attempts
>>> weren't successful?
>>>
>>>

 The original feature bug (https://crbug.com/277215) has strong user
 support (23 stars).

 Blink component Blink>Canvas
 

 Is this feature supported on all six Blink platforms (Windows, Mac,
 Linux, Chrome OS, Android, and Android WebView)?

 Yes


 Is this feature fully tested by web-platform-tests
 ?
 Link to test suite results from wpt.fyi
 .


 https://wpt.fyi/results/html/canvas/element/text/2d.text.measure.baselines.html?label=experimental&label=master&aligned

 Entry on the feature dashboard 

 https://chromestatus.com/feature/6516079022571520


 Risks

 Interoperability and Compatibility

 Safari and Firefox have has already shipped these metrics in the spec.



 Firefox:  Shipped
 

 Safari: Shipped 



 We know this is a feature requested by developers (as well as internal
 Google teams like Google Docs). This API will help developers have more
 control and more accurate text rendering. As of today a different way to
 achieve this is by using rendering text to the DOM and using
 getBoundingClientRect to get some measurements. This process requires a
 relayout of the page.



 Activation

 Enable the platform experiment ExtendedTextMetrics

 --
 You received this message because you are subscribed to the Google
 Groups "blink-dev" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to blink-dev+unsubscr...@chromium.org.
 To view this discussion on the web visit
 https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAC3hXJeKqXo9QKyreEM%2BqiNM0gi_us%3DWZ_-17AxpMg-bF%2BoLkA%40mail.gmail.com
 

Re: [blink-dev] Re: Intent to Implement and Ship: User-Agent Client Hints on Android WebView

['TAMURA, Kent' via blink-dev]

LGTM3.


On Fri, Aug 25, 2023 at 12:34 AM 'Rick Byers' via blink-dev <
blink-dev@chromium.org> wrote:

> Sorry for the delay, LGTM2
>
> I'm surprised you need a ramp-up for this. New APIs are generally safe so
> we usually don't finch them. But if you'd rather do a finch roll-out for
> extra safety, I have no objection.
>
> Rick
>
> On Thu, Aug 24, 2023 at 9:10 AM Peter Beverloo  wrote:
>
>> Non-API OWNER LGTM to proceed on WebView - thank you for all the
>> diligence you've done on understanding and navigating the platform
>> constraints!
>>
>> Thanks,
>> Peter
>>
>>
>> On Wed, Aug 23, 2023 at 10:45 PM 'Victor Tan' via blink-dev <
>> blink-dev@chromium.org> wrote:
>>
>>> can anyone take a look at this?   thanks.   :)
>>>
>>> On Wednesday, August 16, 2023 at 1:40:38 PM UTC-4 Chris Harrelson wrote:
>>>
 LGTM1

 On Tue, Aug 15, 2023 at 2:19 PM Victor Tan 
 wrote:

> Currently, we haven't confirmed the public plan for
> user-agent reduction on WeView. We won't do user-agent reduction before
> completing roll-out user-agent client hints.
>
> Victor
>
> On Tue, Aug 15, 2023 at 5:13 PM Bhanu Vattikonda 
> wrote:
>
>> Is there a corresponding User-Agent reduction plan for Android
>> WebView?
>>
>> On Tuesday, August 15, 2023 at 12:30:17 PM UTC-7 vict...@chromium.org
>> wrote:
>>
>>> Contact emails
>>>
>>> vict...@chromium.org, mike...@chromium.org
>>>
>>> Explainer
>>>
>>> https://github.com/WICG/client-hints-infrastructure#readme
>>>
>>>
>>> https://github.com/WICG/ua-client-hints#explainer-reducing-user-agent-granularity
>>>
>>> Specification
>>>
>>> https://wicg.github.io/ua-client-hints/
>>>
>>> Summary
>>>
>>> User-agent client hints (a set of `Sec-CH-UA-*`) aim to deprecate
>>> and replace the User-Agent header to reduce the passive fingerprinting
>>> surface we expose via HTTP requests. As we previously rolled-out 
>>> user-agent
>>> client hints on Windows, Mac, Linux, Chrome OS and Android, we intend to
>>> proceed with shipping user-agent client hints on Android WebView. For
>>> overridden user-agent strings, we only populate user-agent client hints 
>>> if
>>> the overridden user-agent contains the default user-agent. In this 
>>> case, we
>>> will only generate low-entropy user-agent client hints If users also
>>> override the user-agent string through command-line.
>>>
>>> Blink component
>>>
>>> Blink>Network>ClientHints
>>>
>>> TAG review
>>>
>>> https://github.com/w3ctag/design-reviews/issues/320
>>>
>>> TAG review status
>>>
>>> Closed.
>>>
>>> Risks
>>> Interoperability and Compatibility
>>>
>>> Introducing User-Agent client hints in itself won't affect any page
>>> since it's purely opt-in features. It helps us to improve the
>>> interoperability between Chrome and WebView.
>>>
>>> Here is our proposed rollout plan in Chrome Stable channel
>>> (Canary/Dev/Beta has been enabled 50%), with the understanding that if 
>>> we
>>> discover concerning breakage or regressions via health metrics or bug
>>> reports we will pause the rollout:
>>>
>>>
>>> Stage
>>>
>>> Duration
>>>
>>> Date
>>>
>>> Stable 1% (M116+)
>>>
>>> M116 stable release is shipping to 100% (a best guess)
>>>
>>> Aug 22, 2023
>>>
>>> Stable 10% (M116+)
>>>
>>> ~2 weeks after previous stage
>>>
>>> Sep 5, 2023
>>>
>>> TOT Default (M117)
>>>
>>> ~2 weeks after previous stage
>>>
>>> Sep 19, 2023
>>>
>>> Stable 100% (M116=>M117)
>>>
>>> ~ Same business day as previous stage
>>>
>>> Sep 19, 2023
>>>
>>> Gecko: Non-harmful on User-Agent client hints (
>>> https://github.com/mozilla/standards-positions/issues/202).
>>>
>>> WebKit: No signals (
>>> https://github.com/WebKit/standards-positions/issues/70).
>>>
>>> Web developers: Mixed signals (https://crbug.com/1430051
>>> ).
>>> We know at least one site that uses user-agent client hints on Android
>>> WebView..
>>>
>>> Debuggability
>>>
>>> No special DevTools support needed. The UA Client Hints headers will
>>> be as debuggable as other request headers, through DevTools’ network 
>>> tab.
>>>
>>> Will this feature be supported on all six Blink platforms (Windows,
>>> Mac, Linux, Chrome OS, Android, and Android WebView)?
>>>
>>> Yes
>>>
>>> Notes: The existing flag UserAgentClientHint was already enabled for
>>> other five platforms (Windows, Mac, Linux, Chrome OS and Android).
>>>
>>> Is this feature fully tested by web-platform-tests
>>>