Re: [blink-dev] Intent to Ship: 'display' property with multiple values

2023-04-26 Thread 一丝 
Can you clarify what new display layout this brings and how it is supported
by other browsers? For example `display: inline list-item` or `display:
block ruby`

以上
一丝


Daniel Bratell  于2023年4月26日周三 23:22写道：

> LGTM3
>
> /Daniel
> On 2023-04-26 17:21, Mike West wrote:
>
> LGTM2. Skipping TAG review seems reasonable given that we're simply
> catching up to existing implementation and spec.
>
> -mike
>
>
> On Wed, Apr 26, 2023 at 12:36 PM Yoav Weiss 
> wrote:
>
>> LGTM1
>>
>> Thanks for catching us up here!
>>
>> On Wed, Apr 26, 2023 at 12:13 AM TAMURA, Kent  wrote:
>>
>>> Contact emails tk...@chromium.org
>>>
>>> Explainer None
>>>
>>> Specification
>>> https://w3c.github.io/csswg-drafts/css-display/#the-display-properties
>>>
>>> Design docs
>>> Summary
>>>
>>> CSS 'display' property supports two or three keywords. Web authors can
>>> specify - How the box and its neighbor boxes are located; inline or block -
>>> How children of the box are laid out; flow, flex, grid, etc. separately.
>>> For example, `display: inline flow` instead of `display: inline-block`
>>> `display: block flex` instead of `display: flex`
>>>
>>>
>>> Blink component Blink>CSS
>>> 
>>>
>>> Search tags css , display
>>> 
>>>
>>> TAG review None
>>>
>>> TAG review status Not applicable
>>>
>>> Risks
>>>
>>>
>>> Interoperability and Compatibility
>>>
>>> Risks are very low. Two other browsers already shipped the feature.
>>>
>>>
>>> *Gecko*: Shipped/Shipping
>>>
>>> *WebKit*: Shipped/Shipping
>>>
>>> *Web developers*: Positive (
>>> https://bugs.chromium.org/p/chromium/issues/detail?id=995106) The bug
>>> has 16 stars.
>>>
>>> *Other signals*:
>>>
>>> WebView application risks
>>>
>>> None.
>>>
>>>
>>> Debuggability
>>>
>>> Will this feature be supported on all six Blink platforms (Windows, Mac,
>>> Linux, Chrome OS, Android, and Android WebView)? Yes
>>>
>>> Is this feature fully tested by web-platform-tests
>>> 
>>> ? Yes
>>>
>>> https://wpt.fyi/results/css/css-display/parsing
>>> Note: Here is the latest result:
>>> https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/css/css-display/parsing/display-valid-expected.txt
>>>
>>>
>>> Flag name CSSDisplayMultipleValues
>>>
>>> Requires code in //chrome? False
>>>
>>> Tracking bug
>>> https://bugs.chromium.org/p/chromium/issues/detail?id=995106
>>>
>>> Estimated milestones
>>> Shipping on desktop 115
>>> Shipping on Android 115
>>> Shipping on WebView 115
>>>
>>> Anticipated spec changes
>>>
>>> None
>>>
>>> Link to entry on the Chrome Platform Status
>>> https://chromestatus.com/feature/5091238937624576
>>>
>>> Links to previous Intent discussions Intent to prototype:
>>> https://groups.google.com/a/chromium.org/g/blink-dev/c/GYdHdU6MoaU/m/dTYXlP4vMAAJ
>>>
>>> This intent message was generated by Chrome Platform Status
>>> .
>>>
>>> --
>>> TAMURA Kent
>>> Software Engineer, Google
>>>
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "blink-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to blink-dev+unsubscr...@chromium.org.
>>> To view this discussion on the web visit
>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqGtug1xy1Bkhs5DDM%2B%2Bg3UvHRH2Lgrw9AJHJE9%3Dc4SVXA%40mail.gmail.com
>>> 
>>> .
>>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "blink-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to blink-dev+unsubscr...@chromium.org.
>> To view this discussion on the web visit
>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUwx50rPT1fnrCn-nZ323dA2QDddp-67%3DmRrWCRtWm3FQ%40mail.gmail.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DcL31y7REv-MWB9PkwKMET_Jmbk4j7ns_9Zf1CaTigtZQ%40mail.gmail.com
> 
> .
>
> --
> You received this message because you are sub

Re: [blink-dev] Intent to Ship: 'display' property with multiple values

2023-04-26 Thread Daniel Bratell 

LGTM3

/Daniel

On 2023-04-26 17:21, Mike West wrote:
LGTM2. Skipping TAG review seems reasonable given that we're simply 
catching up to existing implementation and spec.


-mike


On Wed, Apr 26, 2023 at 12:36 PM Yoav Weiss  
wrote:


LGTM1

Thanks for catching us up here!

On Wed, Apr 26, 2023 at 12:13 AM TAMURA, Kent 
wrote:


Contact emails

tk...@chromium.org


Explainer

None


Specification

https://w3c.github.io/csswg-drafts/css-display/#the-display-properties


Design docs


Summary

CSS 'display' property supports two or three keywords. Web
authors can specify - How the box and its neighbor boxes are
located; inline or block - How children of the box are laid
out; flow, flex, grid, etc. separately. For example, `display:
inline flow` instead of `display: inline-block` `display:
block flex` instead of `display: flex`



Blink component

Blink>CSS




Search tags

css , display



TAG review

None


TAG review status

Not applicable


Risks



Interoperability and Compatibility

Risks are very low. Two other browsers already shipped the
feature.



/Gecko/: Shipped/Shipping

/WebKit/: Shipped/Shipping

/Web developers/: Positive
(https://bugs.chromium.org/p/chromium/issues/detail?id=995106)
The bug has 16 stars.

/Other signals/:


WebView application risks

None.



Debuggability



Will this feature be supported on all six Blink
platforms (Windows, Mac, Linux, Chrome OS, Android,
and Android WebView)?

Yes


Is this feature fully tested by web-platform-tests

?

Yes

https://wpt.fyi/results/css/css-display/parsing
Note: Here is the latest result:

https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/css/css-display/parsing/display-valid-expected.txt


Flag name

CSSDisplayMultipleValues


Requires code in //chrome?

False


Tracking bug

https://bugs.chromium.org/p/chromium/issues/detail?id=995106


Estimated milestones

Shipping on desktop 115

Shipping on Android 115

Shipping on WebView 115



Anticipated spec changes

None


Link to entry on the Chrome Platform Status

https://chromestatus.com/feature/5091238937624576


Links to previous Intent discussions

Intent to prototype:

https://groups.google.com/a/chromium.org/g/blink-dev/c/GYdHdU6MoaU/m/dTYXlP4vMAAJ

This intent message was generated by Chrome Platform Status
.

-- 
TAMURA Kent

Software Engineer, Google


-- 
You received this message because you are subscribed to the

Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from
it, send an email to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit

https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqGtug1xy1Bkhs5DDM%2B%2Bg3UvHRH2Lgrw9AJHJE9%3Dc4SVXA%40mail.gmail.com

.

-- 
You received this message because you are subscribed to the Google

Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit

https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUwx50rPT1fnrCn-nZ323dA2QDddp-67%3DmRrWCRtWm3FQ%40mail.gmail.com

.

--
You received this message because you are subscribed to the Google 
Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send 
an email to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DcL31y7REv-MWB9PkwKM

Re: [blink-dev] Intent to Ship: 'display' property with multiple values

2023-04-26 Thread Mike West 
LGTM2. Skipping TAG review seems reasonable given that we're simply
catching up to existing implementation and spec.

-mike


On Wed, Apr 26, 2023 at 12:36 PM Yoav Weiss  wrote:

> LGTM1
>
> Thanks for catching us up here!
>
> On Wed, Apr 26, 2023 at 12:13 AM TAMURA, Kent  wrote:
>
>> Contact emailstk...@chromium.org
>>
>> ExplainerNone
>>
>> Specification
>> https://w3c.github.io/csswg-drafts/css-display/#the-display-properties
>>
>> Design docs
>> Summary
>>
>> CSS 'display' property supports two or three keywords. Web authors can
>> specify - How the box and its neighbor boxes are located; inline or block -
>> How children of the box are laid out; flow, flex, grid, etc. separately.
>> For example, `display: inline flow` instead of `display: inline-block`
>> `display: block flex` instead of `display: flex`
>>
>>
>> Blink componentBlink>CSS
>> 
>>
>> Search tagscss , display
>> 
>>
>> TAG reviewNone
>>
>> TAG review statusNot applicable
>>
>> Risks
>>
>>
>> Interoperability and Compatibility
>>
>> Risks are very low. Two other browsers already shipped the feature.
>>
>>
>> *Gecko*: Shipped/Shipping
>>
>> *WebKit*: Shipped/Shipping
>>
>> *Web developers*: Positive (
>> https://bugs.chromium.org/p/chromium/issues/detail?id=995106) The bug
>> has 16 stars.
>>
>> *Other signals*:
>>
>> WebView application risks
>>
>> None.
>>
>>
>>
>> Debuggability
>>
>>
>>
>> Will this feature be supported on all six Blink platforms (Windows, Mac,
>> Linux, Chrome OS, Android, and Android WebView)?Yes
>>
>> Is this feature fully tested by web-platform-tests
>> 
>> ?Yes
>>
>> https://wpt.fyi/results/css/css-display/parsing
>> Note: Here is the latest result:
>> https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/css/css-display/parsing/display-valid-expected.txt
>>
>>
>> Flag nameCSSDisplayMultipleValues
>>
>> Requires code in //chrome?False
>>
>> Tracking bughttps://bugs.chromium.org/p/chromium/issues/detail?id=995106
>>
>> Estimated milestones
>> Shipping on desktop 115
>> Shipping on Android 115
>> Shipping on WebView 115
>>
>> Anticipated spec changes
>>
>> None
>>
>> Link to entry on the Chrome Platform Status
>> https://chromestatus.com/feature/5091238937624576
>>
>> Links to previous Intent discussionsIntent to prototype:
>> https://groups.google.com/a/chromium.org/g/blink-dev/c/GYdHdU6MoaU/m/dTYXlP4vMAAJ
>>
>> This intent message was generated by Chrome Platform Status
>> .
>>
>> --
>> TAMURA Kent
>> Software Engineer, Google
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "blink-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to blink-dev+unsubscr...@chromium.org.
>> To view this discussion on the web visit
>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqGtug1xy1Bkhs5DDM%2B%2Bg3UvHRH2Lgrw9AJHJE9%3Dc4SVXA%40mail.gmail.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUwx50rPT1fnrCn-nZ323dA2QDddp-67%3DmRrWCRtWm3FQ%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DcL31y7REv-MWB9PkwKMET_Jmbk4j7ns_9Zf1CaTigtZQ%40mail.gmail.com.

Re: [blink-dev] Intent to Ship: 'display' property with multiple values

2023-04-26 Thread Yoav Weiss 
LGTM1

Thanks for catching us up here!

On Wed, Apr 26, 2023 at 12:13 AM TAMURA, Kent  wrote:

> Contact emailstk...@chromium.org
>
> ExplainerNone
>
> Specification
> https://w3c.github.io/csswg-drafts/css-display/#the-display-properties
>
> Design docs
> Summary
>
> CSS 'display' property supports two or three keywords. Web authors can
> specify - How the box and its neighbor boxes are located; inline or block -
> How children of the box are laid out; flow, flex, grid, etc. separately.
> For example, `display: inline flow` instead of `display: inline-block`
> `display: block flex` instead of `display: flex`
>
>
> Blink componentBlink>CSS
> 
>
> Search tagscss , display
> 
>
> TAG reviewNone
>
> TAG review statusNot applicable
>
> Risks
>
>
> Interoperability and Compatibility
>
> Risks are very low. Two other browsers already shipped the feature.
>
>
> *Gecko*: Shipped/Shipping
>
> *WebKit*: Shipped/Shipping
>
> *Web developers*: Positive (
> https://bugs.chromium.org/p/chromium/issues/detail?id=995106) The bug has
> 16 stars.
>
> *Other signals*:
>
> WebView application risks
>
> None.
>
>
>
> Debuggability
>
>
>
> Will this feature be supported on all six Blink platforms (Windows, Mac,
> Linux, Chrome OS, Android, and Android WebView)?Yes
>
> Is this feature fully tested by web-platform-tests
> 
> ?Yes
>
> https://wpt.fyi/results/css/css-display/parsing
> Note: Here is the latest result:
> https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/css/css-display/parsing/display-valid-expected.txt
>
>
> Flag nameCSSDisplayMultipleValues
>
> Requires code in //chrome?False
>
> Tracking bughttps://bugs.chromium.org/p/chromium/issues/detail?id=995106
>
> Estimated milestones
> Shipping on desktop 115
> Shipping on Android 115
> Shipping on WebView 115
>
> Anticipated spec changes
>
> None
>
> Link to entry on the Chrome Platform Status
> https://chromestatus.com/feature/5091238937624576
>
> Links to previous Intent discussionsIntent to prototype:
> https://groups.google.com/a/chromium.org/g/blink-dev/c/GYdHdU6MoaU/m/dTYXlP4vMAAJ
>
> This intent message was generated by Chrome Platform Status
> .
>
> --
> TAMURA Kent
> Software Engineer, Google
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqGtug1xy1Bkhs5DDM%2B%2Bg3UvHRH2Lgrw9AJHJE9%3Dc4SVXA%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUwx50rPT1fnrCn-nZ323dA2QDddp-67%3DmRrWCRtWm3FQ%40mail.gmail.com.

[blink-dev] Intent to Ship: 'display' property with multiple values

2023-04-25 Thread TAMURA, Kent 
Contact emailstk...@chromium.org

ExplainerNone

Specification
https://w3c.github.io/csswg-drafts/css-display/#the-display-properties

Design docs
Summary

CSS 'display' property supports two or three keywords. Web authors can
specify - How the box and its neighbor boxes are located; inline or block -
How children of the box are laid out; flow, flex, grid, etc. separately.
For example, `display: inline flow` instead of `display: inline-block`
`display: block flex` instead of `display: flex`


Blink componentBlink>CSS


Search tagscss , display


TAG reviewNone

TAG review statusNot applicable

Risks


Interoperability and Compatibility

Risks are very low. Two other browsers already shipped the feature.


*Gecko*: Shipped/Shipping

*WebKit*: Shipped/Shipping

*Web developers*: Positive (
https://bugs.chromium.org/p/chromium/issues/detail?id=995106) The bug has
16 stars.

*Other signals*:

WebView application risks

None.



Debuggability



Will this feature be supported on all six Blink platforms (Windows, Mac,
Linux, Chrome OS, Android, and Android WebView)?Yes

Is this feature fully tested by web-platform-tests

?Yes

https://wpt.fyi/results/css/css-display/parsing
Note: Here is the latest result:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/css/css-display/parsing/display-valid-expected.txt


Flag nameCSSDisplayMultipleValues

Requires code in //chrome?False

Tracking bughttps://bugs.chromium.org/p/chromium/issues/detail?id=995106

Estimated milestones
Shipping on desktop 115
Shipping on Android 115
Shipping on WebView 115

Anticipated spec changes

None

Link to entry on the Chrome Platform Status
https://chromestatus.com/feature/5091238937624576

Links to previous Intent discussionsIntent to prototype:
https://groups.google.com/a/chromium.org/g/blink-dev/c/GYdHdU6MoaU/m/dTYXlP4vMAAJ

This intent message was generated by Chrome Platform Status
.

-- 
TAMURA Kent
Software Engineer, Google

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqGtug1xy1Bkhs5DDM%2B%2Bg3UvHRH2Lgrw9AJHJE9%3Dc4SVXA%40mail.gmail.com.