Re: [blink-dev] Intent to Ship: ARIA Attribute Reflection for role attribute

2022-04-19 Thread Chris Harrelson 
LGTM3

On Tue, Apr 19, 2022, 5:55 AM Mike Taylor  wrote:

> LGTM2
>
> On 4/19/22 8:33 AM, Yoav Weiss wrote:
>
> LGTM1
>
> On Sun, Apr 17, 2022 at 10:38 PM Manuel Rego Casasnovas 
> wrote:
>
>>
>> **Contact emails**
>>
>> r...@igalia.com
>>
>> **Specification**
>>
>> https://w3c.github.io/aria/#idl-interface
>>
>> **Summary**
>>
>> This is a kind of oversight from
>> https://chromestatus.com/feature/6643371200217088, at that time all
>> other ARIA attributes from the IDL
>> (https://w3c.github.io/aria/#idl-interface) were shipped, but this one
>> was missing.
>>
>> This is a small change that will also include the role attribute as one
>> more of the reflection ARIA properties available.
>>
>> **Motivation**
>>
>> This should have shipped in M81
>> (
>> https://groups.google.com/a/chromium.org/g/blink-dev/c/882iPcdnNQs/m/UP-PI8H2DwAJ
>> )
>> together with the rest of attributes, by for some reason this wasn't
>> done (probably because it was originally developed under a different
>> runtime flag).
>>
>> **Blink component**
>>
>> Blink>Accessibility
>>
>> **TAG review**
>>
>> https://github.com/w3ctag/design-reviews/issues/134
>>
>> **TAG review status**
>>
>> Complete
>>
>> **Risks**
>>
>>   **Interoperability and Compatibility**
>>
>>   This is just one more property that should had shipped originally.
>>
>>   This has been shipped in Safari
>> (https://trac.webkit.org/changeset/234482/webkit) long time ago.
>>
>>   And there's an implementation in Firefox behind a flag.
>>
>>   **Gecko**: Under consideration
>> (https://github.com/mozilla/standards-positions/issues/211) Mozilla
>> position is still under consideration, but Firefox has an implementation
>> behind a runtime flag
>> (https://bugzilla.mozilla.org/show_bug.cgi?id=1628418). Last comment
>> from Anne on the bug, points to some spec issues but those are generic
>> issues for the whole feature (not particular issues with "role" property
>> itself).
>>
>>   **WebKit**: Shipped/Shipping
>> (https://trac.webkit.org/changeset/234482/webkit)
>>
>> **Debuggability**
>>
>> This will work the same than the rest of properties already shipped.
>>
>> **Is this feature fully tested by web-platform-tests?**
>>
>> Yes
>>
>> **Tracking bug**
>>
>> https://bugs.chromium.org/p/chromium/issues/detail?id=1316801
>>
>> **Link to entry on the Chrome Platform Status**
>>
>> https://chromestatus.com/feature/5188935855636480
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "blink-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to blink-dev+unsubscr...@chromium.org.
>> To view this discussion on the web visit
>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e0cb6f12-027f-e83e-e08e-8a35ff44642b%40igalia.com
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfVAv638VTX6Ezpxa678Mx%3DiDBxhREcUKmP48CSv7AEQEw%40mail.gmail.com
> 
> .
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/d8d7edc0-3e28-5a8d-b29b-6a85d48ff009%40chromium.org
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-UiK9r2vfgWhCGqH_HYkv-TLKRzZgMFC5N0snfFpZvag%40mail.gmail.com.

Re: [blink-dev] Intent to Ship: ARIA Attribute Reflection for role attribute

2022-04-19 Thread Mike Taylor 

LGTM2

On 4/19/22 8:33 AM, Yoav Weiss wrote:

LGTM1

On Sun, Apr 17, 2022 at 10:38 PM Manuel Rego Casasnovas 
 wrote:



**Contact emails**

r...@igalia.com

**Specification**

https://w3c.github.io/aria/#idl-interface

**Summary**

This is a kind of oversight from
https://chromestatus.com/feature/6643371200217088, at that time all
other ARIA attributes from the IDL
(https://w3c.github.io/aria/#idl-interface) were shipped, but this one
was missing.

This is a small change that will also include the role attribute
as one
more of the reflection ARIA properties available.

**Motivation**

This should have shipped in M81

(https://groups.google.com/a/chromium.org/g/blink-dev/c/882iPcdnNQs/m/UP-PI8H2DwAJ)
together with the rest of attributes, by for some reason this wasn't
done (probably because it was originally developed under a different
runtime flag).

**Blink component**

Blink>Accessibility

**TAG review**

https://github.com/w3ctag/design-reviews/issues/134

**TAG review status**

Complete

**Risks**

  **Interoperability and Compatibility**

  This is just one more property that should had shipped originally.

  This has been shipped in Safari
(https://trac.webkit.org/changeset/234482/webkit) long time ago.

  And there's an implementation in Firefox behind a flag.

  **Gecko**: Under consideration
(https://github.com/mozilla/standards-positions/issues/211) Mozilla
position is still under consideration, but Firefox has an
implementation
behind a runtime flag
(https://bugzilla.mozilla.org/show_bug.cgi?id=1628418). Last comment
from Anne on the bug, points to some spec issues but those are generic
issues for the whole feature (not particular issues with "role"
property
itself).

  **WebKit**: Shipped/Shipping
(https://trac.webkit.org/changeset/234482/webkit)

**Debuggability**

This will work the same than the rest of properties already shipped.

**Is this feature fully tested by web-platform-tests?**

Yes

**Tracking bug**

https://bugs.chromium.org/p/chromium/issues/detail?id=1316801

**Link to entry on the Chrome Platform Status**

https://chromestatus.com/feature/5188935855636480

-- 
You received this message because you are subscribed to the Google

Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to blink-dev+unsubscr...@chromium.org
.
To view this discussion on the web visit

https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e0cb6f12-027f-e83e-e08e-8a35ff44642b%40igalia.com.

--
You received this message because you are subscribed to the Google 
Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send 
an email to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfVAv638VTX6Ezpxa678Mx%3DiDBxhREcUKmP48CSv7AEQEw%40mail.gmail.com 
.


--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/d8d7edc0-3e28-5a8d-b29b-6a85d48ff009%40chromium.org.

Re: [blink-dev] Intent to Ship: ARIA Attribute Reflection for role attribute

2022-04-19 Thread Yoav Weiss 
LGTM1

On Sun, Apr 17, 2022 at 10:38 PM Manuel Rego Casasnovas 
wrote:

>
> **Contact emails**
>
> r...@igalia.com
>
> **Specification**
>
> https://w3c.github.io/aria/#idl-interface
>
> **Summary**
>
> This is a kind of oversight from
> https://chromestatus.com/feature/6643371200217088, at that time all
> other ARIA attributes from the IDL
> (https://w3c.github.io/aria/#idl-interface) were shipped, but this one
> was missing.
>
> This is a small change that will also include the role attribute as one
> more of the reflection ARIA properties available.
>
> **Motivation**
>
> This should have shipped in M81
> (
> https://groups.google.com/a/chromium.org/g/blink-dev/c/882iPcdnNQs/m/UP-PI8H2DwAJ
> )
> together with the rest of attributes, by for some reason this wasn't
> done (probably because it was originally developed under a different
> runtime flag).
>
> **Blink component**
>
> Blink>Accessibility
>
> **TAG review**
>
> https://github.com/w3ctag/design-reviews/issues/134
>
> **TAG review status**
>
> Complete
>
> **Risks**
>
>   **Interoperability and Compatibility**
>
>   This is just one more property that should had shipped originally.
>
>   This has been shipped in Safari
> (https://trac.webkit.org/changeset/234482/webkit) long time ago.
>
>   And there's an implementation in Firefox behind a flag.
>
>   **Gecko**: Under consideration
> (https://github.com/mozilla/standards-positions/issues/211) Mozilla
> position is still under consideration, but Firefox has an implementation
> behind a runtime flag
> (https://bugzilla.mozilla.org/show_bug.cgi?id=1628418). Last comment
> from Anne on the bug, points to some spec issues but those are generic
> issues for the whole feature (not particular issues with "role" property
> itself).
>
>   **WebKit**: Shipped/Shipping
> (https://trac.webkit.org/changeset/234482/webkit)
>
> **Debuggability**
>
> This will work the same than the rest of properties already shipped.
>
> **Is this feature fully tested by web-platform-tests?**
>
> Yes
>
> **Tracking bug**
>
> https://bugs.chromium.org/p/chromium/issues/detail?id=1316801
>
> **Link to entry on the Chrome Platform Status**
>
> https://chromestatus.com/feature/5188935855636480
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e0cb6f12-027f-e83e-e08e-8a35ff44642b%40igalia.com
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfVAv638VTX6Ezpxa678Mx%3DiDBxhREcUKmP48CSv7AEQEw%40mail.gmail.com.

[blink-dev] Intent to Ship: ARIA Attribute Reflection for role attribute

2022-04-17 Thread Manuel Rego Casasnovas 


**Contact emails**

r...@igalia.com

**Specification**

https://w3c.github.io/aria/#idl-interface

**Summary**

This is a kind of oversight from
https://chromestatus.com/feature/6643371200217088, at that time all
other ARIA attributes from the IDL
(https://w3c.github.io/aria/#idl-interface) were shipped, but this one
was missing.

This is a small change that will also include the role attribute as one
more of the reflection ARIA properties available.

**Motivation**

This should have shipped in M81
(https://groups.google.com/a/chromium.org/g/blink-dev/c/882iPcdnNQs/m/UP-PI8H2DwAJ)
together with the rest of attributes, by for some reason this wasn't
done (probably because it was originally developed under a different
runtime flag).

**Blink component**

Blink>Accessibility

**TAG review**

https://github.com/w3ctag/design-reviews/issues/134

**TAG review status**

Complete

**Risks**

  **Interoperability and Compatibility**

  This is just one more property that should had shipped originally.

  This has been shipped in Safari
(https://trac.webkit.org/changeset/234482/webkit) long time ago.

  And there's an implementation in Firefox behind a flag.

  **Gecko**: Under consideration
(https://github.com/mozilla/standards-positions/issues/211) Mozilla
position is still under consideration, but Firefox has an implementation
behind a runtime flag
(https://bugzilla.mozilla.org/show_bug.cgi?id=1628418). Last comment
from Anne on the bug, points to some spec issues but those are generic
issues for the whole feature (not particular issues with "role" property
itself).

  **WebKit**: Shipped/Shipping
(https://trac.webkit.org/changeset/234482/webkit)

**Debuggability**

This will work the same than the rest of properties already shipped.

**Is this feature fully tested by web-platform-tests?**

Yes

**Tracking bug**

https://bugs.chromium.org/p/chromium/issues/detail?id=1316801

**Link to entry on the Chrome Platform Status**

https://chromestatus.com/feature/5188935855636480

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e0cb6f12-027f-e83e-e08e-8a35ff44642b%40igalia.com.