Re: [blink-dev] Intent to Ship: CSS Selectors 4 Pseudo-Class :nth-child(an + b of S)

2023-01-16 Thread Yoav Weiss 
LGTM3

On Fri, Jan 13, 2023 at 6:29 PM Mike Taylor  wrote:

> LGTM2
>
> On 1/13/23 12:04 PM, Rick Byers wrote:
>
> LGTM1
>
> On Thu, Jan 12, 2023 at 2:04 PM Mike Taylor 
> wrote:
>
>> On 1/12/23 1:24 PM, Steinar H. Gunderson wrote:
>> > On Thu, Jan 12, 2023 at 01:09:41PM -0500, Mike Taylor wrote:
>> >>> Gecko: In development
>> >> Do you have a link?
>> > https://bugzilla.mozilla.org/show_bug.cgi?id=1808227
>> Thank you - it looks to be implemented in Nightly, by behind the
>> layout.css.nth-child-of.enabled pref for now.
>> >>> Is this feature fully tested by web-platform-tests?
>> >>> Yes. (We added more WPT tests as part of implementing it.)
>> >> How do we do with the feature enabled, compared to Safari?
>> > We pass all the tests (32 base tests + 8 invalidation tests),
>> > Safari TP fails two of the base tests and four of the invalidation
>> > tests (at least according to wpt.fyi).
>> >
>> > /* Steinar */
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "blink-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to blink-dev+unsubscr...@chromium.org.
>> To view this discussion on the web visit
>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b8b15031-b35d-56a1-70b6-d5c76d662155%40chromium.org
>> .
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/51d9b31e-5e91-0589-97d6-5501cd642d10%40chromium.org
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfWWUtPckqe70ODdSpzUkUa7fcst8qqx1WLKXbXKKnENBA%40mail.gmail.com.

Re: [blink-dev] Intent to Ship: CSS Selectors 4 Pseudo-Class :nth-child(an + b of S)

2023-01-13 Thread Mike Taylor 

LGTM2

On 1/13/23 12:04 PM, Rick Byers wrote:

LGTM1

On Thu, Jan 12, 2023 at 2:04 PM Mike Taylor  
wrote:


On 1/12/23 1:24 PM, Steinar H. Gunderson wrote:
> On Thu, Jan 12, 2023 at 01:09:41PM -0500, Mike Taylor wrote:
>>> Gecko: In development
>> Do you have a link?
> https://bugzilla.mozilla.org/show_bug.cgi?id=1808227
Thank you - it looks to be implemented in Nightly, by behind the
layout.css.nth-child-of.enabled pref for now.
>>> Is this feature fully tested by web-platform-tests?
>>> Yes. (We added more WPT tests as part of implementing it.)
>> How do we do with the feature enabled, compared to Safari?
> We pass all the tests (32 base tests + 8 invalidation tests),
> Safari TP fails two of the base tests and four of the invalidation
> tests (at least according to wpt.fyi).
>
> /* Steinar */


-- 
You received this message because you are subscribed to the Google

Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to blink-dev+unsubscr...@chromium.org
.
To view this discussion on the web visit

https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b8b15031-b35d-56a1-70b6-d5c76d662155%40chromium.org.



--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/51d9b31e-5e91-0589-97d6-5501cd642d10%40chromium.org.

Re: [blink-dev] Intent to Ship: CSS Selectors 4 Pseudo-Class :nth-child(an + b of S)

2023-01-13 Thread Rick Byers 
LGTM1

On Thu, Jan 12, 2023 at 2:04 PM Mike Taylor  wrote:

> On 1/12/23 1:24 PM, Steinar H. Gunderson wrote:
> > On Thu, Jan 12, 2023 at 01:09:41PM -0500, Mike Taylor wrote:
> >>> Gecko: In development
> >> Do you have a link?
> > https://bugzilla.mozilla.org/show_bug.cgi?id=1808227
> Thank you - it looks to be implemented in Nightly, by behind the
> layout.css.nth-child-of.enabled pref for now.
> >>> Is this feature fully tested by web-platform-tests?
> >>> Yes. (We added more WPT tests as part of implementing it.)
> >> How do we do with the feature enabled, compared to Safari?
> > We pass all the tests (32 base tests + 8 invalidation tests),
> > Safari TP fails two of the base tests and four of the invalidation
> > tests (at least according to wpt.fyi).
> >
> > /* Steinar */
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b8b15031-b35d-56a1-70b6-d5c76d662155%40chromium.org
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY-KUMTF8hqpmeeeYWr-%3DkcDsuBR4YDqe8ZmJKK%2BWUdisg%40mail.gmail.com.

Re: [blink-dev] Intent to Ship: CSS Selectors 4 Pseudo-Class :nth-child(an + b of S)

2023-01-12 Thread Mike Taylor 

On 1/12/23 1:24 PM, Steinar H. Gunderson wrote:

On Thu, Jan 12, 2023 at 01:09:41PM -0500, Mike Taylor wrote:

Gecko: In development

Do you have a link?

https://bugzilla.mozilla.org/show_bug.cgi?id=1808227
Thank you - it looks to be implemented in Nightly, by behind the 
layout.css.nth-child-of.enabled pref for now.

Is this feature fully tested by web-platform-tests?
Yes. (We added more WPT tests as part of implementing it.)

How do we do with the feature enabled, compared to Safari?

We pass all the tests (32 base tests + 8 invalidation tests),
Safari TP fails two of the base tests and four of the invalidation
tests (at least according to wpt.fyi).

/* Steinar */



--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b8b15031-b35d-56a1-70b6-d5c76d662155%40chromium.org.

Re: [blink-dev] Intent to Ship: CSS Selectors 4 Pseudo-Class :nth-child(an + b of S)

2023-01-12 Thread Steinar H. Gunderson 
On Thu, Jan 12, 2023 at 01:09:41PM -0500, Mike Taylor wrote:
>> Gecko: In development
> Do you have a link?

https://bugzilla.mozilla.org/show_bug.cgi?id=1808227

>> Is this feature fully tested by web-platform-tests?
>> Yes. (We added more WPT tests as part of implementing it.)
> How do we do with the feature enabled, compared to Safari?

We pass all the tests (32 base tests + 8 invalidation tests),
Safari TP fails two of the base tests and four of the invalidation
tests (at least according to wpt.fyi).

/* Steinar */
-- 
Homepage: https://www.sesse.net/

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/20230112182415.yk3apmql37en6h5g%40sesse.net.

Re: [blink-dev] Intent to Ship: CSS Selectors 4 Pseudo-Class :nth-child(an + b of S)

2023-01-12 Thread Mike Taylor 

Hi Steinar,

On 1/12/23 5:32 AM, Steinar H. Gunderson wrote:

Contact emails: se...@chromium.org
Explainer: None
Specification: https://www.w3.org/TR/selectors-4

Summary:
Extend :nth-child(an + b) to take a selector, and the same with
:nth-last-child. So e.g. :nth-child(3 .c) is the third .c under a given
parent. (This is not the same as .c:nth-child(3), which is a .c that must
also be the third element under a given parent.)

Blink component: Blink>CSS
TAG review status: Not applicable

Risks, Interoperability and Compatibility: None known. Part of Interop 2023.

Gecko: In development

Do you have a link?

WebKit: Shipped/Shipping

WebView application risks: None.
Debuggability: N/A

Will this feature be supported on all six Blink platforms (Windows, Mac,
Linux, Chrome OS, Android, and Android WebView)?
Yes

Is this feature fully tested by web-platform-tests?
Yes. (We added more WPT tests as part of implementing it.)

How do we do with the feature enabled, compared to Safari?

Flag name: CSSSelectorNthChildComplexSelectorEnabled

Requires code in //chrome? No

Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=304163

Estimated milestones
Shipping on desktop: 111
Shipping on Android: 111

Anticipated spec changes: None.

Link to entry on the Chrome Platform Status:
https://chromestatus.com/feature/5144225077788672

/* Steinar */



--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/47b0578a-e377-1cd0-946d-d1c794081966%40chromium.org.

[blink-dev] Intent to Ship: CSS Selectors 4 Pseudo-Class :nth-child(an + b of S)

2023-01-12 Thread Steinar H. Gunderson 
Contact emails: se...@chromium.org
Explainer: None
Specification: https://www.w3.org/TR/selectors-4

Summary:
Extend :nth-child(an + b) to take a selector, and the same with
:nth-last-child. So e.g. :nth-child(3 .c) is the third .c under a given
parent. (This is not the same as .c:nth-child(3), which is a .c that must
also be the third element under a given parent.)

Blink component: Blink>CSS
TAG review status: Not applicable

Risks, Interoperability and Compatibility: None known. Part of Interop 2023.

Gecko: In development
WebKit: Shipped/Shipping

WebView application risks: None.
Debuggability: N/A

Will this feature be supported on all six Blink platforms (Windows, Mac,
Linux, Chrome OS, Android, and Android WebView)?
Yes

Is this feature fully tested by web-platform-tests?
Yes. (We added more WPT tests as part of implementing it.)

Flag name: CSSSelectorNthChildComplexSelectorEnabled

Requires code in //chrome? No

Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=304163

Estimated milestones
Shipping on desktop: 111
Shipping on Android: 111

Anticipated spec changes: None.

Link to entry on the Chrome Platform Status:
https://chromestatus.com/feature/5144225077788672

/* Steinar */
-- 
Software Engineer, Google Norway

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/20230112103247.dlep4m4lsdr5haxa%40sesse.net.