Re: [blink-dev] Intent to Ship: CSS Stepped Value Functions

2024-04-10 Thread Daniel Bratell 

LGTM3

/Daniel

On 2024-04-08 17:37, Mike Taylor wrote:


LGTM2

On 4/8/24 10:41 AM, Yoav Weiss (@Shopify) wrote:
Can you please flip on the "debuggability" review bit in 
chromestatus? (feel free to mark it as "N/A" if you think that's the 
case)


On Mon, Apr 8, 2024 at 4:40 PM Yoav Weiss (@Shopify) 
 wrote:


LGTM1

Thanks for catching us up here!

On Fri, Apr 5, 2024 at 3:53 PM Daniil Sakhapov
 wrote:


Contact emails

sakha...@chromium.org


Explainer

None


Specification

https://drafts.csswg.org/css-values/#round-func


Summary

The stepped-value functions, round(), mod(), and rem(), all
transform a given value according to another "step value".
The round() CSS function returns a rounded number based on a
selected rounding strategy. The mod() CSS function returns a
modulus left over when the first parameter is divided by the
second parameter, similar to the JavaScript remainder
operator (%). The modulus is the value left over when one
operand, the dividend, is divided by a second operand, the
divisor. It always takes the sign of the divisor. The rem()
CSS function returns a remainder left over when the first
parameter is divided by the second parameter, similar to the
JavaScript remainder operator (%). The remainder is the value
left over when one operand, the dividend, is divided by a
second operand, the divisor. It always takes the sign of the
dividend.



Blink component

Blink>CSS




TAG review

None


TAG review status

Issues addressed


Risks



Interoperability and Compatibility

None



/Gecko/: Shipped/Shipping

/WebKit/: Shipped/Shipping

/Web developers/: Positive

/Other signals/:


WebView application risks

Does this intent deprecate or change behavior of existing
APIs, such that it has potentially high risk for Android
WebView-based applications?

None



Debuggability

None



Will this feature be supported on all six Blink
platforms (Windows, Mac, Linux, ChromeOS, Android,
and Android WebView)?

Yes


Is this feature fully tested by web-platform-tests

?

Yes

https://wpt.fyi/results/css/css-values/round-mod-rem-computed.html
https://wpt.fyi/results/css/css-values/round-mod-rem-invalid.html
https://wpt.fyi/results/css/css-values/round-mod-rem-serialize.html



Flag name on chrome://flags

CSSSteppedValueFunctions


Finch feature name

None


Non-finch justification

None


Requires code in //chrome?

False


Tracking bug

https://issues.chromium.org/issues/40253179


Estimated milestones

Shipping on desktop 125
DevTrial on desktop 119

Shipping on Android 125
DevTrial on Android 119

Shipping on WebView 125



Anticipated spec changes

Open questions about a feature may be a source of future web
compat or interop issues. Please list open issues (e.g. links
to known github issues in the project for the feature
specification) whose resolution may introduce web
compat/interop risk (e.g., changing to naming or structure of
the API in a non-backward-compatible way).

None


Link to entry on the Chrome Platform Status

https://chromestatus.com/feature/5500897196244992

This intent message was generated by Chrome Platform Status
.
-- 
You received this message because you are subscribed to the

Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from
it, send an email to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit

https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAH3Z92_-CiZrV1FR4wBuDV2ootDfhgcERNO6%3DB5HGfPwW1aaBA%40mail.gmail.com

.

--
You received this message because you are subscribed to the Google 
Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, 
send an email to

Re: [blink-dev] Intent to Ship: CSS Stepped Value Functions

2024-04-08 Thread Mike Taylor 

LGTM2

On 4/8/24 10:41 AM, Yoav Weiss (@Shopify) wrote:
Can you please flip on the "debuggability" review bit in chromestatus? 
(feel free to mark it as "N/A" if you think that's the case)


On Mon, Apr 8, 2024 at 4:40 PM Yoav Weiss (@Shopify) 
 wrote:


LGTM1

Thanks for catching us up here!

On Fri, Apr 5, 2024 at 3:53 PM Daniil Sakhapov
 wrote:


Contact emails

sakha...@chromium.org


Explainer

None


Specification

https://drafts.csswg.org/css-values/#round-func


Summary

The stepped-value functions, round(), mod(), and rem(), all
transform a given value according to another "step value". The
round() CSS function returns a rounded number based on a
selected rounding strategy. The mod() CSS function returns a
modulus left over when the first parameter is divided by the
second parameter, similar to the JavaScript remainder operator
(%). The modulus is the value left over when one operand, the
dividend, is divided by a second operand, the divisor. It
always takes the sign of the divisor. The rem() CSS function
returns a remainder left over when the first parameter is
divided by the second parameter, similar to the JavaScript
remainder operator (%). The remainder is the value left over
when one operand, the dividend, is divided by a second
operand, the divisor. It always takes the sign of the dividend.



Blink component

Blink>CSS




TAG review

None


TAG review status

Issues addressed


Risks



Interoperability and Compatibility

None



/Gecko/: Shipped/Shipping

/WebKit/: Shipped/Shipping

/Web developers/: Positive

/Other signals/:


WebView application risks

Does this intent deprecate or change behavior of existing
APIs, such that it has potentially high risk for Android
WebView-based applications?

None



Debuggability

None



Will this feature be supported on all six Blink
platforms (Windows, Mac, Linux, ChromeOS, Android, and
Android WebView)?

Yes


Is this feature fully tested by web-platform-tests

?

Yes

https://wpt.fyi/results/css/css-values/round-mod-rem-computed.html
https://wpt.fyi/results/css/css-values/round-mod-rem-invalid.html
https://wpt.fyi/results/css/css-values/round-mod-rem-serialize.html



Flag name on chrome://flags

CSSSteppedValueFunctions


Finch feature name

None


Non-finch justification

None


Requires code in //chrome?

False


Tracking bug

https://issues.chromium.org/issues/40253179


Estimated milestones

Shipping on desktop 125
DevTrial on desktop 119

Shipping on Android 125
DevTrial on Android 119

Shipping on WebView 125



Anticipated spec changes

Open questions about a feature may be a source of future web
compat or interop issues. Please list open issues (e.g. links
to known github issues in the project for the feature
specification) whose resolution may introduce web
compat/interop risk (e.g., changing to naming or structure of
the API in a non-backward-compatible way).

None


Link to entry on the Chrome Platform Status

https://chromestatus.com/feature/5500897196244992

This intent message was generated by Chrome Platform Status
.
-- 
You received this message because you are subscribed to the

Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from
it, send an email to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit

https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAH3Z92_-CiZrV1FR4wBuDV2ootDfhgcERNO6%3DB5HGfPwW1aaBA%40mail.gmail.com

.

--
You received this message because you are subscribed to the Google 
Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send 
an email to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit

Re: [blink-dev] Intent to Ship: CSS Stepped Value Functions

2024-04-08 Thread Yoav Weiss (@Shopify) 
Can you please flip on the "debuggability" review bit in chromestatus?
(feel free to mark it as "N/A" if you think that's the case)

On Mon, Apr 8, 2024 at 4:40 PM Yoav Weiss (@Shopify) 
wrote:

> LGTM1
>
> Thanks for catching us up here!
>
> On Fri, Apr 5, 2024 at 3:53 PM Daniil Sakhapov 
> wrote:
>
>> Contact emailssakha...@chromium.org
>>
>> ExplainerNone
>>
>> Specificationhttps://drafts.csswg.org/css-values/#round-func
>>
>> Summary
>>
>> The stepped-value functions, round(), mod(), and rem(), all transform a
>> given value according to another "step value". The round() CSS function
>> returns a rounded number based on a selected rounding strategy. The mod()
>> CSS function returns a modulus left over when the first parameter is
>> divided by the second parameter, similar to the JavaScript remainder
>> operator (%). The modulus is the value left over when one operand, the
>> dividend, is divided by a second operand, the divisor. It always takes the
>> sign of the divisor. The rem() CSS function returns a remainder left over
>> when the first parameter is divided by the second parameter, similar to the
>> JavaScript remainder operator (%). The remainder is the value left over
>> when one operand, the dividend, is divided by a second operand, the
>> divisor. It always takes the sign of the dividend.
>>
>>
>> Blink componentBlink>CSS
>> 
>>
>> TAG reviewNone
>>
>> TAG review statusIssues addressed
>>
>> Risks
>>
>>
>> Interoperability and Compatibility
>>
>> None
>>
>>
>> *Gecko*: Shipped/Shipping
>>
>> *WebKit*: Shipped/Shipping
>>
>> *Web developers*: Positive
>>
>> *Other signals*:
>>
>> WebView application risks
>>
>> Does this intent deprecate or change behavior of existing APIs, such that
>> it has potentially high risk for Android WebView-based applications?
>>
>> None
>>
>>
>> Debuggability
>>
>> None
>>
>>
>> Will this feature be supported on all six Blink platforms (Windows, Mac,
>> Linux, ChromeOS, Android, and Android WebView)?Yes
>>
>> Is this feature fully tested by web-platform-tests
>> 
>> ?Yes
>>
>> https://wpt.fyi/results/css/css-values/round-mod-rem-computed.html
>> https://wpt.fyi/results/css/css-values/round-mod-rem-invalid.html
>> https://wpt.fyi/results/css/css-values/round-mod-rem-serialize.html
>>
>>
>> Flag name on chrome://flagsCSSSteppedValueFunctions
>>
>> Finch feature nameNone
>>
>> Non-finch justificationNone
>>
>> Requires code in //chrome?False
>>
>> Tracking bughttps://issues.chromium.org/issues/40253179
>>
>> Estimated milestones
>> Shipping on desktop 125
>> DevTrial on desktop 119
>> Shipping on Android 125
>> DevTrial on Android 119
>> Shipping on WebView 125
>>
>> Anticipated spec changes
>>
>> Open questions about a feature may be a source of future web compat or
>> interop issues. Please list open issues (e.g. links to known github issues
>> in the project for the feature specification) whose resolution may
>> introduce web compat/interop risk (e.g., changing to naming or structure of
>> the API in a non-backward-compatible way).
>> None
>>
>> Link to entry on the Chrome Platform Status
>> https://chromestatus.com/feature/5500897196244992
>>
>> This intent message was generated by Chrome Platform Status
>> .
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "blink-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to blink-dev+unsubscr...@chromium.org.
>> To view this discussion on the web visit
>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAH3Z92_-CiZrV1FR4wBuDV2ootDfhgcERNO6%3DB5HGfPwW1aaBA%40mail.gmail.com
>> 
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSJOewheD045JEhSdEDRGDDQUQMzMTVZkW284vgXex%3Dbuw%40mail.gmail.com.

Re: [blink-dev] Intent to Ship: CSS Stepped Value Functions

2024-04-08 Thread Yoav Weiss (@Shopify) 
LGTM1

Thanks for catching us up here!

On Fri, Apr 5, 2024 at 3:53 PM Daniil Sakhapov 
wrote:

> Contact emailssakha...@chromium.org
>
> ExplainerNone
>
> Specificationhttps://drafts.csswg.org/css-values/#round-func
>
> Summary
>
> The stepped-value functions, round(), mod(), and rem(), all transform a
> given value according to another "step value". The round() CSS function
> returns a rounded number based on a selected rounding strategy. The mod()
> CSS function returns a modulus left over when the first parameter is
> divided by the second parameter, similar to the JavaScript remainder
> operator (%). The modulus is the value left over when one operand, the
> dividend, is divided by a second operand, the divisor. It always takes the
> sign of the divisor. The rem() CSS function returns a remainder left over
> when the first parameter is divided by the second parameter, similar to the
> JavaScript remainder operator (%). The remainder is the value left over
> when one operand, the dividend, is divided by a second operand, the
> divisor. It always takes the sign of the dividend.
>
>
> Blink componentBlink>CSS
> 
>
> TAG reviewNone
>
> TAG review statusIssues addressed
>
> Risks
>
>
> Interoperability and Compatibility
>
> None
>
>
> *Gecko*: Shipped/Shipping
>
> *WebKit*: Shipped/Shipping
>
> *Web developers*: Positive
>
> *Other signals*:
>
> WebView application risks
>
> Does this intent deprecate or change behavior of existing APIs, such that
> it has potentially high risk for Android WebView-based applications?
>
> None
>
>
> Debuggability
>
> None
>
>
> Will this feature be supported on all six Blink platforms (Windows, Mac,
> Linux, ChromeOS, Android, and Android WebView)?Yes
>
> Is this feature fully tested by web-platform-tests
> 
> ?Yes
>
> https://wpt.fyi/results/css/css-values/round-mod-rem-computed.html
> https://wpt.fyi/results/css/css-values/round-mod-rem-invalid.html
> https://wpt.fyi/results/css/css-values/round-mod-rem-serialize.html
>
>
> Flag name on chrome://flagsCSSSteppedValueFunctions
>
> Finch feature nameNone
>
> Non-finch justificationNone
>
> Requires code in //chrome?False
>
> Tracking bughttps://issues.chromium.org/issues/40253179
>
> Estimated milestones
> Shipping on desktop 125
> DevTrial on desktop 119
> Shipping on Android 125
> DevTrial on Android 119
> Shipping on WebView 125
>
> Anticipated spec changes
>
> Open questions about a feature may be a source of future web compat or
> interop issues. Please list open issues (e.g. links to known github issues
> in the project for the feature specification) whose resolution may
> introduce web compat/interop risk (e.g., changing to naming or structure of
> the API in a non-backward-compatible way).
> None
>
> Link to entry on the Chrome Platform Status
> https://chromestatus.com/feature/5500897196244992
>
> This intent message was generated by Chrome Platform Status
> .
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAH3Z92_-CiZrV1FR4wBuDV2ootDfhgcERNO6%3DB5HGfPwW1aaBA%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSLV8RBivu9GCvudaXzd9G%2BQi9nvbT64tGvuVEqH935p1g%40mail.gmail.com.

[blink-dev] Intent to Ship: CSS Stepped Value Functions

2024-04-05 Thread Daniil Sakhapov 
Contact emailssakha...@chromium.org

ExplainerNone

Specificationhttps://drafts.csswg.org/css-values/#round-func

Summary

The stepped-value functions, round(), mod(), and rem(), all transform a
given value according to another "step value". The round() CSS function
returns a rounded number based on a selected rounding strategy. The mod()
CSS function returns a modulus left over when the first parameter is
divided by the second parameter, similar to the JavaScript remainder
operator (%). The modulus is the value left over when one operand, the
dividend, is divided by a second operand, the divisor. It always takes the
sign of the divisor. The rem() CSS function returns a remainder left over
when the first parameter is divided by the second parameter, similar to the
JavaScript remainder operator (%). The remainder is the value left over
when one operand, the dividend, is divided by a second operand, the
divisor. It always takes the sign of the dividend.


Blink componentBlink>CSS


TAG reviewNone

TAG review statusIssues addressed

Risks


Interoperability and Compatibility

None


*Gecko*: Shipped/Shipping

*WebKit*: Shipped/Shipping

*Web developers*: Positive

*Other signals*:

WebView application risks

Does this intent deprecate or change behavior of existing APIs, such that
it has potentially high risk for Android WebView-based applications?

None


Debuggability

None


Will this feature be supported on all six Blink platforms (Windows, Mac,
Linux, ChromeOS, Android, and Android WebView)?Yes

Is this feature fully tested by web-platform-tests

?Yes

https://wpt.fyi/results/css/css-values/round-mod-rem-computed.html
https://wpt.fyi/results/css/css-values/round-mod-rem-invalid.html
https://wpt.fyi/results/css/css-values/round-mod-rem-serialize.html


Flag name on chrome://flagsCSSSteppedValueFunctions

Finch feature nameNone

Non-finch justificationNone

Requires code in //chrome?False

Tracking bughttps://issues.chromium.org/issues/40253179

Estimated milestones
Shipping on desktop 125
DevTrial on desktop 119
Shipping on Android 125
DevTrial on Android 119
Shipping on WebView 125

Anticipated spec changes

Open questions about a feature may be a source of future web compat or
interop issues. Please list open issues (e.g. links to known github issues
in the project for the feature specification) whose resolution may
introduce web compat/interop risk (e.g., changing to naming or structure of
the API in a non-backward-compatible way).
None

Link to entry on the Chrome Platform Status
https://chromestatus.com/feature/5500897196244992

This intent message was generated by Chrome Platform Status
.

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAH3Z92_-CiZrV1FR4wBuDV2ootDfhgcERNO6%3DB5HGfPwW1aaBA%40mail.gmail.com.