Re: [blink-dev] Intent to Ship: 'pagereveal' event

2024-02-02 Thread Chris Harrelson 
LGTM3

On Fri, Feb 2, 2024 at 2:03 PM Mike Taylor  wrote:

> LGMT2 - no concerns about lack of a response from TAG.
> On 2/2/24 1:18 AM, Domenic Denicola wrote:
>
> LGTM1
>
> On Fri, Feb 2, 2024 at 6:53 AM David Bokan  wrote:
>
>> Contact emails bo...@chromium.org, khushalsa...@chromium.org,
>> nrosent...@chromium.org, vmp...@chromium.org
>>
>> Explainer
>> https://github.com/WICG/view-transitions/blob/main/cross-doc-explainer.md
>>
>> Specification https://html.spec.whatwg.org/#reveal
>>
>> Design docs
>> https://github.com/WICG/view-transitions/blob/main/cross-doc-explainer.md
>>
>> Summary
>>
>> The `pagereveal` event is fired on a Document's window object at the
>> first render opportunity after a Document is: initially loaded, restored
>> from the back-forward cache, or activated from a prerender. It can be used
>> by a page author to set up a page entry UX - such as a ViewTransition from
>> a previous state. This feature is split out from the larger Cross Document
>> View Transition project.
>>
>>
>> Blink component Blink>ViewTransitions
>> 
>>
>> Search tags transition
>> , firstrender
>> , reveal
>> , event
>> , viewtransition
>> 
>>
>> TAG review https://github.com/w3ctag/design-reviews/issues/851
>>
>> Note: TAG review was for Cross-Document View Transitions which included
>> this event as a piece. I asked TAG whether they'd like to do a separate
>> review but didn't receive a response.
>>
>
> I'll note that the ask was in 2023-09-28, with two other pings since then,
> so I think this is very fair. (And I also agree that this was covered by
> the original review request.)
>
>>
>> TAG review status Issues addressed
>>
>> Risks
>>
>>
>> Interoperability and Compatibility
>>
>> This is a new event so shouldn't have any compatibility risks. Usual
>> interop risk of other engines not adopting it exists but this should be low
>> since it's had input and discussion[1] from engineers of both WebKit and
>> Mozilla and is a dependency of cross-document view transitions which has
>> received a positive signal from at least Mozilla[2] (waiting to hear from
>> Apple[3]). [1] https://github.com/whatwg/html/issues/9315 [2]
>> https://github.com/mozilla/standards-positions/issues/677
>>
>> [3] https://github.com/WebKit/standards-positions/issues/302
>>
>>
>> *Gecko*: Positive (
>> https://github.com/mozilla/standards-positions/issues/677) See:
>> https://github.com/mozilla/standards-positions/issues/677#issuecomment-1904541389
>>
>> *WebKit*: No signal (
>> https://github.com/WebKit/standards-positions/issues/303) Awaiting
>> response.
>>
>> *Web developers*: No signals
>>
>> *Other signals*:
>>
>> WebView application risks
>>
>> Does this intent deprecate or change behavior of existing APIs, such that
>> it has potentially high risk for Android WebView-based applications?
>>
>> No
>>
>>
>> Debuggability
>>
>> None
>>
>>
>> Will this feature be supported on all six Blink platforms (Windows, Mac,
>> Linux, ChromeOS, Android, and Android WebView)? Yes
>>
>> This is a standard HTML event applicable to all platforms
>>
>>
>> Is this feature fully tested by web-platform-tests
>> 
>> ? Yes
>>
>>
>> https://wpt.fyi/results/html/browsers/browsing-the-web/history-traversal/pagereveal?label=experimental=master
>>
>
> Can you un-tentative these tests?
>
>
>>
>>
>> Flag name on chrome://flags
>> chrome://flags/#enable-experimental-web-platform-features
>>
>> Finch feature name PageRevealEvent
>>
>> Requires code in //chrome? False
>>
>> Tracking bug https://crbug.com/1466250
>>
>> Estimated milestones
>> Shipping on desktop 123
>> DevTrial on desktop 120
>> Shipping on Android 123
>> DevTrial on Android 120
>> Shipping on WebView 123
>>
>> Anticipated spec changes
>>
>> Open questions about a feature may be a source of future web compat or
>> interop issues. Please list open issues (e.g. links to known github issues
>> in the project for the feature specification) whose resolution may
>> introduce web compat/interop risk (e.g., changing to naming or structure of
>> the API in a non-backward-compatible way).
>> None
>>
>> Link to entry on the Chrome Platform Status
>> https://chromestatus.com/feature/5205586941837312
>>
>> Links to previous Intent discussions Intent to prototype:
>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f0f76584-ea3f-43ab-946c-b920fc064344n%40chromium.org
>>
>> This intent message was generated by Chrome Platform Status
>> .
>> --
>> You received this message because you are subscribed to the Google Groups
>> "blink-dev" group.
>> To

Re: [blink-dev] Intent to Ship: 'pagereveal' event

2024-02-02 Thread Mike Taylor 

LGMT2 - no concerns about lack of a response from TAG.

On 2/2/24 1:18 AM, Domenic Denicola wrote:

LGTM1

On Fri, Feb 2, 2024 at 6:53 AM David Bokan  wrote:


Contact emails

bo...@chromium.org, khushalsa...@chromium.org,
nrosent...@chromium.org, vmp...@chromium.org


Explainer

https://github.com/WICG/view-transitions/blob/main/cross-doc-explainer.md


Specification

https://html.spec.whatwg.org/#reveal


Design docs


https://github.com/WICG/view-transitions/blob/main/cross-doc-explainer.md


Summary

The `pagereveal` event is fired on a Document's window object at
the first render opportunity after a Document is: initially
loaded, restored from the back-forward cache, or activated from a
prerender. It can be used by a page author to set up a page entry
UX - such as a ViewTransition from a previous state. This feature
is split out from the larger Cross Document View Transition project.



Blink component

Blink>ViewTransitions




Search tags

transition ,
firstrender ,
reveal , event
, viewtransition



TAG review

https://github.com/w3ctag/design-reviews/issues/851

Note: TAG review was for Cross-Document View Transitions which
included this event as a piece. I asked TAG whether they'd like to
do a separate review but didn't receive a response.


I'll note that the ask was in 2023-09-28, with two other pings since 
then, so I think this is very fair. (And I also agree that this was 
covered by the original review request.)



TAG review status

Issues addressed


Risks



Interoperability and Compatibility

This is a new event so shouldn't have any compatibility risks.
Usual interop risk of other engines not adopting it exists but
this should be low since it's had input and discussion[1] from
engineers of both WebKit and Mozilla and is a dependency of
cross-document view transitions which has received a positive
signal from at least Mozilla[2] (waiting to hear from Apple[3]).
[1] https://github.com/whatwg/html/issues/9315 [2]
https://github.com/mozilla/standards-positions/issues/677

[3] https://github.com/WebKit/standards-positions/issues/302



/Gecko/: Positive
(https://github.com/mozilla/standards-positions/issues/677) See:

https://github.com/mozilla/standards-positions/issues/677#issuecomment-1904541389

/WebKit/: No signal
(https://github.com/WebKit/standards-positions/issues/303)
Awaiting response.

/Web developers/: No signals

/Other signals/:


WebView application risks

Does this intent deprecate or change behavior of existing APIs,
such that it has potentially high risk for Android WebView-based
applications?

No



Debuggability

None



Will this feature be supported on all six Blink platforms
(Windows, Mac, Linux, ChromeOS, Android, and Android WebView)?

Yes

This is a standard HTML event applicable to all platforms



Is this feature fully tested by web-platform-tests

?

Yes


https://wpt.fyi/results/html/browsers/browsing-the-web/history-traversal/pagereveal?label=experimental=master




Can you un-tentative these tests?



Flag name on chrome://flags

chrome://flags/#enable-experimental-web-platform-features


Finch feature name

PageRevealEvent


Requires code in //chrome?

False


Tracking bug

https://crbug.com/1466250


Estimated milestones

Shipping on desktop 123
DevTrial on desktop 120

Shipping on Android 123
DevTrial on Android 120

Shipping on WebView 123



Anticipated spec changes

Open questions about a feature may be a source of future web
compat or interop issues. Please list open issues (e.g. links to
known github issues in the project for the feature specification)
whose resolution may introduce web compat/interop risk (e.g.,
changing to naming or structure of the API in a
non-backward-compatible way).

None


Link to entry on the Chrome Platform Status

https://chromestatus.com/feature/5205586941837312


Links to previous Intent

Re: [blink-dev] Intent to Ship: 'pagereveal' event

2024-02-02 Thread David Bokan 
On Friday, February 2, 2024 at 9:35:13 AM UTC-5 David Bokan wrote:

On Friday, February 2, 2024 at 1:18:42 AM UTC-5 Domenic Denicola wrote:

Can you un-tentative these tests?


Sure, will do this today! 


 Done.

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/3b2df66a-aadf-4c45-aa28-48c7344db9a0n%40chromium.org.

Re: [blink-dev] Intent to Ship: 'pagereveal' event

2024-02-02 Thread Christian Biesinger 
On Thu, Feb 1, 2024 at 4:53 PM David Bokan  wrote:

> Contact emailsbo...@chromium.org, khushalsa...@chromium.org,
> nrosent...@chromium.org, vmp...@chromium.org
>
> Explainer
> https://github.com/WICG/view-transitions/blob/main/cross-doc-explainer.md
>
> Specificationhttps://html.spec.whatwg.org/#reveal
>
> Design docs
> https://github.com/WICG/view-transitions/blob/main/cross-doc-explainer.md
>
> Summary
>
> The `pagereveal` event is fired on a Document's window object at the first
> render opportunity after a Document is: initially loaded, restored from the
> back-forward cache, or activated from a prerender. It can be used by a page
> author to set up a page entry UX - such as a ViewTransition from a previous
> state. This feature is split out from the larger Cross Document View
> Transition project.
>

If someone else was wondering, the explainer does say:
"Note that this event is different from pageshow
 as a newly
initialized document fires pageshow is only once the document is fully
loaded."

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPTJ0XFV-3CPS9jEdoYF3GGXU3rwZdhefr%2Bs%3DdiScFpaZ_wqTQ%40mail.gmail.com.

Re: [blink-dev] Intent to Ship: 'pagereveal' event

2024-02-02 Thread David Bokan 
On Friday, February 2, 2024 at 1:18:42 AM UTC-5 Domenic Denicola wrote:

Can you un-tentative these tests?


Sure, will do this today! 

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/6b4280fe-cd1b-46a4-9de0-bd211e137992n%40chromium.org.

Re: [blink-dev] Intent to Ship: 'pagereveal' event

2024-02-01 Thread Domenic Denicola 
LGTM1

On Fri, Feb 2, 2024 at 6:53 AM David Bokan  wrote:

> Contact emailsbo...@chromium.org, khushalsa...@chromium.org,
> nrosent...@chromium.org, vmp...@chromium.org
>
> Explainer
> https://github.com/WICG/view-transitions/blob/main/cross-doc-explainer.md
>
> Specificationhttps://html.spec.whatwg.org/#reveal
>
> Design docs
> https://github.com/WICG/view-transitions/blob/main/cross-doc-explainer.md
>
> Summary
>
> The `pagereveal` event is fired on a Document's window object at the first
> render opportunity after a Document is: initially loaded, restored from the
> back-forward cache, or activated from a prerender. It can be used by a page
> author to set up a page entry UX - such as a ViewTransition from a previous
> state. This feature is split out from the larger Cross Document View
> Transition project.
>
>
> Blink componentBlink>ViewTransitions
> 
>
> Search tagstransition 
> , firstrender , reveal
> , event
> , viewtransition
> 
>
> TAG reviewhttps://github.com/w3ctag/design-reviews/issues/851
>
> Note: TAG review was for Cross-Document View Transitions which included
> this event as a piece. I asked TAG whether they'd like to do a separate
> review but didn't receive a response.
>

I'll note that the ask was in 2023-09-28, with two other pings since then,
so I think this is very fair. (And I also agree that this was covered by
the original review request.)

>
> TAG review statusIssues addressed
>
> Risks
>
>
> Interoperability and Compatibility
>
> This is a new event so shouldn't have any compatibility risks. Usual
> interop risk of other engines not adopting it exists but this should be low
> since it's had input and discussion[1] from engineers of both WebKit and
> Mozilla and is a dependency of cross-document view transitions which has
> received a positive signal from at least Mozilla[2] (waiting to hear from
> Apple[3]). [1] https://github.com/whatwg/html/issues/9315 [2]
> https://github.com/mozilla/standards-positions/issues/677
>
> [3] https://github.com/WebKit/standards-positions/issues/302
>
>
> *Gecko*: Positive (
> https://github.com/mozilla/standards-positions/issues/677) See:
> https://github.com/mozilla/standards-positions/issues/677#issuecomment-1904541389
>
> *WebKit*: No signal (
> https://github.com/WebKit/standards-positions/issues/303) Awaiting
> response.
>
> *Web developers*: No signals
>
> *Other signals*:
>
> WebView application risks
>
> Does this intent deprecate or change behavior of existing APIs, such that
> it has potentially high risk for Android WebView-based applications?
>
> No
>
>
> Debuggability
>
> None
>
>
> Will this feature be supported on all six Blink platforms (Windows, Mac,
> Linux, ChromeOS, Android, and Android WebView)?Yes
>
> This is a standard HTML event applicable to all platforms
>
>
> Is this feature fully tested by web-platform-tests
> 
> ?Yes
>
>
> https://wpt.fyi/results/html/browsers/browsing-the-web/history-traversal/pagereveal?label=experimental=master
>

Can you un-tentative these tests?


>
>
> Flag name on chrome://flags
> chrome://flags/#enable-experimental-web-platform-features
>
> Finch feature namePageRevealEvent
>
> Requires code in //chrome?False
>
> Tracking bughttps://crbug.com/1466250
>
> Estimated milestones
> Shipping on desktop 123
> DevTrial on desktop 120
> Shipping on Android 123
> DevTrial on Android 120
> Shipping on WebView 123
>
> Anticipated spec changes
>
> Open questions about a feature may be a source of future web compat or
> interop issues. Please list open issues (e.g. links to known github issues
> in the project for the feature specification) whose resolution may
> introduce web compat/interop risk (e.g., changing to naming or structure of
> the API in a non-backward-compatible way).
> None
>
> Link to entry on the Chrome Platform Status
> https://chromestatus.com/feature/5205586941837312
>
> Links to previous Intent discussionsIntent to prototype:
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f0f76584-ea3f-43ab-946c-b920fc064344n%40chromium.org
>
> This intent message was generated by Chrome Platform Status
> .
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CANMmsAvhWAzVrHCudjLgQRtePgqEHucNqb27Wkn9r4dCKeUTWg%40mail.gmail.com
>