Re: [blink-dev] Intent to Ship: Attribution Reporting Feature: Referrer Policy for Attributionsrc Requests

2024-05-19 Thread Domenic Denicola
LGTM1.

This looks like a small, well-considered change that makes the platform
more consistent. I agree the compat risks are small.

>From what I understand, fields like TAG review and standards-positions for
other browsers should be covered by the larger umbrella feature, so we
shouldn't block on them. However, I would encourage you to include those
fields in future Intents, stating that rationale for omitting the reviews.

On Sat, May 18, 2024 at 1:21 AM 'Akash Nadan' via blink-dev <
blink-dev@chromium.org> wrote:

> Contact emails
>
> akashna...@google.com, lin...@chromium.org, johni...@chromium.org
>
> Explainer
>
> Attribution Reporting with event-level reports
> 
>
> Attribution Reporting API with Aggregatable Reports
> 
>
> Aggregation Service for the Attribution Reporting API
> 
>
> Specification
>
> https://wicg.github.io/attribution-reporting-api/
>
> Blink component
>
> Internals > AttributionReporting
> 
>
> Summary
>
> We are landing the following change to the Attribution Reporting API
> focused on:
>
>-
>
>applying element-level referrer policy for specific html elements
>
>
> This change is based on ad-tech feedback
>  and so
> that attributionsrc requests are treated like other subresources on the
> page.
>
> Currently when the API is called through the use of the attributionsrc
> attribution as part of various html elements (i.e. , 

Re: [blink-dev] Intent to Ship: Attribution Reporting Feature: Referrer Policy for Attributionsrc Requests

2024-05-20 Thread Mike Taylor
LGTM2 (and yes, please don't emit other info in future intents - it 
really helps with reviews!)


On 5/20/24 1:19 AM, Domenic Denicola wrote:

LGTM1.

This looks like a small, well-considered change that makes the 
platform more consistent. I agree the compat risks are small.


From what I understand, fields like TAG review and standards-positions 
for other browsers should be covered by the larger umbrella feature, 
so we shouldn't block on them. However, I would encourage you to 
include those fields in future Intents, stating that rationale for 
omitting the reviews.


On Sat, May 18, 2024 at 1:21 AM 'Akash Nadan' via blink-dev 
 wrote:


Contact emails

akashna...@google.com ,
lin...@chromium.org ,
johni...@chromium.org 


Explainer

Attribution Reporting with event-level reports


Attribution Reporting API with Aggregatable Reports


Aggregation Service for the Attribution Reporting API




Specification

https://wicg.github.io/attribution-reporting-api/



Blink component

Internals > AttributionReporting




Summary

We are landing the following change to the Attribution Reporting
API focused on:

 *

applying element-level referrer policy for specific html elements


This change is based on ad-tech feedback
and
so that attributionsrc requests are treated like other
subresources on the page.


Currently when the API is called through the use of the
attributionsrc attribution as part of various html elements (i.e.
, 

Re: [blink-dev] Intent to Ship: Attribution Reporting Feature: Referrer Policy for Attributionsrc Requests

2024-05-20 Thread Chris Harrelson
LGTM3

On Mon, May 20, 2024 at 6:32 AM Mike Taylor  wrote:

> LGTM2 (and yes, please don't emit other info in future intents - it really
> helps with reviews!)
> On 5/20/24 1:19 AM, Domenic Denicola wrote:
>
> LGTM1.
>
> This looks like a small, well-considered change that makes the platform
> more consistent. I agree the compat risks are small.
>
> From what I understand, fields like TAG review and standards-positions for
> other browsers should be covered by the larger umbrella feature, so we
> shouldn't block on them. However, I would encourage you to include those
> fields in future Intents, stating that rationale for omitting the reviews.
>
> On Sat, May 18, 2024 at 1:21 AM 'Akash Nadan' via blink-dev <
> blink-dev@chromium.org> wrote:
>
>> Contact emails
>>
>> akashna...@google.com, lin...@chromium.org, johni...@chromium.org
>>
>> Explainer
>>
>> Attribution Reporting with event-level reports
>> 
>>
>> Attribution Reporting API with Aggregatable Reports
>> 
>>
>> Aggregation Service for the Attribution Reporting API
>> 
>>
>> Specification
>>
>> https://wicg.github.io/attribution-reporting-api/
>>
>> Blink component
>>
>> Internals > AttributionReporting
>> 
>>
>> Summary
>>
>> We are landing the following change to the Attribution Reporting API
>> focused on:
>>
>>-
>>
>>applying element-level referrer policy for specific html elements
>>
>>
>> This change is based on ad-tech feedback
>>  and so
>> that attributionsrc requests are treated like other subresources on the
>> page.
>>
>> Currently when the API is called through the use of the attributionsrc
>> attribution as part of various html elements (i.e. ,