Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin
#280: Move multiproduct.model.ModelBase to dashboard plugin ---+ Reporter: olemis| Owner: franco Type: enhancement | Status: accepted Priority: trivial | Milestone: Component: multiproduct |Version: Resolution:| Keywords: database model testing ---+ Comment (by rjollos): I haven't seen the previous discussion in which it was decided to move common components to dashboard, but my initial impression is that it doesn't make much more sense to have them in dashboard than in multiproduct. I had a brief discussion about this with gjm this evening, and we both think it might make sense to move the components to a new `bloodhound_core` directory. I also think that `ModelBase.py` should be in `model.py` rather than `db.py`. My understanding is that only the schema and environment upgrade hooks should be in `db.py`. I've committed the fixes for the test cases in r1418224. Thank you franco and olemis! I look forward to hearing your comments on these other issues. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:5 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin
#280: Move multiproduct.model.ModelBase to dashboard plugin ---+ Reporter: olemis| Owner: franco Type: enhancement | Status: accepted Priority: trivial | Milestone: Component: multiproduct |Version: Resolution:| Keywords: database model testing ---+ Comment (by olemis): Replying to [comment:5 rjollos]: I haven't seen the previous discussion in which it was decided to move common components to dashboard, There's no such record since that was one of the first decisions we made about Bloodhound . I'm not even sure we had neither mailing lists setup nor even project page at the time . but my initial impression is that it doesn't make much more sense to have them in dashboard than in multiproduct. I had a brief discussion about this with gjm this evening, and we both think it might make sense to move the components to a new `bloodhound_core` directory. At the time there was no much time to create and manage a new bloohound_core directory that noone knew what'd happen with it in the future . After considering both options we decided that shared assets would be placed in dashboard because all other plugins already depended upon it (for widgets). I also think that `ModelBase.py` should be in `model.py` rather than `db.py`. My understanding is that only the schema and environment upgrade hooks should be in `db.py`. +1 I've committed the fixes for the test cases in r1418224. Thank you franco and olemis! A big thank you for taking the the time to review and commit . :) -- Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:6 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin
#280: Move multiproduct.model.ModelBase to dashboard plugin ---+ Reporter: olemis| Owner: Type: enhancement | Status: new Priority: trivial | Milestone: Component: multiproduct |Version: Resolution:| Keywords: database model testing ---+ Changes (by olemis): * owner: franco = * status: accepted = new -- Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:7 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin
#280: Move multiproduct.model.ModelBase to dashboard plugin ---+ Reporter: olemis| Owner: olemis Type: enhancement | Status: assigned Priority: trivial | Milestone: Component: multiproduct |Version: Resolution:| Keywords: database model testing ---+ Changes (by olemis): * owner: = olemis * status: new = assigned -- Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:8 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin
#280: Move multiproduct.model.ModelBase to dashboard plugin ---+ Reporter: olemis| Owner: franco Type: enhancement | Status: review Priority: trivial | Milestone: Component: multiproduct |Version: Resolution:| Keywords: database model testing ---+ Changes (by franco): * status: accepted = review Comment: Until further discussion takes place, and it get to be finally decided if creating the new bloodhound_core directory, I have submitted two new revisions: [https://bitbucket.org/jose_angel_franco/bloodhound- dashboard/commits/9e3ae4c54bb8b93844088559686804a6] [https://bitbucket.org/jose_angel_franco/bloodhound_multiproduct/commits/d39109663a717d7743109507fb22d335] moving ModelBase to model.py as accurately observed by rjollos. I pass the solution to revision state, you can grab the diffs here: [https://bitbucket.org/jose_angel_franco/bloodhound_multiproduct/compare/t280_move_modelbase_to_dashboard..default] [https://bitbucket.org/jose_angel_franco/bloodhound- dashboard/compare/t280_move_modelbase_to_dashboard..default] Best regards, Franco Best regards, Franco. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:10 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin
#280: Move multiproduct.model.ModelBase to dashboard plugin ---+ Reporter: olemis| Owner: franco Type: enhancement | Status: review Priority: trivial | Milestone: Component: multiproduct |Version: Resolution:| Keywords: database model testing ---+ Comment (by rjollos): Replying to [comment:6 olemis]: At the time there was no much time to create and manage a new bloohound_core directory that noone knew what'd happen with it in the future . After considering both options we decided that shared assets would be placed in dashboard because all other plugins already depended upon it (for widgets). Yeah, I understand. Been there ;) This ticket might not be the best place to tackle such a major reorganization. I'm also wondering if all of the `bloodhound_*` plugins should become a single plugin, so that we can have a single `setup.py` and a directory structure like: {{{ bloodhound/model.py bloodhound/dashboard bloodhound/search }}} This would in some ways mirror the directory structure of Trac. Are there reasons we wouldn't want to do this? Im inclined to commit Franco's latest patch and leave these reorganization issues for another ticket. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:11 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin
#280: Move multiproduct.model.ModelBase to dashboard plugin ---+ Reporter: olemis| Owner: franco Type: enhancement | Status: review Priority: trivial | Milestone: Component: multiproduct |Version: Resolution:| Keywords: database model testing ---+ Comment (by rjollos): Replying to [comment:10 franco]: Until further discussion takes place, and it get to be finally decided if creating the new bloodhound_core directory, I have submitted two new revisions: Thanks for the quick follow-up. Just a quick hint - to make the ticket comments a bit more readable, try using the following markup `[url label]`, where in this case label is the first 6 characters of the hash. That way we get nice inline links like: [https://bitbucket.org/jose_angel_franco/bloodhound_multiproduct/commits/d39109663a717d7743109507fb22d335 d39109]. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:12 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin
#280: Move multiproduct.model.ModelBase to dashboard plugin ---+ Reporter: olemis| Owner: franco Type: enhancement | Status: review Priority: trivial | Milestone: Component: multiproduct |Version: Resolution:| Keywords: database model testing ---+ Comment (by gjm): This is all fair comment. I am a little averse to making two changes where one would do but I can compromise on that for now. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:13 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin
#280: Move multiproduct.model.ModelBase to dashboard plugin ---+ Reporter: olemis| Owner: franco Type: enhancement | Status: accepted Priority: trivial | Milestone: Component: multiproduct |Version: Resolution:| Keywords: database model testing ---+ Changes (by franco): * status: assigned = accepted -- Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:4 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin
#280: Move multiproduct.model.ModelBase to dashboard plugin ---+ Reporter: olemis| Owner: olemis Type: enhancement | Status: accepted Priority: trivial | Milestone: Component: multiproduct |Version: Resolution:| Keywords: database model testing ---+ Changes (by olemis): * owner: nobody = olemis * keywords: database model = database model testing * status: new = accepted Comment: Besides test cases for multi-product are outdate . {{{ #!py from multiproduct.model import MultiProductEnvironmentProvider }}} This class is not there any more. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:2 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
[Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin
#280: Move multiproduct.model.ModelBase to dashboard plugin +--- Reporter: olemis | Owner: nobody Type: enhancement | Status: new Priority: major| Component: multiproduct Version: | Resolution: +--- -- Ticket URL: https://issues.apache.org/bloodhound/ticket/280 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin
#280: Move multiproduct.model.ModelBase to dashboard plugin ---+ Reporter: olemis| Owner: nobody Type: enhancement | Status: new Priority: trivial | Milestone: Component: multiproduct |Version: Resolution:| Keywords: database model ---+ Changes (by olemis): * priority: major = trivial * cc: olemis+bh@… (added) * keywords: = database model Old description: New description: New Bloodhound plugins will be added with time and they'll deal with database access . In such cases it'd be useful to reuse `multiproduct.model.ModelBase` . However by doing so an explicit dependency with multi-product plugin will be needed . I propose to move that class to dashboard , considering the fact that we have already decided to include in there shared classes, assets , ... -- -- Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:1 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker