Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+ Reporter: jdreimann| Owner: gjm Type: enhancement | Status: review Priority: critical | Milestone: Release 4 Component: dashboard|Version: Resolution: | Keywords: inplace bheditable --+ Comment (by gjm): r1427698 applies t146_r1418195_ticket_header.diff r1427699 applies t146_r1420132_inplace_ticket_fields.diff r1427702 applies t146_r1420132_inplace_ticket_desc.diff r1427717 applies t146_r1420132_inplace_ticket_form.diff thanks olemis. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:41 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+ Reporter: jdreimann| Owner: gjm Type: enhancement | Status: closed Priority: critical | Milestone: Release 4 Component: dashboard|Version: Resolution: fixed| Keywords: inplace bheditable --+ Changes (by gjm): * status: review = closed * resolution: = fixed Comment: Calling this complete - further enhancements in new tickets. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:42 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+ Reporter: jdreimann| Owner: gjm Type: enhancement | Status: review Priority: critical | Milestone: Release 4 Component: dashboard|Version: Resolution: | Keywords: inplace bheditable --+ Comment (by gjm): This looks pretty good for committing. There are a few issues left but I think it is probably better to commit this work and raise new tickets for any required tweaks. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:39 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+ Reporter: jdreimann| Owner: gjm Type: enhancement | Status: review Priority: critical | Milestone: Release 4 Component: dashboard|Version: Resolution: | Keywords: inplace bheditable --+ Comment (by olemis): Replying to [comment:39 gjm]: [...] There are a few issues left I've detected some potential issues too ... low priority afaics . but I think it is probably better to commit this work and raise new tickets for any required tweaks. I'm ok with that approach . -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:40 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+ Reporter: jdreimann| Owner: gjm Type: enhancement | Status: review Priority: critical | Milestone: Release 4 Component: dashboard|Version: Resolution: | Keywords: inplace bheditable --+ Changes (by jdreimann): * owner: jdreimann = gjm Comment: I assume the textfield next to the Update button is the ticket summary? I would change the button style from btn-primary to btn-warning or btn- danger for higher contrast, but other than that I'd say +1 to commit this so we can actually run it locally and improve on what's built already. This ticket has been going on for too long and unwieldy. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:37 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+ Reporter: jdreimann| Owner: jdreimann Type: enhancement | Status: review Priority: critical | Milestone: Release 4 Component: dashboard|Version: Resolution: | Keywords: inplace bheditable --+ Changes (by olemis): * owner: olemis = jdreimann * status: accepted = review Comment: After comment:32 I have refreshed previous patches and attached new patch implementing ticket submission . Patch order in comment:27 updated accordingly . Other minor enhancements have been added consisting of : summary: BH Theme #146 : In-place submit form . Sticky panel relocated and other minor changes summary: BH Theme #146 : Discard inline modifications summary: BH Theme #146 : Tooltips for workflow actions summary: BH Theme #146 : Edit mode not reentrant plus .editing = .edit-active summary: BH Theme #146 : Workflow drop down visible on affix summary: BH Theme #146 : Use JS templates to render in-place submit controls summary: BH Theme #146 : Ticket in-plece submit controls Anyway , after all this editable state will look like shown below : [[Image(bh_theme_x_91_ticket_responsive_submit_workflow.png, width=600)]] I'm forwarding ticket for further review of workflow drop down menu from a UI/UX perspective . A few comments on that subject . 1. Update / cancel buttons placed in sticky panel so that they'll always be handy in edit mode 2. Update button highlighted (`btn-primary`) because it has to be that relevant on edit mode . Otherwise it's hard to notice since it shows up out of nowhere . 3. Reduced space = reduced visibility of action hints (i.e. tooltips) 4. Selected workflow action appended to ''Update'' label to allow one click edits . Otherwise it is obscured the intentions and difficult to figure out what's gonna happen with ticket in the end . Beyond this , there should be some room for enhancements . That's sure . I suggest to tackle improvements on separate tickets . -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:36 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+ Reporter: jdreimann| Owner: olemis Type: enhancement | Status: accepted Priority: critical | Milestone: Release 4 Component: dashboard|Version: Resolution: | Keywords: inplace bheditable --+ Comment (by olemis): Replying to [comment:33 jdreimann]: Replying to [comment:32 olemis]: [...] Anyway , after all this editable state will look like shown below : [img] I assume the look of the drop down button and the red background for selected radio button/checkbox are browser dependent? Browser dependent. Would be nice to have consistent look and feel across different platforms . Just checking to make sure it isn't styled that way. ;) -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:34 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+ Reporter: jdreimann| Owner: olemis Type: enhancement | Status: accepted Priority: critical | Milestone: Release 4 Component: dashboard|Version: Resolution: | Keywords: inplace bheditable --+ Comment (by olemis): I have submitted new files to rebase patches against r1420132 . Patch order in comment:27 updated accordingly . I have also added a new patch to edit special ticket fields , namely description, keywords, summary and reporter . At present they will remain in view state if permissions are not sufficient . Other minor enhancements have been added like tagging editable fields with `data-edit=inplace` , custom textarea size , etc ... Anyway , after all this editable state will look like shown below : [[Image(bh_theme_x_90_ticket_responsive_edit_all.png, width=600)]] -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:32 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+ Reporter: jdreimann| Owner: olemis Type: enhancement | Status: accepted Priority: critical | Milestone: Release 4 Component: dashboard|Version: Resolution: | Keywords: inplace bheditable --+ Comment (by gjm): Note: t146/t146_r1418195_scrollspy_btn.diff committed as part of #295 -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:31 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects
--+
Reporter: jdreimann| Owner: olemis
Type: enhancement | Status: accepted
Priority: critical | Milestone: Release 4
Component: dashboard|Version:
Resolution: | Keywords: inplace bheditable
--+
Comment (by olemis):
The new approach to in-place editing in ticket view is not compatible with
jEditable afaics . Hence I've built everything from scratch . Attached
patches against theme plugin add the following features :
1. Enhanced ticket fields list updated according to responsive mockups
2. Enhanced scroll spy nav bar implemented with Bootstrap button groups
like sketched in responsive mockups
3. Modify ticket section is gone
4. On clicking Modify Ticket button in scroll spy nav bar , ticket view
enters editable state (suggested by jure)
Patches should be applied against bloodhound_theme @ r1418195 in the
following order :
{{{
#!sh
$ hg qapplied
t146/t146_r1418195_scrollspy_btn.diff
t146/t146_r1418195_ticket_header.diff
t146/t146_r1418195_inplace_ticket_fields.diff
}}}
Issues found so far :
1. In editable state scroll spy does not activate nav item accurately.
This happens because heights are different (e.g. wiki toolbar added
on top of some textarea elements , etc ...) to the values when
scroll spy was installed.
... /me figuring out how to fix .
After all this ticket view will look like shown below in view mode ...
[[Image(bh_theme_x_86_ticket_responsive_view_state.png, width=600)]]
... and in editable mode ...
[[Image(bh_theme_x_87_ticket_responsive_edit_state.png, width=600)]]
Still there are many open questions :
1. What happens after ticket enters editable state ?
2. What about workflow actions now that Modify Ticket section is gone?
3. Should description, keywords and summary be put into editable
as well (... IMO they should , I'm just looking for
confirmation ...) ?
Feedback is welcome .
--
Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:27
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+ Reporter: jdreimann| Owner: olemis Type: enhancement | Status: accepted Priority: critical | Milestone: Release 4 Component: dashboard|Version: Resolution: | Keywords: inplace bheditable --+ Comment (by gjm): Replying to [comment:27 olemis]: 1. What happens after ticket enters editable state ? after edits we clearly need a Submit Changes button and a cancel button. Submission and cancelling probably imply a change back to the non-editable state so perhaps we need a revert button that only resets the fields as well? 2. What about workflow actions now that Modify Ticket section is gone? We still need the modify ticket area for that until there is an alternative solution for workflow. 3. Should description, keywords and summary be put into editable as well (... IMO they should , I'm just looking for confirmation ...) ? Yes.. until otherwise noted, we will require that. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:28 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+ Reporter: jdreimann| Owner: olemis Type: enhancement | Status: accepted Priority: critical | Milestone: Release 4 Component: dashboard|Version: Resolution: | Keywords: inplace bheditable --+ Comment (by jdreimann): Replying to [comment:28 gjm]: Replying to [comment:27 olemis]: 1. What happens after ticket enters editable state ? after edits we clearly need a Submit Changes button and a cancel button. Submission and cancelling probably imply a change back to the non-editable state so perhaps we need a revert button that only resets the fields as well? I think Submit button and a Cancel button (with `btn-link` class to show it's a secondary action) will be enough. 2. What about workflow actions now that Modify Ticket section is gone? We still need the modify ticket area for that until there is an alternative solution for workflow. What stops us from workflow simply being a dropdown of options? `review, resolve, info request` etc. 3. Should description, keywords and summary be put into editable as well (... IMO they should , I'm just looking for confirmation ...) ? Yes.. until otherwise noted, we will require that. +1 -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:29 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+ Reporter: jdreimann| Owner: olemis Type: enhancement | Status: accepted Priority: critical | Milestone: Release 4 Component: dashboard|Version: Resolution: | Keywords: inplace bheditable --+ Comment (by gjm): Replying to [comment:29 jdreimann]: Replying to [comment:28 gjm]: Replying to [comment:27 olemis]: 1. What happens after ticket enters editable state ? after edits we clearly need a Submit Changes button and a cancel button. Submission and cancelling probably imply a change back to the non- editable state so perhaps we need a revert button that only resets the fields as well? I think Submit button and a Cancel button (with `btn-link` class to show it's a secondary action) will be enough. Fair enough.. certainly good enough for now 2. What about workflow actions now that Modify Ticket section is gone? We still need the modify ticket area for that until there is an alternative solution for workflow. What stops us from workflow simply being a dropdown of options? `review, resolve, info request` etc. I was thinking a similar way but the control is a little more complicated in needing a second input to change assignment for some actions. I don't know if there would be more cases to take into account with plugins that extend the functionality of course. 3. Should description, keywords and summary be put into editable as well (... IMO they should , I'm just looking for confirmation ...) ? Yes.. until otherwise noted, we will require that. +1 -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:30 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+ Reporter: jdreimann| Owner: Type: enhancement | Status: assigned Priority: critical | Milestone: Release 4 Component: dashboard|Version: Resolution: | Keywords: inplace bheditable --+ Changes (by olemis): * status: needinfo = assigned Comment: Instructions confirmed in [http://mail-archives.apache.org/mod_mbox /incubator-bloodhound-dev/201211.mbox/%3cCAKoya91u=peYCkfxXJ4LgZ- FUV6yJ5zt-_Q=hcd3ynmrrfg...@mail.gmail.com%3e a message] sent to bloodhound-dev ML . I'll start working on this following suggestions provided by gjm and jdreimann . -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:25 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+ Reporter: jdreimann| Owner: olemis Type: enhancement | Status: accepted Priority: critical | Milestone: Release 4 Component: dashboard|Version: Resolution: | Keywords: inplace bheditable --+ Changes (by olemis): * status: assigned = accepted * owner: = olemis -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:26 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+ Reporter: jdreimann| Owner: Type: enhancement | Status: needinfo Priority: critical | Milestone: Release 3 Component: dashboard|Version: Resolution: | Keywords: inplace bheditable --+ Changes (by olemis): * status: accepted = needinfo * owner: olemis = Comment: Work on this ticket is suspended until we figure out how in-place editing should work . Open discussion's been held in bloodhound- d...@incubator.apache.org -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:24 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+ Reporter: jdreimann| Owner: olemis Type: enhancement | Status: accepted Priority: critical | Milestone: Release 2 Component: dashboard|Version: Resolution: | Keywords: inplace bheditable --+ Comment (by olemis): Attached patches have to be refreshed after #217 , #223 and especially considering [comment:9:ticket:206 enhancements] in ticket fields UI . -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:23 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+--- Reporter: jdreimann| Owner: olemis Type: enhancement | Status: accepted Priority: critical | Milestone: Release 2 Component: dashboard|Version: Resolution: | Keywords: --+--- Comment (by jdreimann): Replying to [comment:19 olemis]: Inplace editor for ticket radio fields . Please take a look at image below . Feedback is welcome Looks good to me. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:21 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+--- Reporter: jdreimann| Owner: olemis Type: enhancement | Status: accepted Priority: critical | Milestone: Release 2 Component: dashboard|Version: Resolution: | Keywords: --+--- Comment (by olemis): I have refreshed and uploaded two patches . I've also erased patches introducing iPhone style checkboxes from my local patch queue . Hence I've also updated [comment:14:ticket:146 patch order] . Main changes are : - Use plain old checkboxes - Inplace editor for ticket radio fields . Please take a look at image below . Feedback is welcome [[Image(bh_theme_x_71_ticket_inplace_radio.png, width=600)]] -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:19 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+--- Reporter: jdreimann| Owner: olemis Type: enhancement | Status: accepted Priority: critical | Milestone: Release 2 Component: dashboard|Version: Resolution: | Keywords: --+--- Comment (by jdreimann): Replying to [comment:16 olemis]: This is closer to completion now ... at least the frontend is almost ready . This is what iPhone checkboxes look like . Feedback is welcome . Where does the requirement for iPhone checkboxes come from? I don't remember this being discussed anywhere. If you want to implement them, please propose that in a separate ticket. In this ticket, please focus on enabling inline edits. For now I'd appreciate if you would remove them from proposed patches because they are inconsistent with the current design and were never designed for mouse-operation. Not even Apple uses them in their desktop software, apart from a handful exceptions. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:17 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+--- Reporter: jdreimann| Owner: olemis Type: enhancement | Status: accepted Priority: critical | Milestone: Release 2 Component: dashboard|Version: Resolution: | Keywords: --+--- Comment (by olemis): Replying to [comment:17 jdreimann]: Replying to [comment:16 olemis]: This is closer to completion now ... at least the frontend is almost ready . This is what iPhone checkboxes look like . Feedback is welcome . Where does the requirement for iPhone checkboxes come from? I don't remember this being discussed anywhere. just a suggestion ... If you want to implement them, please propose that in a separate ticket. In this ticket, please focus on enabling inline edits. ... so if this is not correct I revert those changes and use plain-old checkboxes . No big deal . Now I ask , what inplace radio ticket fields editor will look like ? For now I'd appreciate if you would remove them from proposed patches because they are inconsistent with the current design and were never designed for mouse-operation. ok -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:18 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+--- Reporter: jdreimann| Owner: olemis Type: enhancement | Status: accepted Priority: critical | Milestone: Release 2 Component: dashboard|Version: Resolution: | Keywords: --+--- Comment (by olemis): After a lot of fighting against external js libs , I think I won the first battle and managed to implement in place editor for ticket checkbox fields . I have refreshed patches accordingly and updated application order mentioned before in comment:14 . Only frontend has been improved so it's still work in progress at the moment , as the backend still needs to be developed . New features described below . Dashboard plugin - [http://github.com/tdreyno/iphone-style-checkboxes iPhone style checkboxes js library] added . ''MIT license'' - Modifications for ''jEditable'' . - Architecture of Bloodhound editable data API modified to support references to functions in `data-edit*` attributes (by using `javascript:` prefix) . - iPhone checkbox jEditable type ... some minor enhancements still needed . Theme plugin - Enhanced code to load values for select and checkbox fields - Changes for iPhone checkbox editable type propagated to render these controls in ticket view . This is closer to completion now ... at least the frontend is almost ready . This is what iPhone checkboxes look like . Feedback is welcome . [[Image(bh_theme_x_70_ticket_inplace_iphone_cb.png, width=600)]] Only editors for radio ticket type are missing ... coming soon . -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:16 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+--- Reporter: jdreimann| Owner: olemis Type: enhancement | Status: accepted Priority: critical | Milestone: Release 2 Component: dashboard|Version: Resolution: | Keywords: --+--- Comment (by olemis): Replying to [comment:11 jdreimann]: Replying to [comment:10 olemis]: The following screenshot illustrates what it looks like . Feedback is welcome . I assume the button with the check mark is to confirm the selection and 'commit' it? yes This should not be required. ok. I'll remove that for select fields . Part of the case for inline editing is that confirmation is only required when 1. It's difficult (time, effort) or impossible to revert fully. 1. Automatically saved information would be incomplete. An example for 1. is when a ticket is when stuff gets deleted. An example for 2. is changing a ticket description, which you probably wouldn't want to change for everyone before you're done typing. IMO submit button does need to be required for all kinds of text fields (i.e. raw wiki textarea, raw and wiki text field ) . Consider the case when user starts typing but suddenly decides it's all wrong . Hence there should be a way to revert in place edits (e.g. Submit + Cancel button ?) I think we'll get closer to a proper definition by trial and error, but I think our default approach should be to not ask for confirmation unless in cases of grave danger. ... and when there's a need to cancel / undo in place modifications , like is the case for text fields . -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:12 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+--- Reporter: jdreimann| Owner: olemis Type: enhancement | Status: accepted Priority: critical | Milestone: Release 2 Component: dashboard|Version: Resolution: | Keywords: --+--- Comment (by jdreimann): Replying to [comment:12 olemis]: IMO submit button does need to be required for all kinds of text fields and [..] there's a need to cancel / undo in place modifications , like is the case for text fields . Yep, that's what I was trying to say :) +1 -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:13 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+--- Reporter: jdreimann| Owner: olemis Type: enhancement | Status: accepted Priority: critical | Milestone: Release 2 Component: dashboard|Version: Resolution: | Keywords: --+--- Changes (by olemis): * status: new = accepted * owner: nobody = olemis -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:9 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+--- Reporter: jdreimann| Owner: nobody Type: enhancement | Status: new Priority: critical | Milestone: Release 2 Component: dashboard|Version: Resolution: | Keywords: --+--- Changes (by jdreimann): * priority: major = critical -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:7 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+--- Reporter: jdreimann| Owner: nobody Type: enhancement | Status: new Priority: critical | Milestone: Release 2 Component: dashboard|Version: Resolution: | Keywords: --+--- Comment (by gjm): Replying to [comment:4 olemis]: The way I see it we have three options : 1. Use ''jEditable'' except auto-grow plugin. - We'd have to decide whether this is a crucial feature OK, go with option 1. We can at least see if the autogrow functionality is missed -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:8 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+--- Reporter: jdreimann| Owner: nobody Type: enhancement | Status: new Priority: major| Milestone: Release 2 Component: dashboard|Version: Resolution: | Keywords: --+--- Comment (by jdreimann): Replying to [comment:4 olemis]: [...] If ''Modify'' / ''Change'' will disappear then what is supposed to happen when ''Javascript'' is disabled ? How about they stay until Javascript removes them? Or what would you suggest? -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:5 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+--- Reporter: jdreimann| Owner: nobody Type: enhancement | Status: new Priority: major| Milestone: Release 2 Component: dashboard|Version: Resolution: | Keywords: --+--- Comment (by olemis): Replying to [comment:5 jdreimann]: Replying to [comment:4 olemis]: [...] If ''Modify'' / ''Change'' will disappear then what is supposed to happen when ''Javascript'' is disabled ? How about they stay until Javascript removes them? That's ok afaics. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:6 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+--- Reporter: jdreimann| Owner: nobody Type: enhancement | Status: new Priority: major| Milestone: Release 2 Component: dashboard|Version: Resolution: | Keywords: --+--- Comment (by jdreimann): Am I right in thinking that the licensing question regarding jEditable [http://mail-archives.apache.org/mod_mbox/incubator-bloodhound- dev/201203.mbox/%3C4F61C392.7060403%40wandisco.com%3E raised by Gary previously] hasn't been resolved yet? -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:3 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+--- Reporter: jdreimann| Owner: nobody Type: enhancement | Status: new Priority: major| Milestone: Release 2 Component: dashboard|Version: Resolution: | Keywords: --+--- Comment (by olemis): The way I see it we have three options : 1. Use ''jEditable'' except auto-grow plugin. - We'd have to decide whether this is a crucial feature 2. Use ''jEditable'' and implement a replacement for auto-grow functionality - We'd have to assess whether this is a feasible task 3. Do not use ''jEditable'' at all, and choose a similar library - So far I have not found something as complete as ''jEditable'' , especially supporting integrate of the editor with server-side WikiFormatting renderer . - I'm not an expert and I have not exhausted all the possibilities Beyond that , there is something else we need to discuss . If ''Modify'' / ''Change'' will disappear then what is supposed to happen when ''Javascript'' is disabled ? -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:4 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects
#146: Inline editing of objects --+--- Reporter: jdreimann| Owner: nobody Type: enhancement | Status: new Priority: major| Milestone: Release 2 Component: dashboard|Version: Resolution: | Keywords: --+--- Comment (by olemis): So what shall we do about this ticket ? Is it ok to use ''jEditable'' for this ? If the decision is to move forward with another library then which one ? -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:2 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #146: Inline editing of objects (was: In-place editing of objects)
#146: Inline editing of objects --+--- Reporter: jdreimann| Owner: nobody Type: enhancement | Status: new Priority: major| Milestone: Release 2 Component: dashboard|Version: Resolution: | Keywords: --+--- -- Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:1 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound (incubating) issue tracker
