[jira] [Commented] (BOOKKEEPER-554) fd leaking when move ledger index file
[
https://issues.apache.org/jira/browse/BOOKKEEPER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558200#comment-13558200
]
Hadoop QA commented on BOOKKEEPER-554:
--
Testing JIRA BOOKKEEPER-554
Patch
[BOOKKEEPER-554.diff|https://issues.apache.org/jira/secure/attachment/12565671/BOOKKEEPER-554.diff]
downloaded at Sun Jan 20 07:41:38 UTC 2013
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
.Tests run: 790
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/251/
> fd leaking when move ledger index file
> --
>
> Key: BOOKKEEPER-554
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-554
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
>Reporter: Sijie Guo
>Assignee: Sijie Guo
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-554.diff
>
>
> a file info is get when moving ledger index, but it doesn't release after
> use. so the reference counting for file info stays more than zero, the file
> channel would never be closed even the file is evicted from ledger cache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-554) fd leaking when move ledger index file
[ https://issues.apache.org/jira/browse/BOOKKEEPER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558317#comment-13558317 ] Uma Maheswara Rao G commented on BOOKKEEPER-554: Good catch Sijie!, thanks a lot for noticing it. +1 > fd leaking when move ledger index file > -- > > Key: BOOKKEEPER-554 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-554 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 4.3.0 > > Attachments: BOOKKEEPER-554.diff > > > a file info is get when moving ledger index, but it doesn't release after > use. so the reference counting for file info stays more than zero, the file > channel would never be closed even the file is evicted from ledger cache. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-554) fd leaking when move ledger index file
[ https://issues.apache.org/jira/browse/BOOKKEEPER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574258#comment-13574258 ] Sijie Guo commented on BOOKKEEPER-554: -- > getFileInfo never returns null, getFileInfo would throw exception. so we had to check null in finally block. > fd leaking when move ledger index file > -- > > Key: BOOKKEEPER-554 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-554 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 4.3.0 > > Attachments: BOOKKEEPER-554.diff > > > a file info is get when moving ledger index, but it doesn't release after > use. so the reference counting for file info stays more than zero, the file > channel would never be closed even the file is evicted from ledger cache. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-554) fd leaking when move ledger index file
[
https://issues.apache.org/jira/browse/BOOKKEEPER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575806#comment-13575806
]
Hadoop QA commented on BOOKKEEPER-554:
--
Testing JIRA BOOKKEEPER-554
Patch
[0001-BOOKKEEPER-554.patch|https://issues.apache.org/jira/secure/attachment/12568821/0001-BOOKKEEPER-554.patch]
downloaded at Mon Feb 11 13:55:54 UTC 2013
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
.Tests run: 816
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/265/
> fd leaking when move ledger index file
> --
>
> Key: BOOKKEEPER-554
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-554
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
>Affects Versions: 4.2.0
>Reporter: Sijie Guo
>Assignee: Sijie Guo
> Fix For: 4.3.0
>
> Attachments: 0001-BOOKKEEPER-554.patch, BOOKKEEPER-554.diff
>
>
> a file info is get when moving ledger index, but it doesn't release after
> use. so the reference counting for file info stays more than zero, the file
> channel would never be closed even the file is evicted from ledger cache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-554) fd leaking when move ledger index file
[ https://issues.apache.org/jira/browse/BOOKKEEPER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576376#comment-13576376 ] Sijie Guo commented on BOOKKEEPER-554: -- +1 for the new patch. thanks Ivan. will commit it. > fd leaking when move ledger index file > -- > > Key: BOOKKEEPER-554 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-554 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 4.3.0 > > Attachments: 0001-BOOKKEEPER-554.patch, BOOKKEEPER-554.diff > > > a file info is get when moving ledger index, but it doesn't release after > use. so the reference counting for file info stays more than zero, the file > channel would never be closed even the file is evicted from ledger cache. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-554) fd leaking when move ledger index file
[ https://issues.apache.org/jira/browse/BOOKKEEPER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576397#comment-13576397 ] Hudson commented on BOOKKEEPER-554: --- Integrated in bookkeeper-trunk #98 (See [https://builds.apache.org/job/bookkeeper-trunk/98/]) BOOKKEEPER-554: fd leaking when move ledger index file (sijie, ivank via sijie) (Revision 1445033) Result = SUCCESS sijie : Files : * /zookeeper/bookkeeper/trunk/CHANGES.txt * /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java * /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java * /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java > fd leaking when move ledger index file > -- > > Key: BOOKKEEPER-554 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-554 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 4.3.0 > > Attachments: 0001-BOOKKEEPER-554.patch, BOOKKEEPER-554.diff > > > a file info is get when moving ledger index, but it doesn't release after > use. so the reference counting for file info stays more than zero, the file > channel would never be closed even the file is evicted from ledger cache. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-554) fd leaking when move ledger index file
[ https://issues.apache.org/jira/browse/BOOKKEEPER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577760#comment-13577760 ] Ivan Kelly commented on BOOKKEEPER-554: --- Committed to 4.2 branch as 1445763 > fd leaking when move ledger index file > -- > > Key: BOOKKEEPER-554 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-554 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 4.3.0, 4.2.1 > > Attachments: 0001-BOOKKEEPER-554.patch, BOOKKEEPER-554.diff > > > a file info is get when moving ledger index, but it doesn't release after > use. so the reference counting for file info stays more than zero, the file > channel would never be closed even the file is evicted from ledger cache. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
