[jira] [Commented] (BOOKKEEPER-555) Make BookieServer use Netty rather than a custom IO server
[
https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565647#comment-13565647
]
Hadoop QA commented on BOOKKEEPER-555:
--
Testing JIRA BOOKKEEPER-555
Patch
[0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch|https://issues.apache.org/jira/secure/attachment/12567022/0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch]
downloaded at Tue Jan 29 18:50:40 UTC 2013
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:red}-1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:red}-1{color} patch does not compile
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1 FINDBUGS{color}
.{color:red}-1{color} the patch seems to introduce 2 new Findbugs
warning(s) in module(s) [bookkeeper-server]
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:red}-1 DISTRO{color}
.{color:red}-1{color} distro tarball fails with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/257/
> Make BookieServer use Netty rather than a custom IO server
> --
>
> Key: BOOKKEEPER-555
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555
> Project: Bookkeeper
> Issue Type: Bug
>Reporter: Ivan Kelly
>Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments: 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch
>
>
> Move from the custom NIO server to netty. This will make it easier to do
> things like add more server side threads and support SSL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-555) Make BookieServer use Netty rather than a custom IO server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567540#comment-13567540 ] Ivan Kelly commented on BOOKKEEPER-555: --- I've benchmarked a single bookie with and without the netty server, using bookkeeper-benchmark/bin/benchmark bookie. I ran each 5 times. || || Throughput || Stddev || Latency || Stddev || | netty| 22988.4 | 1656.9 | 1.5 | 0.1 | | no netty | 20785.6 | 1220.4 | 1.5 | 0.1 | So netty even gives a slight improvement. Therefore, I think this change it ready to go. The precommit failure is due to the fact that BOOKKEEPER-556 is required. I'll kick it off again once BOOKKEEPER-556 is in. > Make BookieServer use Netty rather than a custom IO server > -- > > Key: BOOKKEEPER-555 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555 > Project: Bookkeeper > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 4.3.0 > > Attachments: 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch > > > Move from the custom NIO server to netty. This will make it easier to do > things like add more server side threads and support SSL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-555) Make BookieServer use Netty rather than a custom IO server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568255#comment-13568255 ] Flavio Junqueira commented on BOOKKEEPER-555: - +1, it looks great, Ivan. It also only worked after applying BOOKKEEPER-556, it would be good to commit them both together. If no one else expresses a concern with this patch, I'll commit it along with BOOKKEEPER-556. > Make BookieServer use Netty rather than a custom IO server > -- > > Key: BOOKKEEPER-555 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555 > Project: Bookkeeper > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 4.3.0 > > Attachments: 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch > > > Move from the custom NIO server to netty. This will make it easier to do > things like add more server side threads and support SSL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-555) Make BookieServer use Netty rather than a custom IO server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568319#comment-13568319 ] Sijie Guo commented on BOOKKEEPER-555: -- I haven't go through the details on this patch. but just one comment about ChannelGroup. There is a known race condition when shutdown a channel group and adding a opened channel into channel group. if a channel added after closed, ChannelGroup doesn't take the responsibility of closing it. Then netty would hang. This issue would exist in Hedwig server too, but it is fine for Hedwig server, since there is no shutdown hook. But it might be bad for bookie server, since there is a shutdown hook. A bookie might hang on shutting down. It would better to extend DefaultChannelGroup to provide a cleanup feature, like CleanupChannelMap in hedwig client. similar solution in async-http-client: http://asynchttpclient.github.com/async-http-client/apidocs/com/ning/http/util/CleanupChannelGroup.html > Make BookieServer use Netty rather than a custom IO server > -- > > Key: BOOKKEEPER-555 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555 > Project: Bookkeeper > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 4.3.0 > > Attachments: 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch > > > Move from the custom NIO server to netty. This will make it easier to do > things like add more server side threads and support SSL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-555) Make BookieServer use Netty rather than a custom IO server
[
https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571570#comment-13571570
]
Hadoop QA commented on BOOKKEEPER-555:
--
Testing JIRA BOOKKEEPER-555
Patch
[0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch|https://issues.apache.org/jira/secure/attachment/12568048/0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch]
downloaded at Tue Feb 5 18:41:32 UTC 2013
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:red}-1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:red}-1{color} patch does not compile
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1 FINDBUGS{color}
.{color:red}-1{color} the patch seems to introduce 3 new Findbugs
warning(s) in module(s) [bookkeeper-server]
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:red}-1 DISTRO{color}
.{color:red}-1{color} distro tarball fails with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/260/
> Make BookieServer use Netty rather than a custom IO server
> --
>
> Key: BOOKKEEPER-555
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555
> Project: Bookkeeper
> Issue Type: Bug
>Reporter: Ivan Kelly
>Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments: 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch
>
>
> Move from the custom NIO server to netty. This will make it easier to do
> things like add more server side threads and support SSL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-555) Make BookieServer use Netty rather than a custom IO server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13572304#comment-13572304 ] Ivan Kelly commented on BOOKKEEPER-555: --- Build failed because BOOKKEEPER-556 is not in > Make BookieServer use Netty rather than a custom IO server > -- > > Key: BOOKKEEPER-555 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555 > Project: Bookkeeper > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 4.3.0 > > Attachments: 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch > > > Move from the custom NIO server to netty. This will make it easier to do > things like add more server side threads and support SSL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-555) Make BookieServer use Netty rather than a custom IO server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575113#comment-13575113 ] Sijie Guo commented on BOOKKEEPER-555: -- lgtm +1. will retrigger the commit job. after that, will commit it. > Make BookieServer use Netty rather than a custom IO server > -- > > Key: BOOKKEEPER-555 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555 > Project: Bookkeeper > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 4.3.0 > > Attachments: 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch > > > Move from the custom NIO server to netty. This will make it easier to do > things like add more server side threads and support SSL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-555) Make BookieServer use Netty rather than a custom IO server
[
https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575295#comment-13575295
]
Hadoop QA commented on BOOKKEEPER-555:
--
Testing JIRA BOOKKEEPER-555
Patch
[BOOKKEEPER-555.patch|https://issues.apache.org/jira/secure/attachment/12568716/BOOKKEEPER-555.patch]
downloaded at Sat Feb 9 22:21:10 UTC 2013
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1 FINDBUGS{color}
.{color:red}-1{color} the patch seems to introduce 1 new Findbugs
warning(s) in module(s) [bookkeeper-server]
{color:green}+1 TESTS{color}
.Tests run: 815
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/263/
> Make BookieServer use Netty rather than a custom IO server
> --
>
> Key: BOOKKEEPER-555
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555
> Project: Bookkeeper
> Issue Type: Bug
>Reporter: Ivan Kelly
>Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments: 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, BOOKKEEPER-555.patch
>
>
> Move from the custom NIO server to netty. This will make it easier to do
> things like add more server side threads and support SSL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-555) Make BookieServer use Netty rather than a custom IO server
[
https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575352#comment-13575352
]
Rakesh R commented on BOOKKEEPER-555:
-
{quote}-1 the patch seems to introduce 1 new Findbugs warning(s) in module(s)
[bookkeeper-server]
{quote}
I think equals overriding will not cause any issues, its giving warning as
CleanupChannelGroup has new field 'closed' defined.
Hi Ivan/Sijie, Sorry to pitch in late as I got free time today only.
By the way netty impl looks very nice. Just have few suggestions, could you
please go through. As there is no functional problems, feel free riasing
another jira to fix valid comments and go ahead with committing the current
patch.
- @ChannelPipelineCoverage annotation has been deprecated
and use the alternative @Sharable annotation
- Creates a new group with the specified name in CleanupChannelGroup like,
rather than using the generated name.
DefaultChannelGroup(){
super("bookieServerCnxns");
}
- I feel BookieRequestHandler can override channelDisconnected,
channelConnected and do logging, will make debug much easier in fluctuating
env.
- Haven't seen the following var is used anywhere in BookieRequestHandler,
please remove.
private final ServerConfiguration conf;
- 'boolean success = false;' in BookieRequestHandler is not required and please
remove it, as read logic is using 'errorCode == BookieProtocol.EOK' to
differentiate success/failure.
- please organize imports for the classes:
BookieNettyServer, BookieServer, BookieServerBean
> Make BookieServer use Netty rather than a custom IO server
> --
>
> Key: BOOKKEEPER-555
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555
> Project: Bookkeeper
> Issue Type: Bug
>Reporter: Ivan Kelly
>Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments: 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, BOOKKEEPER-555.patch
>
>
> Move from the custom NIO server to netty. This will make it easier to do
> things like add more server side threads and support SSL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-555) Make BookieServer use Netty rather than a custom IO server
[
https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575765#comment-13575765
]
Hadoop QA commented on BOOKKEEPER-555:
--
Testing JIRA BOOKKEEPER-555
Patch
[0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch|https://issues.apache.org/jira/secure/attachment/12568814/0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch]
downloaded at Mon Feb 11 12:11:12 UTC 2013
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
.Tests run: 815
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/264/
> Make BookieServer use Netty rather than a custom IO server
> --
>
> Key: BOOKKEEPER-555
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555
> Project: Bookkeeper
> Issue Type: Bug
>Reporter: Ivan Kelly
>Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments: 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, BOOKKEEPER-555.patch
>
>
> Move from the custom NIO server to netty. This will make it easier to do
> things like add more server side threads and support SSL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-555) Make BookieServer use Netty rather than a custom IO server
[
https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575781#comment-13575781
]
Rakesh R commented on BOOKKEEPER-555:
-
Thanks [~iv...@yahoo-inc.com] for the patch.
{quote}What do you mean by organise? Alphabetize?{quote}
Unused imports exists in these classes(BookieNettyServer, BookieServer,
BookieServerBean), just wants to clear it:)
> Make BookieServer use Netty rather than a custom IO server
> --
>
> Key: BOOKKEEPER-555
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555
> Project: Bookkeeper
> Issue Type: Bug
>Reporter: Ivan Kelly
>Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments: 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, BOOKKEEPER-555.patch
>
>
> Move from the custom NIO server to netty. This will make it easier to do
> things like add more server side threads and support SSL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-555) Make BookieServer use Netty rather than a custom IO server
[
https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575832#comment-13575832
]
Hadoop QA commented on BOOKKEEPER-555:
--
Testing JIRA BOOKKEEPER-555
Patch
[0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch|https://issues.apache.org/jira/secure/attachment/12568824/0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch]
downloaded at Mon Feb 11 14:51:12 UTC 2013
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
.Tests run: 815
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/266/
> Make BookieServer use Netty rather than a custom IO server
> --
>
> Key: BOOKKEEPER-555
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555
> Project: Bookkeeper
> Issue Type: Bug
>Reporter: Ivan Kelly
>Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments: 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, BOOKKEEPER-555.patch
>
>
> Move from the custom NIO server to netty. This will make it easier to do
> things like add more server side threads and support SSL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-555) Make BookieServer use Netty rather than a custom IO server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576362#comment-13576362 ] Rakesh R commented on BOOKKEEPER-555: - Thanks [~ikelly], latest patch looks nice. Apart from the following point, the patch is ready to go in +1. Just one clarification, latest patch BookieRequestHandler is not having @Sharable annotation. In my previous comment I mentioned to replace the @ChannelPipelineCoverage(which is deprecated) with @Sharable. Am I missing anything? > Make BookieServer use Netty rather than a custom IO server > -- > > Key: BOOKKEEPER-555 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555 > Project: Bookkeeper > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 4.3.0 > > Attachments: 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, BOOKKEEPER-555.patch > > > Move from the custom NIO server to netty. This will make it easier to do > things like add more server side threads and support SSL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-555) Make BookieServer use Netty rather than a custom IO server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576494#comment-13576494 ] Ivan Kelly commented on BOOKKEEPER-555: --- [~rakeshreddy] Re: @Sharable, you should put @Sharable on a ChannelHandler if more than one pipeline is going to use that ChannelHandler. Current we create a new handler per pipeline, and this doesn't seem to cause any performance issues. We could however share the ChannelHandler (and the decoder/encoder) as none of these actually old any state. However, I'd like to do that in a future JIRA and push this one in now, as there are a couple of things waiting on this. Therefore, since I have a +1, I'm going to push in. > Make BookieServer use Netty rather than a custom IO server > -- > > Key: BOOKKEEPER-555 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555 > Project: Bookkeeper > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 4.3.0 > > Attachments: 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, BOOKKEEPER-555.patch > > > Move from the custom NIO server to netty. This will make it easier to do > things like add more server side threads and support SSL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-555) Make BookieServer use Netty rather than a custom IO server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576543#comment-13576543 ] Hudson commented on BOOKKEEPER-555: --- Integrated in bookkeeper-trunk #99 (See [https://builds.apache.org/job/bookkeeper-trunk/99/]) BOOKKEEPER-555: Make BookieServer use Netty rather than a custom IO server (ivank) (Revision 1445085) Result = SUCCESS ivank : Files : * /zookeeper/bookkeeper/trunk/CHANGES.txt * /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java * /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtoEncoding.java * /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtocol.java * /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestHandler.java * /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java * /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServerBean.java * /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java * /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ResponseBuilder.java * /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieInitializationTest.java * /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieZKExpireTest.java * /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/NIOServerFactoryTest.java > Make BookieServer use Netty rather than a custom IO server > -- > > Key: BOOKKEEPER-555 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555 > Project: Bookkeeper > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 4.3.0 > > Attachments: 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, > 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, BOOKKEEPER-555.patch > > > Move from the custom NIO server to netty. This will make it easier to do > things like add more server side threads and support SSL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
