[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924120#comment-13924120 ] Ivan Kelly commented on BOOKKEEPER-708: --- Committed r1575343 to branch-4.2 Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708-Shade-libraries-to-avoid-incompatible.patch, 0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch, 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708-trunk-shade-protobuf-guava-with-minjar.patch, 0002-BOOKKEEPER-708.patch, 0003-BOOKKEEPER-708-trunk-shade-protobuf-guava-with-minjar.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13893337#comment-13893337 ] Rakesh R commented on BOOKKEEPER-708: - Adding a note: This is not merged to 4.2.3 branch but in fix version its mentioned as 4.2.3. Since we raised a separate blocker BOOKKEEPER-730 to discuss the licensing issue, I feel we can merge this to 4.2.3 branch as well. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708-Shade-libraries-to-avoid-incompatible.patch, 0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch, 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708-trunk-shade-protobuf-guava-with-minjar.patch, 0002-BOOKKEEPER-708.patch, 0003-BOOKKEEPER-708-trunk-shade-protobuf-guava-with-minjar.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13893646#comment-13893646 ] Rakesh R commented on BOOKKEEPER-708: - ok fine, I just added a note as a reminder. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708-Shade-libraries-to-avoid-incompatible.patch, 0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch, 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708-trunk-shade-protobuf-guava-with-minjar.patch, 0002-BOOKKEEPER-708.patch, 0003-BOOKKEEPER-708-trunk-shade-protobuf-guava-with-minjar.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1342#comment-1342 ] Hudson commented on BOOKKEEPER-708: --- SUCCESS: Integrated in bookkeeper-trunk #533 (See [https://builds.apache.org/job/bookkeeper-trunk/533/]) BOOKKEEPER-708: Shade protobuf library to avoid incompatible versions (rakesh, ivank via sijie) (sijie: rev 1563566) * /zookeeper/bookkeeper/trunk/CHANGES.txt * /zookeeper/bookkeeper/trunk/bookkeeper-server/pom.xml * /zookeeper/bookkeeper/trunk/bookkeeper-stats-providers/codahale-metrics-provider/pom.xml * /zookeeper/bookkeeper/trunk/hedwig-client/pom.xml * /zookeeper/bookkeeper/trunk/hedwig-protocol/pom.xml * /zookeeper/bookkeeper/trunk/pom.xml Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708-Shade-libraries-to-avoid-incompatible.patch, 0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch, 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708-trunk-shade-protobuf-guava-with-minjar.patch, 0002-BOOKKEEPER-708.patch, 0003-BOOKKEEPER-708-trunk-shade-protobuf-guava-with-minjar.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[
https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13884028#comment-13884028
]
Hadoop QA commented on BOOKKEEPER-708:
--
Testing JIRA BOOKKEEPER-708
Patch
[0003-BOOKKEEPER-708-trunk-shade-protobuf-guava-with-minjar.patch|https://issues.apache.org/jira/secure/attachment/12625528/0003-BOOKKEEPER-708-trunk-shade-protobuf-guava-with-minjar.patch]
downloaded at Tue Jan 28 10:46:40 UTC 2014
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
.Tests run: 893
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/568/
Shade protobuf library to avoid incompatible versions
-
Key: BOOKKEEPER-708
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708
Project: Bookkeeper
Issue Type: Bug
Components: bookkeeper-server
Reporter: Sijie Guo
Assignee: Rakesh R
Fix For: 4.3.0, 4.2.3
Attachments:
0001-BOOKKEEPER-708-Shade-libraries-to-avoid-incompatible.patch,
0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch,
0001-BOOKKEEPER-708.patch,
0002-BOOKKEEPER-708-trunk-shade-protobuf-guava-with-minjar.patch,
0002-BOOKKEEPER-708.patch,
0003-BOOKKEEPER-708-trunk-shade-protobuf-guava-with-minjar.patch
as offline discussion, we need to shade protobuf library for BKJM as hadoop
uses protobuf 2.5.
this is planned on version 4.2.3 and 4.3.0.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13883220#comment-13883220 ] Sijie Guo commented on BOOKKEEPER-708: -- wrong indent in the pom file. and I don't think you are putting the guava dependency for hedwig in right place, since 'hedwig-protocol' doesn't depend on guava. it should be 'hedwig-client'. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708-Shade-libraries-to-avoid-incompatible.patch, 0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch, 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708-trunk-shade-protobuf-guava-with-minjar.patch, 0002-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13880994#comment-13880994 ] Ivan Kelly commented on BOOKKEEPER-708: --- minimizeJar is the option to make the jar smaller by only pulling in whats used. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708-Shade-libraries-to-avoid-incompatible.patch, 0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch, 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881264#comment-13881264 ] Sijie Guo commented on BOOKKEEPER-708: -- -1 for shading netty, since ClientSocketChannelFactory is used as constructor for BookKeeper. If we shade netty, we can't share same ClientSocketChannelFactory with bookkeeper client. as I said before, don't shade libraries that used in public method. and if you want to shade netty, please clarify what's the issue before shading. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708-Shade-libraries-to-avoid-incompatible.patch, 0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch, 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[
https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881278#comment-13881278
]
Sijie Guo commented on BOOKKEEPER-708:
--
BTW, wrong indent on bookkeeper-server/pom.xml
{code}
+artifactSet
+ includes
+includecom.google.protobuf:protobuf-java/include
+ includecom.google.guava:guava/include
+ includeorg.jboss.netty:netty/include
+ /includes
+/artifactSet
{code}
Shade protobuf library to avoid incompatible versions
-
Key: BOOKKEEPER-708
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708
Project: Bookkeeper
Issue Type: Bug
Components: bookkeeper-server
Reporter: Sijie Guo
Assignee: Rakesh R
Fix For: 4.3.0, 4.2.3
Attachments:
0001-BOOKKEEPER-708-Shade-libraries-to-avoid-incompatible.patch,
0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch,
0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch
as offline discussion, we need to shade protobuf library for BKJM as hadoop
uses protobuf 2.5.
this is planned on version 4.2.3 and 4.3.0.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[
https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881697#comment-13881697
]
Hadoop QA commented on BOOKKEEPER-708:
--
Testing JIRA BOOKKEEPER-708
Patch
[0001-BOOKKEEPER-708-Shade-libraries-to-avoid-incompatible.patch|https://issues.apache.org/jira/secure/attachment/12625050/0001-BOOKKEEPER-708-Shade-libraries-to-avoid-incompatible.patch]
downloaded at Sat Jan 25 05:42:16 UTC 2014
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:red}-1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:red}-1{color} patch does not compile
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:red}-1 DISTRO{color}
.{color:red}-1{color} distro tarball fails with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/565/
Shade protobuf library to avoid incompatible versions
-
Key: BOOKKEEPER-708
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708
Project: Bookkeeper
Issue Type: Bug
Components: bookkeeper-server
Reporter: Sijie Guo
Assignee: Rakesh R
Fix For: 4.3.0, 4.2.3
Attachments:
0001-BOOKKEEPER-708-Shade-libraries-to-avoid-incompatible.patch,
0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch,
0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch
as offline discussion, we need to shade protobuf library for BKJM as hadoop
uses protobuf 2.5.
this is planned on version 4.2.3 and 4.3.0.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[
https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13880024#comment-13880024
]
Flavio Junqueira commented on BOOKKEEPER-708:
-
Just so that I understand, we are introducing the ability of producing a
reduced jar vs. an uber jar for bookkeeper-server. How do we actually control
it? Is it by changing the pom.xml:
{noformat}
createDependencyReducedPomtrue/createDependencyReducedPom
{noformat}
I actually tried it and it didn't seem to make much difference.
Shade protobuf library to avoid incompatible versions
-
Key: BOOKKEEPER-708
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708
Project: Bookkeeper
Issue Type: Bug
Components: bookkeeper-server
Reporter: Sijie Guo
Assignee: Rakesh R
Fix For: 4.3.0, 4.2.3
Attachments:
0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch,
0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch
as offline discussion, we need to shade protobuf library for BKJM as hadoop
uses protobuf 2.5.
this is planned on version 4.2.3 and 4.3.0.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877141#comment-13877141 ] Sijie Guo commented on BOOKKEEPER-708: -- +1 from the latest patch. If I got +1 from [~fpj], will push it later. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch, 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876225#comment-13876225 ] Rakesh R commented on BOOKKEEPER-708: - Thanks Ivan for the clarification. If everyone agrees, can we push this in? Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch, 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874936#comment-13874936 ] Ivan Kelly commented on BOOKKEEPER-708: --- I don't see any need to upgrade. Upgrading would involve installing 2.5.0 on my machine, and it's a pain to have multiple installs of protoc. Re: protobuf wireformat BC, once we shade we shouldn't even have to worry until we upgrade protobuf version. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch, 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873576#comment-13873576 ] Sijie Guo commented on BOOKKEEPER-708: -- [~fpj] I think protobuf handles format compatibility between versions. so it might be OK. but that's a valid point, we should double-check on this, to see if it works correctly when a client use protobuf 2.4 reading metadata written by higher protobuf. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch, 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873612#comment-13873612 ] Rakesh R commented on BOOKKEEPER-708: - Hi Flavio/Sijie, I couldn't see any version mismatch with respect to this patch/fix, we are still continuing with 2.4.1 version. Anything am missing? Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch, 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872082#comment-13872082 ] Ivan Kelly commented on BOOKKEEPER-708: --- I've set createDependencyReducedPom to true in a new patch. Regarding the jar in the dist bin package, I don't think it's easy to exclude it without hacking around it, any having it there does no harm. Shading the deps is only important for the client. The dist bin package is the server. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch, 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[
https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872123#comment-13872123
]
Hadoop QA commented on BOOKKEEPER-708:
--
Testing JIRA BOOKKEEPER-708
Patch
[0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch|https://issues.apache.org/jira/secure/attachment/12623139/0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch]
downloaded at Wed Jan 15 14:00:48 UTC 2014
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
.Tests run: 885
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/556/
Shade protobuf library to avoid incompatible versions
-
Key: BOOKKEEPER-708
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708
Project: Bookkeeper
Issue Type: Bug
Components: bookkeeper-server
Reporter: Sijie Guo
Assignee: Rakesh R
Fix For: 4.3.0, 4.2.3
Attachments:
0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch,
0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch
as offline discussion, we need to shade protobuf library for BKJM as hadoop
uses protobuf 2.5.
this is planned on version 4.2.3 and 4.3.0.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860026#comment-13860026 ] Sijie Guo commented on BOOKKEEPER-708: -- I think we need to set 'createDependencyReducedPom' to true. Otherwise, it would still pull the protobuf version in, as the pom file will not be changed. BTW, Vinay's suggestion is good. we might need to keep shade plugins use same version. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860027#comment-13860027 ] Vinay commented on BOOKKEEPER-708: -- One more thing is, once we shade the protobuf jar, then we can exclude the same jar in binary distribution package. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860035#comment-13860035 ] Sijie Guo commented on BOOKKEEPER-708: -- it doesn't really matter whether the jar is in the distributed package or not, as it is already a binary package. but it matters in pom file as it is the source of dependencies. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848847#comment-13848847 ] Vinay commented on BOOKKEEPER-708: -- all other pom.xml, maven shade plugin used is of version 1.5. Do upgrade to 2.2 needed in all places..? Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839884#comment-13839884 ] Sijie Guo commented on BOOKKEEPER-708: -- +1 looks good. [~ikelly] let's shade guava when we really need do that. if you are ok with that, I will commit that. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13823688#comment-13823688 ] Ivan Kelly commented on BOOKKEEPER-708: --- As HDFS-5518 points out, simply mandating that people use a newer guava is not without risks. I still think we should shade guava, but do so with the reduced jar option to avoid polluting the namespace as [~hustlmsp] says. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822453#comment-13822453 ] Rakesh R commented on BOOKKEEPER-708: - Thanks a lot [~ste...@apache.org] for the interest. Also, nice to hear the upgradation of guava version. Guava's latest release is 15.0 version, first will try running HDFS with guava 15.0 version and will udpdate the patch in HADOOP-9991. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[
https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822489#comment-13822489
]
Hadoop QA commented on BOOKKEEPER-708:
--
Testing JIRA BOOKKEEPER-708
Patch
[0002-BOOKKEEPER-708.patch|https://issues.apache.org/jira/secure/attachment/12613827/0002-BOOKKEEPER-708.patch]
downloaded at Thu Nov 14 14:18:49 UTC 2013
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
.Tests run: 883
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/539/
Shade protobuf library to avoid incompatible versions
-
Key: BOOKKEEPER-708
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708
Project: Bookkeeper
Issue Type: Bug
Components: bookkeeper-server
Reporter: Sijie Guo
Assignee: Rakesh R
Fix For: 4.3.0, 4.2.3
Attachments: 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch
as offline discussion, we need to shade protobuf library for BKJM as hadoop
uses protobuf 2.5.
this is planned on version 4.2.3 and 4.3.0.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822497#comment-13822497 ] Rakesh R commented on BOOKKEEPER-708: - Thanks [~hustlmsp] for your comments. Attached latest patch, here I just shaded only the protobufs. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Rakesh R Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818786#comment-13818786 ] Rakesh R commented on BOOKKEEPER-708: - Hi, While regression testing, have seen HDFS is using older version of guava(11.0.2) and this also included in shade. Attached patch which shaded protobuf, guava. Also, I have considered only for the bookkeeper-server. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Ivan Kelly Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818789#comment-13818789 ] Rakesh R commented on BOOKKEEPER-708: - For safer side, I've shaded guava also. Since we are using higher guava version, it shoudn't break HDFS becuase of our feature inclusion. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Ivan Kelly Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13819161#comment-13819161 ] Sijie Guo commented on BOOKKEEPER-708: -- [~rakeshr] could you try not shade guava? if there is a BC issue, point them out. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Ivan Kelly Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13819739#comment-13819739 ] Rakesh R commented on BOOKKEEPER-708: - [~hustlmsp] I haven't observed any compatibility issues across the versions. But I'm doubting, HDFS community will upgrade the version from 11.0.2 to 13.0.1 for a pluggable module. Whats your opinion? BTW Bookkeeper requires guava 13.0.1 version as we are using new features like 'com.google.common.util.concurrent.RateLimiter' which doesn't exists in older version. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Ivan Kelly Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13819835#comment-13819835 ] Sijie Guo commented on BOOKKEEPER-708: -- when you bump bookkeeper version in BKJM, why can't you bump HDFS's guava version ? it is a more straightforward thing, as BKJM is dependent on bookkeeper, not bookkeeper dependent on BKJM. avoiding unnecessary shade will produce a clean namespace in bookkeeper, which is easy for maintenance. Shade protobuf library to avoid incompatible versions - Key: BOOKKEEPER-708 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Sijie Guo Assignee: Ivan Kelly Fix For: 4.3.0, 4.2.3 Attachments: 0001-BOOKKEEPER-708.patch as offline discussion, we need to shade protobuf library for BKJM as hadoop uses protobuf 2.5. this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1#6144)
