[jira] [Updated] (BOOKKEEPER-429) Provide separate read and write threads in the bookkeeper server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated BOOKKEEPER-429: -- Attachment: 0001-BOOKKEEPER-429-Provide-separate-read-and-write-threa.patch Rebased and added apache license to MultipleThreadReadTest. This patch looks ready to go, so +1 from me. Merge it when you've glanced over the rebase. There's no real change. It only needed a rebase because of shuffled imports, which highlights why they shouldn't be shuffled unnecessarily, no matter how ugly they are. > Provide separate read and write threads in the bookkeeper server > > > Key: BOOKKEEPER-429 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-429 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Aniruddha >Assignee: Aniruddha > Fix For: 4.3.0 > > Attachments: > 0001-BOOKKEEPER-429-Provide-separate-read-and-write-threa.patch, > 0001-BOOKKEEPER-429-Provide-separate-read-and-write-threa.patch, > BK-429.patch, BOOKKEEPER-429.diff, BOOKKEEPER-429.diff, BOOKKEEPER-429.diff > > > The current bookkeeper server is single threaded. The same thread handles > reads and writes. When reads are slow (possibly because of excessive seeks), > add entry operations suffer in terms of latencies. Providing separate read > and write threads helps in reducing add entry latencies and increasing > throughput even when we're facing slow reads. Having a single read thread > also results in low disk utilization because seeks can't be ordered > efficiently by the OS. Multiple read threads would help in improving the read > throughput. > Discussion on this can be found at > http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201209.mbox/%3ccaolhydqpzn-v10zynfwud_h0qzrxtmjgttx7a9eofohyyty...@mail.gmail.com%3e > Reviewboard : https://reviews.apache.org/r/7560/ -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (BOOKKEEPER-429) Provide separate read and write threads in the bookkeeper server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-429: - Attachment: BOOKKEEPER-429.diff attached a new patch to provide a setting for num journal callback threads. > Provide separate read and write threads in the bookkeeper server > > > Key: BOOKKEEPER-429 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-429 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Aniruddha >Assignee: Aniruddha > Fix For: 4.3.0 > > Attachments: > 0001-BOOKKEEPER-429-Provide-separate-read-and-write-threa.patch, > BK-429.patch, BOOKKEEPER-429.diff, BOOKKEEPER-429.diff, BOOKKEEPER-429.diff > > > The current bookkeeper server is single threaded. The same thread handles > reads and writes. When reads are slow (possibly because of excessive seeks), > add entry operations suffer in terms of latencies. Providing separate read > and write threads helps in reducing add entry latencies and increasing > throughput even when we're facing slow reads. Having a single read thread > also results in low disk utilization because seeks can't be ordered > efficiently by the OS. Multiple read threads would help in improving the read > throughput. > Discussion on this can be found at > http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201209.mbox/%3ccaolhydqpzn-v10zynfwud_h0qzrxtmjgttx7a9eofohyyty...@mail.gmail.com%3e > Reviewboard : https://reviews.apache.org/r/7560/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (BOOKKEEPER-429) Provide separate read and write threads in the bookkeeper server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated BOOKKEEPER-429: -- Attachment: 0001-BOOKKEEPER-429-Provide-separate-read-and-write-threa.patch rebased to trunk. It shows some test regressions. > Provide separate read and write threads in the bookkeeper server > > > Key: BOOKKEEPER-429 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-429 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Aniruddha >Assignee: Aniruddha > Fix For: 4.3.0 > > Attachments: > 0001-BOOKKEEPER-429-Provide-separate-read-and-write-threa.patch, > BK-429.patch, BOOKKEEPER-429.diff, BOOKKEEPER-429.diff > > > The current bookkeeper server is single threaded. The same thread handles > reads and writes. When reads are slow (possibly because of excessive seeks), > add entry operations suffer in terms of latencies. Providing separate read > and write threads helps in reducing add entry latencies and increasing > throughput even when we're facing slow reads. Having a single read thread > also results in low disk utilization because seeks can't be ordered > efficiently by the OS. Multiple read threads would help in improving the read > throughput. > Discussion on this can be found at > http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201209.mbox/%3ccaolhydqpzn-v10zynfwud_h0qzrxtmjgttx7a9eofohyyty...@mail.gmail.com%3e > Reviewboard : https://reviews.apache.org/r/7560/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (BOOKKEEPER-429) Provide separate read and write threads in the bookkeeper server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-429: - Attachment: BOOKKEEPER-429.diff addressed comment 3). > Provide separate read and write threads in the bookkeeper server > > > Key: BOOKKEEPER-429 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-429 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Aniruddha >Assignee: Aniruddha > Fix For: 4.3.0 > > Attachments: BK-429.patch, BOOKKEEPER-429.diff, BOOKKEEPER-429.diff > > > The current bookkeeper server is single threaded. The same thread handles > reads and writes. When reads are slow (possibly because of excessive seeks), > add entry operations suffer in terms of latencies. Providing separate read > and write threads helps in reducing add entry latencies and increasing > throughput even when we're facing slow reads. Having a single read thread > also results in low disk utilization because seeks can't be ordered > efficiently by the OS. Multiple read threads would help in improving the read > throughput. > Discussion on this can be found at > http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201209.mbox/%3ccaolhydqpzn-v10zynfwud_h0qzrxtmjgttx7a9eofohyyty...@mail.gmail.com%3e > Reviewboard : https://reviews.apache.org/r/7560/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-429) Provide separate read and write threads in the bookkeeper server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-429: - Attachment: BOOKKEEPER-429.diff rebased [~i0exception]'s patch. The new patch focuses on separating write threads from read threads. since the trunk code uses netty in bookie server, so introduce a requestprocessor interface to align with the PacketProcessor in previous patch. > Provide separate read and write threads in the bookkeeper server > > > Key: BOOKKEEPER-429 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-429 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Aniruddha >Assignee: Aniruddha > Fix For: 4.3.0 > > Attachments: BK-429.patch, BOOKKEEPER-429.diff > > > The current bookkeeper server is single threaded. The same thread handles > reads and writes. When reads are slow (possibly because of excessive seeks), > add entry operations suffer in terms of latencies. Providing separate read > and write threads helps in reducing add entry latencies and increasing > throughput even when we're facing slow reads. Having a single read thread > also results in low disk utilization because seeks can't be ordered > efficiently by the OS. Multiple read threads would help in improving the read > throughput. > Discussion on this can be found at > http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201209.mbox/%3ccaolhydqpzn-v10zynfwud_h0qzrxtmjgttx7a9eofohyyty...@mail.gmail.com%3e > Reviewboard : https://reviews.apache.org/r/7560/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-429) Provide separate read and write threads in the bookkeeper server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated BOOKKEEPER-429: -- Fix Version/s: (was: 4.2.0) 4.3.0 > Provide separate read and write threads in the bookkeeper server > > > Key: BOOKKEEPER-429 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-429 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Aniruddha >Assignee: Aniruddha > Fix For: 4.3.0 > > Attachments: BK-429.patch > > > The current bookkeeper server is single threaded. The same thread handles > reads and writes. When reads are slow (possibly because of excessive seeks), > add entry operations suffer in terms of latencies. Providing separate read > and write threads helps in reducing add entry latencies and increasing > throughput even when we're facing slow reads. Having a single read thread > also results in low disk utilization because seeks can't be ordered > efficiently by the OS. Multiple read threads would help in improving the read > throughput. > Discussion on this can be found at > http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201209.mbox/%3ccaolhydqpzn-v10zynfwud_h0qzrxtmjgttx7a9eofohyyty...@mail.gmail.com%3e > Reviewboard : https://reviews.apache.org/r/7560/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-429) Provide separate read and write threads in the bookkeeper server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated BOOKKEEPER-429: -- Fix Version/s: (was: 4.3.0) 4.2.0 > Provide separate read and write threads in the bookkeeper server > > > Key: BOOKKEEPER-429 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-429 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Aniruddha >Assignee: Aniruddha > Fix For: 4.2.0 > > Attachments: BK-429.patch > > > The current bookkeeper server is single threaded. The same thread handles > reads and writes. When reads are slow (possibly because of excessive seeks), > add entry operations suffer in terms of latencies. Providing separate read > and write threads helps in reducing add entry latencies and increasing > throughput even when we're facing slow reads. Having a single read thread > also results in low disk utilization because seeks can't be ordered > efficiently by the OS. Multiple read threads would help in improving the read > throughput. > Discussion on this can be found at > http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201209.mbox/%3ccaolhydqpzn-v10zynfwud_h0qzrxtmjgttx7a9eofohyyty...@mail.gmail.com%3e > Reviewboard : https://reviews.apache.org/r/7560/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-429) Provide separate read and write threads in the bookkeeper server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aniruddha updated BOOKKEEPER-429: - Description: The current bookkeeper server is single threaded. The same thread handles reads and writes. When reads are slow (possibly because of excessive seeks), add entry operations suffer in terms of latencies. Providing separate read and write threads helps in reducing add entry latencies and increasing throughput even when we're facing slow reads. Having a single read thread also results in low disk utilization because seeks can't be ordered efficiently by the OS. Multiple read threads would help in improving the read throughput. Discussion on this can be found at http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201209.mbox/%3ccaolhydqpzn-v10zynfwud_h0qzrxtmjgttx7a9eofohyyty...@mail.gmail.com%3e Reviewboard : https://reviews.apache.org/r/7560/ was: The current bookkeeper server is single threaded. The same thread handles reads and writes. When reads are slow (possibly because of excessive seeks), add entry operations suffer in terms of latencies. Providing separate read and write threads helps in reducing add entry latencies and increasing throughput even when we're facing slow reads. Having a single read thread also results in low disk utilization because seeks can't be ordered efficiently by the OS. Multiple read threads would help in improving the read throughput. Discussion on this can be found at http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201209.mbox/%3ccaolhydqpzn-v10zynfwud_h0qzrxtmjgttx7a9eofohyyty...@mail.gmail.com%3e > Provide separate read and write threads in the bookkeeper server > > > Key: BOOKKEEPER-429 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-429 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Aniruddha >Assignee: Aniruddha > Fix For: 4.3.0 > > Attachments: BK-429.patch > > > The current bookkeeper server is single threaded. The same thread handles > reads and writes. When reads are slow (possibly because of excessive seeks), > add entry operations suffer in terms of latencies. Providing separate read > and write threads helps in reducing add entry latencies and increasing > throughput even when we're facing slow reads. Having a single read thread > also results in low disk utilization because seeks can't be ordered > efficiently by the OS. Multiple read threads would help in improving the read > throughput. > Discussion on this can be found at > http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201209.mbox/%3ccaolhydqpzn-v10zynfwud_h0qzrxtmjgttx7a9eofohyyty...@mail.gmail.com%3e > Reviewboard : https://reviews.apache.org/r/7560/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-429) Provide separate read and write threads in the bookkeeper server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aniruddha updated BOOKKEEPER-429: - Attachment: BK-429.patch > Provide separate read and write threads in the bookkeeper server > > > Key: BOOKKEEPER-429 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-429 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Aniruddha >Assignee: Aniruddha > Fix For: 4.3.0 > > Attachments: BK-429.patch > > > The current bookkeeper server is single threaded. The same thread handles > reads and writes. When reads are slow (possibly because of excessive seeks), > add entry operations suffer in terms of latencies. Providing separate read > and write threads helps in reducing add entry latencies and increasing > throughput even when we're facing slow reads. Having a single read thread > also results in low disk utilization because seeks can't be ordered > efficiently by the OS. Multiple read threads would help in improving the read > throughput. > Discussion on this can be found at > http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201209.mbox/%3ccaolhydqpzn-v10zynfwud_h0qzrxtmjgttx7a9eofohyyty...@mail.gmail.com%3e > Reviewboard : https://reviews.apache.org/r/7560/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-429) Provide separate read and write threads in the bookkeeper server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aniruddha updated BOOKKEEPER-429: - Issue Type: Improvement (was: Bug) > Provide separate read and write threads in the bookkeeper server > > > Key: BOOKKEEPER-429 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-429 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Aniruddha >Assignee: Aniruddha > Fix For: 4.3.0 > > Attachments: BK-429.patch > > > The current bookkeeper server is single threaded. The same thread handles > reads and writes. When reads are slow (possibly because of excessive seeks), > add entry operations suffer in terms of latencies. Providing separate read > and write threads helps in reducing add entry latencies and increasing > throughput even when we're facing slow reads. Having a single read thread > also results in low disk utilization because seeks can't be ordered > efficiently by the OS. Multiple read threads would help in improving the read > throughput. > Discussion on this can be found at > http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201209.mbox/%3ccaolhydqpzn-v10zynfwud_h0qzrxtmjgttx7a9eofohyyty...@mail.gmail.com%3e -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira