Re: [boost] borland patch for random/graph tests

2003-02-02 Thread Beman Dawes 
At 01:18 PM 2/2/2003, Alisdair Meredith wrote:

>The following 2 patches in Random will pass both the graph and
>random_demo tests for BCB6.  random_test still fails to compile with the
>compiler running out of memory.
>
>random\uniform_smallint [line 189]
>
>...
>#elif defined( __BORLANDC__ )
>...
>
>random\uniform_int [line 207]
>
>...
>#elif defined( __BORLANDC__ )
>...

Alisdair,

While I (and probably others!) would very much like to get fixes for 
random, there are a couple of issues:

* Patches really are best to be supplied as diff output; that cuts errors 
applying them.  The -c switch helps make them more readable. It may be 
better to attach the diff output as a file, if long lines would be wrapped 
by pasting it inline.

* Testing for "defined( __BORLANDC__ )" is usually discouraged because it 
will fail when the compiler changes to a new version which behaves 
differently. Also, there may be a Boost config macro which applies, and is 
the preferred way to detect a compiler deficiency.

Thanks,

--Beman


___
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost

[boost] borland patch for random/graph tests

2003-02-02 Thread Alisdair Meredith 
The following 2 patches in Random will pass both the graph and
random_demo tests for BCB6.  random_test still fails to compile with the
compiler running out of memory.

random\uniform_smallint [line 189]

#ifndef BOOST_NO_LIMITS_COMPILE_TIME_CONSTANTS
  typedef typename detail::uniform_smallint::is_integer>::BOOST_NESTED_TEMPLATE
impl::type impl_type;
#elif defined( __BORLANDC__ )
  typedef typename detail::uniform_smallint< boost::is_float::value == false
>::BOOST_NESTED_TEMPLATE impl::type impl_type;
#else
  BOOST_STATIC_CONSTANT(bool, base_float = (boost::is_float::value == false));
  typedef typename
detail::uniform_smallint::BOOST_NESTED_TEMPLATE
impl::type impl_type;
#endif


random\uniform_int [line 207]

#ifndef BOOST_NO_LIMITS_COMPILE_TIME_CONSTANTS
  typedef typename detail::uniform_int::is_integer>::BOOST_NESTED_TEMPLATE
impl::type impl_type;
#elif defined( __BORLANDC__ )
  typedef typename detail::uniform_int< boost::is_float::value == false
>::BOOST_NESTED_TEMPLATE impl::type impl_type;
#else
  BOOST_STATIC_CONSTANT(bool, base_float = (boost::is_float::value == false));
  typedef typename
detail::uniform_int::BOOST_NESTED_TEMPLATE
impl::type impl_type;
#endif


-- 
AlisdairM
Team Thai Kingdom

___
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost