Re: [Bridge] net: bridge: multicast: Renaming of flag BRIDGE_IGMP_SNOOPING
On Mon, 7 Jun 2021 21:29:34 +0530 Ujjal Roy wrote: > Hi Stephen, > > Can we rename this flag BRIDGE_IGMP_SNOOPING into something like > BRIDGE_MULTICAST_SNOOPING/BRIDGE_MCAST_SNOOPING? I am starting this > thread because this BRIDGE_IGMP_SNOOPING flag holds information about > IGMP only but not about MLD. Or this is not a common name to describe > both IGMP and MLD. Please let me know about my concern, so that I can > change the code and submit a patch. > > Thanks, > UjjaL Roy It is part of user API at this point so not possible to remove old definition.
[Bridge] [PATCH] net: bridge: remove redundant assignment
The variable br is assigned a value that is not being read after
exiting case IFLA_STATS_LINK_XSTATS_SLAVE. The assignment is
redundant and can be removed.
Addresses-Coverity ("Unused value")
Signed-off-by: Nigel Christian
---
net/bridge/br_netlink.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index e4e6e991313e..8642e56059fb 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -1644,7 +1644,6 @@ static size_t br_get_linkxstats_size(const struct
net_device *dev, int attr)
p = br_port_get_rtnl(dev);
if (!p)
return 0;
- br = p->br;
vg = nbp_vlan_group(p);
break;
default:
--
2.31.1
