Confirmed.
The set_property() statements are a bit different in this CMakeLists.txt
file: APPEND vs. APPEND_STRING
"If the APPEND option is given the list is appended to any existing
property value (except that empty values are ignored and not appended). If
the APPEND_STRING option is given the string is appended to any existing
property value as string, i.e. it results in a longer string and not a list
of strings."
However, I'll try again with current CMake binaries.
Regards,
Daniel
Am Mi., 10. Feb. 2021 um 16:46 Uhr schrieb Clifford Yapp <
cliffy...@gmail.com>:
> So, to confirm you're seeing the line:
>
> 32.2/include";CFG_RUNTIME_DOCDIR="C:/Program Files/BRL-CAD
> 7.32.2/share/man"-Ot -Oi
>
> Checking my output, it looks like:
>
> 32.2/include";CFG_RUNTIME_DOCDIR="C:/Program Files/BRL-CAD
> 7.32.2/share/man";-Ot -Oi
>
> Those flags are coming from this line (src/other/tcl/CMakeLists.txt:115):
>
> set_property(SOURCE ${srcfile} APPEND_STRING PROPERTY COMPILE_DEFINITIONS
> "-Ot -Oi -fp:strict -Gs -GS -GL -MD")
>
> My first suggestion would be to try a newer CMake version and see if that
> addresses it.
>
> Cliff
>
> On Wed, Feb 10, 2021 at 5:32 AM Daniel Roßberg <danielmrossb...@gmail.com>
> wrote:
>
>> Yes, clean checkout and new created build directory. CMake version is
>> 3.15.4.
>>
>> The bug is visible in the tcl.vcxproj file: In the lines containing
>> CFG_RUNTIME_DOCDIR, a semicolon is missing after the directory string. If
>> you have it with your version, I'll try again with an updated CMake.
>> (Unfortunately, it can happen that I can't update it before next Monday.)
>>
>> Regards,
>> Daniel
>>
>> Am Mi., 10. Feb. 2021 um 00:05 Uhr schrieb Clifford Yapp <
>> cliffy...@gmail.com>:
>>
>>> Is that with a clean build directory? Also, which version of CMake?
>>>
>>> I also built with VS2019, so it's curious that that configuration should
>>> fail...
>>>
>>>
>>> On Tue, Feb 9, 2021 at 10:44 AM Daniel Roßberg <
>>> danielmrossb...@gmail.com> wrote:
>>>
>>>> Hmm, my Visual Studio 2019 build fails, Release, sources from
>>>> branches/RELEASE, plain CMake run (nothing changed).
>>>> Error in src/other/tcl/generic/tclPkgConfig.c, line 107. The
>>>> CFG_RUNTIME_DOCDIR makro looks bad. It includes compiler switches after
>>>> the path string. They aren't cleanly separated (at least for Visual
>>>> Studio).
>>>>
>>>> Regards
>>>> Daniel
>>>>
>>>> Am Sa., 6. Feb. 2021 um 15:33 Uhr schrieb Clifford Yapp <
>>>> cliffy...@gmail.com>:
>>>>
>>>>> Release preparations are underway. Trunk sources merged to the
>>>>> RELEASE branch will be reviewed for sync to STABLE and release tagging.
>>>>> Please help test by compiling distcheck-full and running benchmark, mged,
>>>>> and archer.
>>>>> _______________________________________________
>>>>> BRL-CAD Developer mailing list
>>>>> brlcad-devel@lists.sourceforge.net
>>>>> https://lists.sourceforge.net/lists/listinfo/brlcad-devel
>>>>>
>>>> _______________________________________________
>>>> BRL-CAD Developer mailing list
>>>> brlcad-devel@lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/brlcad-devel
>>>>
>>> _______________________________________________
>>> BRL-CAD Developer mailing list
>>> brlcad-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/brlcad-devel
>>>
>> _______________________________________________
>> BRL-CAD Developer mailing list
>> brlcad-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/brlcad-devel
>>
> _______________________________________________
> BRL-CAD Developer mailing list
> brlcad-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/brlcad-devel
>
_______________________________________________
BRL-CAD Developer mailing list
brlcad-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-devel
