Rakshika,

This looks very promising.  Maybe you can play a little bit with the
tolerances to see the differences between zipping and stitching.  I'm
happy that you were able to solve the issues which made your live so
hard when you started.

Now, as the end of the coding period approaches, it's time to think
about all the small things which have to be done to polish up your
work:
- Is your coding style conform to what's written in HACKING?
- In shortestDistToLine() you allocate memory on the heap which would
better be on the stack, i.e. "double ortho[3];".  Are there more of
these?
- You shouldn't use malloc(), free() in MeshConversion_brlcad.cpp but
bu_malloc(), bu_free().  These functions operate on BRL-CAD structures
and should use the same methods as in the rest of BRL-CAD.  Here it
isn't a problem to use BRL-CAD functions because
MeshConversion_brlcad.cpp is only for BRL-CAD, it hasn't to be
portable.
- heal is an own command in mged and therefore should have an own file
in libged: src/libged/heal.c.
- Document your heal function e.g. for mged (in
doc/html/manuals/mged/mged_cmd_index.html?).


Regards,
    Daniel



2016-07-21 21:39 GMT+02:00 Rakshika Bagavathy <rakshika.bagava...@gmail.com>:
> Daniel,
>
> I'm attaching some more results from my tests. I'll attach the healed .g
> files for the two spheres too.
>
> Regards,
> Rakshika.

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev
_______________________________________________
BRL-CAD Developer mailing list
brlcad-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-devel

Reply via email to