[Bro-Dev] [Auto] Merge Status
Open Merge Requests === ID ComponentReporterAssigneeUpdated For Version PrioritySummary --- --- -- -- -- - -- - BIT-714 [1] BroControl aashish - 2013-08-142.2 Normal broctl install copies policy files to the .site folder in incorrect order Open GitHub Pull Requests = IssueComponentUser Updated Title --- --- -- -- #1 [2] bro anthonykasza [3] 2013-08-13 levenshtein distance [4] #1 [5] broccoli dcode [6] 2013-08-12 Updated specfile. Works under mock for EL6 [7] [1] BIT-714 https://bro-tracker.atlassian.net/browse/BIT-714 [2] Pull Request #1 https://github.com/bro/bro/issues/1 [3] anthonykaszahttps://github.com/anthonykasza [4] Merge Pull Request #1 with git pull https://github.com/anthonykasza/bro.git master [5] Pull Request #1 https://github.com/bro/broccoli/issues/1 [6] dcode https://github.com/dcode [7] Merge Pull Request #1 with git pull https://github.com/dcode/broccoli.git master ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1057) topic/jsiwek/bloomfilter-fix
Jon Siwek created BIT-1057: -- Summary: topic/jsiwek/bloomfilter-fix Key: BIT-1057 URL: https://bro-tracker.atlassian.net/browse/BIT-1057 Project: Bro Issue Tracker Issue Type: Patch Components: Bro Affects Versions: git/master Reporter: Jon Siwek Assignee: Matthias Vallentin Fix For: 2.2 The change (1) I did on this branch makes the bloomfilter-seed test start passing on 32-bit systems, though I'm not confident how correct it is. Matthias, can you review it and change this to a merge request if it looks sane? (1) https://github.com/bro/bro/commit/774dadfe9aedc9fed98df69abcc83a3068bdf06b -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://bro-tracker.atlassian.net/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1057) topic/jsiwek/bloomfilter-fix
[
https://bro-tracker.atlassian.net/browse/BIT-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13510#comment-13510
]
Matthias Vallentin commented on BIT-1057:
-
Yup, this looks good to me.
For the record: the problem was indeed that the platform-specific block size of
the bit vector. This could have resulted in different hash values, because the
hashing algorithm took the underlying representations (i.e., the bit vector
blocks) as opposed to the individual bits themselves. Moreover, the {{fmt}}
function casted the 32-bit value into 64-bit one, potentially causing undefined
behavior.
I will merge your changes into {{topic/matthias/bloom-filter}} and only do
cosmetic polishing, such as using Bro's {{uint64}} instead of {{uint64_t}}.
topic/jsiwek/bloomfilter-fix
Key: BIT-1057
URL: https://bro-tracker.atlassian.net/browse/BIT-1057
Project: Bro Issue Tracker
Issue Type: Patch
Components: Bro
Affects Versions: git/master
Reporter: Jon Siwek
Assignee: Matthias Vallentin
Fix For: 2.2
The change (1) I did on this branch makes the bloomfilter-seed test start
passing on 32-bit systems, though I'm not confident how correct it is.
Matthias, can you review it and change this to a merge request if it looks
sane?
(1) https://github.com/bro/bro/commit/774dadfe9aedc9fed98df69abcc83a3068bdf06b
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://bro-tracker.atlassian.net/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
___
bro-dev mailing list
bro-dev@bro.org
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1058) Memory leak in sumstats (probably)
Bernhard Amann created BIT-1058:
---
Summary: Memory leak in sumstats (probably)
Key: BIT-1058
URL: https://bro-tracker.atlassian.net/browse/BIT-1058
Project: Bro Issue Tracker
Issue Type: Problem
Components: Bro
Affects Versions: 2.2
Reporter: Bernhard Amann
Priority: High
Fix For: 2.2
Attachments: out2.pdf
At the moment, the core/leaks/basic-cluster.bro always fails; the gprof output
is attached. Only the master node leaks memory, the two worker nodes are fine.
From the gprof output, it looks like an increment operation is somehow
triggering a memory leak.
Robin and me tried to dig through this for quite some time. From our current
understanding it looks like the memory leak is (indirectly) caused by an
increment operation in a function that is called by an event that is received
through remoteserialization.
The closest we were able to track the leak to is line 249 of
scripts/base/frameworks/sumstats/cluster.bro:
{noformat}
event SumStats::cluster_send_result(uid: string, ss_name: string, key: Key,
result: Result, cleanup: bool)
{
[...]
++done_with[uid];
}
{noformat}
Commenting out this line fixes the memory leak (and probably renders the
sumstat framework inoperable); however we were not able to track it further to
the exact cause; replacing the increment with an equivalent done_with[uid] =
done_with[uid]+1; did not solve the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://bro-tracker.atlassian.net/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
___
bro-dev mailing list
bro-dev@bro.org
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
Re: [Bro-Dev] Move 3rdparty into a separate submodule
If someone can create a new git-repo for it, I can move it there… or I can file a bug-report :) Bernhard On Aug 15, 2013, at 11:37 AM, Seth Hall s...@icir.org wrote: On Aug 15, 2013, at 2:33 PM, Robin Sommer ro...@icir.org wrote: I think it's a good idea. Me too. -- Seth Hall International Computer Science Institute (Bro) because everyone has a network http://www.bro.org/ ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
Re: [Bro-Dev] Move 3rdparty into a separate submodule
bro-3rdparty exists now. You have admin privs, I suggest you prepare that one directly in its master branch, and then do a topic branch in bro that pulls that in. Robin On Fri, Aug 16, 2013 at 17:44 -0700, you wrote: If someone can create a new git-repo for it, I can move it there… or I can file a bug-report :) Bernhard On Aug 15, 2013, at 11:37 AM, Seth Hall s...@icir.org wrote: On Aug 15, 2013, at 2:33 PM, Robin Sommer ro...@icir.org wrote: I think it's a good idea. Me too. -- Seth Hall International Computer Science Institute (Bro) because everyone has a network http://www.bro.org/ ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev -- Robin Sommer * Phone +1 (510) 722-6541 * ro...@icir.org ICSI/LBNL* Fax +1 (510) 666-2956 * www.icir.org/robin ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1059) merge topic/bernhard/3rdparty
Bernhard Amann created BIT-1059: --- Summary: merge topic/bernhard/3rdparty Key: BIT-1059 URL: https://bro-tracker.atlassian.net/browse/BIT-1059 Project: Bro Issue Tracker Issue Type: Improvement Components: Bro Affects Versions: git/master Reporter: Bernhard Amann Fix For: 2.2 please merge topic/bernhard/3rdparty - sqlite moved there. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://bro-tracker.atlassian.net/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1059) merge topic/bernhard/3rdparty
[ https://bro-tracker.atlassian.net/browse/BIT-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernhard Amann updated BIT-1059: Status: Merge Request (was: Open) merge topic/bernhard/3rdparty - Key: BIT-1059 URL: https://bro-tracker.atlassian.net/browse/BIT-1059 Project: Bro Issue Tracker Issue Type: Improvement Components: Bro Affects Versions: git/master Reporter: Bernhard Amann Fix For: 2.2 please merge topic/bernhard/3rdparty - sqlite moved there. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://bro-tracker.atlassian.net/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
